<GitHub175>
[smoltcp] whitequark commented on pull request #190 9f89675: > I am happy to explain in more detail, but in short, the problem was that to access fragments from self I needed a mutable borrow of self, but the following processing (such as process_udp) uses a non-mutable borrow.... https://github.com/m-labs/smoltcp/pull/190#discussion_r183223161
<whitequark>
bb-m-labs: force build --props=package=rustc conda-all
<bb-m-labs>
build forced [ETA 32m11s]
<bb-m-labs>
I'll give a shout when the build finishes
<GitHub88>
[smoltcp] whitequark commented on pull request #187 4297051: Why are you manipulating the buffer directly in this test and not via the socket API? This defeats the purpose of testing the socket. https://github.com/m-labs/smoltcp/pull/187#discussion_r183223577
<GitHub131>
[smoltcp] whitequark commented on issue #193: So, the underlying cause is that PacketBuffer may use one entry in the metadata ring buffer for the padding, which causes buffer exhaustion when the actual metadata entry is inserted.... https://github.com/m-labs/smoltcp/pull/193#issuecomment-383348894
<rjo>
whitequark: did the repro that cjbe posted not work for you?
<whitequark>
rjo: oh sorry, I missed the fact that there is a repro
<whitequark>
going to check now
rohitksingh has joined #m-labs
rohitksingh has quit [Client Quit]
rohitksingh has joined #m-labs
rohitksingh has quit [Quit: Leaving.]
<rjo>
whitequark: thanks. if that doesn't do it, i'll reconstruct what i saw.
<rjo>
whitequark: also, ping RTT seems to be ~70ms when those kind of experiments are running (a bit of log traffic, monitoring traffic, and rpcs). is that expected?
<rjo>
and one other thing that i couldn't figure out: the scheduler.pause() RPC is ~500ms (c.f. the dummy scheduler.pause() call with artiq_run being <10ms)
<whitequark>
rjo: re ping: the smoltcp poll code currently isn't fair
<whitequark>
if the NIC can send packets faster than it forms them it's going to spit out the entire buffer however long it takes
<whitequark>
it might make sense to make transmit buffers smaller, or to add a deadline to poll
<whitequark>
probably the latter
<whitequark>
rjo: the scheduler.pause() issue is very odd
<whitequark>
for both of these, file issues if you want me to look at them and I'll do that