<GitHub-m-labs>
artiq/master 3318925 Florent Kermarrec: firmware/liboard_misoc/sdram: use similar loops on read_level_scan and read_level for consistent results
<GitHub-m-labs>
[artiq] hartytp commented on issue #1178: We considered both approaches and felt that, in this particular case, putting a 'run_until_complete' in the constructor was cleaner than making the user call some other method after construction but before any voltage setting calls. Is there some issue with our approach that I'm not seeing? Otherwise I guess we set the voltage limit to 0 in the constructor, document the
<GitHub-m-labs>
[artiq] sbourdeauducq commented on issue #1178: Yes: ``get_event_loop()`` may create an event loop. If this happens before the user sets an alternate event loop (required e.g. on Windows with ``ProactorEventLoop`` in some cases) we are in trouble. https://github.com/m-labs/artiq/pull/1178#issuecomment-430163415
<GitHub-m-labs>
[artiq] drewrisinger commented on pull request #1163 ead291c: As an example so people know how the checkboxes work (it's the first one). It's not immediately obvious just by looking at the boxes. Could add blank line:... https://github.com/m-labs/artiq/pull/1163#discussion_r225647381