<sb0>
you are testing for the sum of the lengths of all fields, whereas you should compare the lengths of each pair of fields independently
<sb0>
e.g. if you feed it from=(length 1, length 2) and to=(length 2, length 1) it will silently connect the fields one by one instead of erroring
<_florent_>
right it's not detecting that and using witdh is probably not appropriate
rohitksingh has quit [Ping timeout: 255 seconds]
<sb0>
blergh
<sb0>
Pack/Unpack doesn't deal with EndpointDescription, but Chunkerize/Unchunkerize do
<sb0>
_florent_, could you reimplement the Converter cleanly?
<sb0>
make it part of liteeth (it's not very generic...) and monolithic - a Converter module that instantiates UpConverter or DownConverter would be good.
<sb0>
those last two modules should essentially be like the current Pack/Unpack
<sb0>
and not do any crazy stuff
rohitksingh has joined #m-labs
ylamarre has joined #m-labs
<sb0>
flattening the hierarchy a bit (remove core/frontend), not using factory functions, and not having code in __init__.py would be nice as well ...
<sb0>
if isinstance(sdram_controller_settings, str):
<sb0>
why is SDRAMCore accessing phy.settings and its caller accessing phy.module.geom_settings and phy.module.timing_settings before passing them to it?
<GitHub28>
[artiq] whitequark pushed 2 new commits to new-py2llvm: http://git.io/vcCS3
<GitHub28>
artiq/new-py2llvm 7a6fc39 whitequark: Make delay component of function type unifyable.
<GitHub28>
artiq/new-py2llvm 651e6b1 whitequark: Remove build products from git.
<whitequark>
^ was a pretty nasty correctness bug
<sb0>
and why does the PHY need this module attribute at all?
<sb0>
it needs to know nothing about the DRAM geometry, goddammit
<sb0>
_florent_, the "margin" parameter of the ns function in SDRAM is to account for a possible change of the command phase (when switching between reads and writes) in half-rate PHYs ...
<sb0>
and more generally, when you find a "margin" in code I have written, there is a definitive reason for it
<sb0>
what's the point of the class attributes in the classes that inherit from SDRAMModule, if you need to overload and pass their values to the constructor?
<sb0>
also, why the discrepancy between NamedTuple and the dictionaries?
antgreen has joined #m-labs
bentley` has quit [Remote host closed the connection]
bentley` has joined #m-labs
antgreen has quit [Ping timeout: 256 seconds]
aeris has quit [Ping timeout: 256 seconds]
aeris has joined #m-labs
mumptai has joined #m-labs
ylamarre has quit [Ping timeout: 272 seconds]
ylamarre has joined #m-labs
ylamarre has quit [Remote host closed the connection]