solnic changed the topic of #rom-rb to: Ruby Object Mapper | Mailing List: https://groups.google.com/forum/?fromgroups#!forum/rom-rb | Logs: http://irclog.whitequark.org/rom-rb
<chendrix> weird, it all works now, haha
<chendrix> dkubb what's the point in hard-coding a flay total_score?
<dkubb> chendrix: the main reason for the way thresholds work is that when the quality in the code changes you know about it. if it raises, then you have to do something about it *or* accept it. if it drops, then you're supposed to adjust the threshold downward
<dkubb> the idea is that you draw a line in the sand and the code can't get any worse
<dkubb> but if the code gets better you raise the bar
<dkubb> we do that in a bunch of places. I think it's better than code quality fluctuating up and down without being aware of it. it is a bit annoying though.. especially when you have a WIP
<dkubb> we're going to be making it so the metrics only run for master commits, so feature branches can break the rules temporarily
<chendrix> hm, you're talking about total_score and not threshold, correct?
<chendrix> I understand why threshold, but it seems weird that you need to *know* exactly what your flay score is to get a report on your flay chunks
<dkubb> yeah, we're open to suggestions for improving it
cored has quit [Ping timeout: 246 seconds]
dkubb has quit [Quit: Linkinus - http://linkinus.com]
snusnu has quit [Quit: Leaving.]
knowtheory has quit [Quit: Computer has gone to sleep]
knowtheory has joined #rom-rb
knowtheory has quit [Ping timeout: 246 seconds]
dkubb has joined #rom-rb
solnic has joined #rom-rb
solnic_ has joined #rom-rb
solnic has quit [Read error: Connection reset by peer]
<solnic_> dkubb: morning
solnic_ has quit [Quit: Linkinus - http://linkinus.com]
solnic has joined #rom-rb
mbj has joined #rom-rb
chendrix has quit [Ping timeout: 250 seconds]
mbj has quit [Ping timeout: 246 seconds]
mbj has joined #rom-rb
zekefast has joined #rom-rb
Gibheer_ has joined #rom-rb
elskwid_ has joined #rom-rb
Gibheer has quit [*.net *.split]
yawniek has quit [*.net *.split]
elskwid has quit [*.net *.split]
elskwid_ is now known as elskwid
yawniek has joined #rom-rb
Gibheer_ is now known as Gibheer
knowtheory has joined #rom-rb
cored has joined #rom-rb
cored has joined #rom-rb
knowtheory has quit [Ping timeout: 248 seconds]
knowtheory has joined #rom-rb
snusnu has joined #rom-rb
<snusnu> mbj: planning on pimping the substation-demo?
snusnu has quit [Quit: Leaving.]
postmodern has quit [Quit: Leaving]
snusnu has joined #rom-rb
knowtheory has quit [Ping timeout: 276 seconds]
knowtheory has joined #rom-rb
cored has quit [Ping timeout: 276 seconds]
<mbj> snusnu: have to
<mbj> snusnu: mom
<dkubb> good morning
<solnic> morning dkubb
<mbj> hol
<mbj> a
<mbj> solnic, snusnu, dkubb: Dev meeting skype/hangout meeting now?
cored has joined #rom-rb
cored has joined #rom-rb
<solnic> mbj, dkubb, snusnu: yes I'm around, ping me on hangout and I'll join
<mbj> solnic: Forgot snsusnu cannt join a hangout :D
<solnic> mbj: why?
<mbj> solnic: For reasons snusnu will not open a gplus account :(
<solnic> mbj: lolwat
<solnic> mbj: well, fwiw I installed skype on my ipad
<mbj> solnic: heh
<solnic> so I can join a skype call :P
<mbj> solnic: Talk to him I tried to convinced him once!
<mbj> and failed, obviousely
<mbj> snusnu: ping
cored has quit [Ping timeout: 252 seconds]
<solnic> I need to help with in-house stuff, I'll be back around 18
cored has joined #rom-rb
cored has quit [Changing host]
cored has joined #rom-rb
<mbj> solnic: nice
<mbj> snusnu: its time :D
<mbj> my skype username is m_b_j.
<snusnu> mbj, solnic, dkubb: sorry guys, can't make it right now … we're still in a meeting :/ … i'll join you guys later if you're still around
<mbj> my client crashed, moment
<dkubb> solnic: are you on skype?
<solnic> dkubb: yes
<solnic> uhm, no, I closed my ipad :D
mbj has quit [Read error: Connection reset by peer]
mbj has joined #rom-rb
<mbj> ruboto
<dkubb> there's a guard-rubocop too. neat
<dkubb> I think I may start testing rubocop
<dkubb> maybe make a devtools branch for it, and start to make a config file that fits in with our style
<dkubb> we can debate it and come up with something that meets 80-90% of our needs. there'll always be subjective stuff though
<mbj> I totally agree.
<mbj> Also rubocop supports config inheritance
<dkubb> mbj: I think it would be neat to use rubocop to parse unparser output and try to get unparser to produce stuff that passes it
<mbj> dkubb: Yeah, that could move into the tests!
<mbj> So lets ship a default config with devtools, and we can override in config/rubucop.yml, project specific.
<dkubb> it uses parser too
<mbj> yeah, I know
<dkubb> yeah
<dkubb> sounds good
<mbj> So, i have to run, laters!
<dkubb> ttyl!
<dkubb> I've gtg to work too. will bbl
dkubb has quit [Quit: Linkinus - http://linkinus.com]
zekefast has quit [Quit: Leaving.]
<solnic> snusnu: dude I don't think you need a g+ account to have hangouts, it was merged with gtalk recently
<snusnu> solnic: ah ok, well, if that's possible, then i'm down with that
<solnic> snusnu: let's try hangout next time :)
<snusnu> solnic: yeah, i'll try to get it working for me before that
snusnu has quit [Quit: Leaving.]
snusnu has joined #rom-rb
snusnu has quit [Client Quit]
mbj has quit [Quit: leaving]
solnic has quit [Quit: Leaving...]
zekefast has joined #rom-rb
zekefast1 has joined #rom-rb
zekefast has quit [Ping timeout: 245 seconds]
mbj has joined #rom-rb
yawniek has quit [Ping timeout: 276 seconds]
yawniek has joined #rom-rb
mbj_ has joined #rom-rb
postmodern has joined #rom-rb
<mbj_> postmodern: hola, guess what? I found a really bad bug in mutant :D
mbj_ has quit [Quit: leaving]
<postmodern> mbj, oh really?
<mbj> postmodern: Mutant was blind for all memoized methods!
<postmodern> mbj, ah ha
<mbj> It silently ignored them!
<postmodern> mbj, was it the ||= ?
<mbj> And supporing mutations on adamantium memoizers (the only affected ones) turns out to be a bigger refactoring.
<mbj> only adamantium memoize!
<postmodern> mbj, interesting problem, how do you test whether you are mutating all types of ruby expressions
<mbj> postmodern: the problem is not in the mutator!
<mbj> postmodern: the problem is mutant silently skipped methods where #source_location is nil
<postmodern> mbj, ah!
<mbj> So not the mutator itself was broken, it was the mutation subject finder
<mbj> called "Matcher" in the code.
<postmodern> interesting
<mbj> postmodern: For checking I have all nodes covered, or explicitly handled as noop (not supported), I have an integration spec https://github.com/mbj/mutant/blob/master/spec/integration/mutant/test_mutator_handles_types_spec.rb
<postmodern> mbj, would this open up the possibility of mutating core classes
<postmodern> mbj, and mutant would ignore all built-in methods
<postmodern> mbj, and only select the monkey-patched methods
<mbj> mutant still ignores all methods it finds where source_location is nil, but it now tells you about this.
<mbj> Also I added a special case for Adamantiu, we store the original method in latest releases.
<mbj> So mutant can use the original methods source location to recurse.
<mbj> postmodern: BTW while talking about the noop mutator, I think we could make it generic.
<mbj> So currently the noop mutator stops recursion
<mbj> Also for nooped nodes that have childs that *might* be mutated.
<mbj> I could just emit children mutations at least
<mbj> postmodern: Nodes missing a dedicated mutator are here: https://github.com/mbj/mutant/blob/master/lib/mutant/mutator/node/noop.rb
<mbj> quite a LOT!
<mbj> So the generic one would just mutate children.
<mbj> I'll patch this in.
<mbj> thx for talking to me, that idea will add tons of new mutations!
<postmodern> excellent, more mutations!
<mbj> postmodern: TONS!
<mbj> This is a nice side effect from the uniformness of the whitequark/ast
<mbj> a lib that is used internally by whitequark/parser
<mbj> postmodern: 0.3 will be a very very nice release (feature wise)
<mbj> Assembling a changelog will be hard.
snusnu has joined #rom-rb
<mbj> snusnu: hi
<mbj> snusnu: you missed a nice hangout :D
<snusnu> mbj: yeah i can imagine :/ unfortunately i had no chance
<mbj> snusnu: small skype followup?
<mbj> snusnu: So I'd have all faces :D
<snusnu> mbj: yeah we can do that soon, right now is a bad time tho, a visitor is coming around in minutes
<snusnu> mbj: i'll be away during the weekend, but we'll find time soon
<mbj> np
knowtheory has quit [Quit: Computer has gone to sleep]
travis-ci has joined #rom-rb
<travis-ci> [travis-ci] Build details : http://travis-ci.org/mbj/mutant/builds/8749751
<travis-ci> [travis-ci] mbj/mutant#448 (master - 4211dfa : Markus Schirp): The build was broken.
travis-ci has left #rom-rb [#rom-rb]
knowtheory has joined #rom-rb
<mbj> postmodern: generic mutator is on master!
zekefast1 has quit [Quit: Leaving.]
<snusnu> mbj: i tried to run the new mutant on substation failure-chains branch, and it immediately bails out with: undefined method `type' for :response:Symbol
<mbj> snusnu: yeah
<mbj> snusnu: same here
<mbj> mom
<mbj> snusnu: mutant is the last unmutationcovered software I have :D
<snusnu> mbj: :)
<snusnu> mbj: want me to report an issue or are you on it already? ;)
knowtheory has quit [Quit: Get MacIrssi - http://www.sysctl.co.uk/projects/macirssi/]