DrShoggoth has quit [Ping timeout: 252 seconds]
elia has quit [Quit: Computer has gone to sleep.]
travis-ci has joined #opal
<
travis-ci>
[travis-ci] elia/opal#29 (fix-defined - 57fb2d1 : Elia Schito): The build is still failing.
travis-ci has left #opal [#opal]
meh` has quit [Read error: Operation timed out]
elia has joined #opal
DouweM has quit [Ping timeout: 256 seconds]
adambeynon has joined #opal
DouweM has joined #opal
kludge` has quit [Ping timeout: 265 seconds]
kludge` has joined #opal
meh` has joined #opal
lectrick has quit [Ping timeout: 246 seconds]
adrocknaphobia has quit [Ping timeout: 246 seconds]
adambeynon has joined #opal
<
elia>
adambeynon, hey
<
adambeynon>
elia: hello!
<
elia>
adambeynon, reduced defined_spec to just 43 failures :)
<
elia>
mostly related to regexp globals and super
<
adambeynon>
elia: thats awesome. I remember there being a load of specs there, so thats really good going
<
adambeynon>
regexp globals as in $1...$9 ?
<
elia>
adambeynon, yes, plus $` $& etc.
<
elia>
adambeynon, that is the diff, review is appreciated ;)
<
adambeynon>
elia: yeah, looks good to me
<
adambeynon>
with the ivar fixme
<
adambeynon>
a simple `#{self}.hasOwnProperty(#{var_name})` would probably do the trick there
<
adambeynon>
we initialize variables to nil on the prototype, not the object itself
<
adambeynon>
actually, that might not be true for classes
<
adambeynon>
but, class ivars can be fixed to do it on the prototype as well
<
elia>
adambeynon, good!
<
adambeynon>
elia: is that a module method?
<
elia>
adambeynon, nope, Observable#add_observer
<
adambeynon>
aye, yeh I meant a method defined inside a module
adrocknaphobia has joined #opal
<
meh`>
adambeynon, we have a pretty important super bug, pls fix
<
adambeynon>
meh`: where?
lectrick has joined #opal
<
adambeynon>
meh`: ahh, must have missed that notification
<
meh`>
adambeynon, I also need Class#clone asap
<
meh`>
it's vital in lissio to decouple models from adapters
fkchang has joined #opal
<
adambeynon>
meh`: so in lissio, each model gets extended with an adapter?
<
meh`>
adambeynon, optionally
<
meh`>
adambeynon, there's #adapter that extends the class with the adapter
<
meh`>
adambeynon, and there's #for that clones the class and applies the adapter
<
meh`>
I have to clone it because the properties are on an instance variable of the class
<
meh`>
and I'd rather not inherit and do some reflection magic
GitHub87 has joined #opal
<
GitHub87>
opal/master 34f06e3 Adam Beynon: Remove defines_[defn|defs] flags from compiler...
GitHub87 has left #opal [#opal]
elia has quit [Read error: Operation timed out]
<
adambeynon>
meh`: one problem with getting rspec to work is async specs might become tricky..
DouweM has quit [Ping timeout: 245 seconds]
travis-ci has joined #opal
<
travis-ci>
[travis-ci] opal/opal#1102 (master - 34f06e3 : Adam Beynon): The build passed.
travis-ci has left #opal [#opal]
GitHub92 has joined #opal
GitHub92 has left #opal [#opal]
<
GitHub92>
opal/master 5cc56f3 Adam Beynon: Name anonymous classes when assigning to a constant
DouweM has joined #opal
adambeynon has joined #opal