sb0 changed the topic of #m-labs to: ARTIQ, Migen, MiSoC, Mixxeo & other M-Labs projects :: fka #milkymist :: Logs http://irclog.whitequark.org/m-labs
futarisIRCcloud has joined #m-labs
<GitHub85> [smoltcp] LuoZijun opened pull request #145: remove linux only feature (master...patch-7) https://github.com/m-labs/smoltcp/pull/145
<GitHub6> [smoltcp] LuoZijun opened pull request #146: Add `netmask()/broadcast()/network()` method on IPv4Cidr #144 (master...patch-8) https://github.com/m-labs/smoltcp/pull/146
rohitksingh-demo has joined #m-labs
<GitHub175> [smoltcp] whitequark commented on issue #145: I'm not so sure. On Windows we don't support either tap interfaces or raw sockets (and probably never will), so should remove both of these from default features forever? The primary platform for developing smoltcp is Linux, after all... https://github.com/m-labs/smoltcp/pull/145#issuecomment-362877229
rohitksingh-demo has quit [Quit: Leaving.]
<GitHub88> [smoltcp] whitequark commented on pull request #146 65984e5: Your computations are incorrect for prefix lengths that are not a multiple of 8. There is no requirement that prefix length be a multiple of 8. https://github.com/m-labs/smoltcp/pull/146#discussion_r165832372
<GitHub53> [smoltcp] whitequark commented on pull request #146 65984e5: These should be separate methods. https://github.com/m-labs/smoltcp/pull/146#discussion_r165832384
<GitHub64> [smoltcp] whitequark commented on pull request #146 65984e5: This method doesn't make any sense to me. What is "network CIDR"? `self` is already a CIDR. https://github.com/m-labs/smoltcp/pull/146#discussion_r165832337
<GitHub18> [smoltcp] whitequark commented on pull request #146 65984e5: It's not "netmask address", it's "network mask". https://github.com/m-labs/smoltcp/pull/146#discussion_r165832360
kraza has quit [Ping timeout: 260 seconds]
<GitHub53> [smoltcp] LuoZijun commented on issue #145: just remove `phy-tab_interface` from default features forever.... https://github.com/m-labs/smoltcp/pull/145#issuecomment-362879009
<GitHub35> [smoltcp] LuoZijun commented on pull request #146 65984e5: CIDR not eq network.... https://github.com/m-labs/smoltcp/pull/146#discussion_r165833076
<GitHub40> [smoltcp] LuoZijun commented on pull request #146 65984e5: CIDR not always eq network.... https://github.com/m-labs/smoltcp/pull/146#discussion_r165833076
mumptai_ has joined #m-labs
mumptai has quit [Ping timeout: 264 seconds]
<GitHub65> [smoltcp] LuoZijun commented on pull request #146 65984e5: just do XOR ? https://github.com/m-labs/smoltcp/pull/146#discussion_r165833261
rohitksingh-demo has joined #m-labs
<GitHub190> [smoltcp] whitequark commented on pull request #146 65984e5: OK, the documentation is confusing. How about:... https://github.com/m-labs/smoltcp/pull/146#discussion_r165833745
<GitHub169> [smoltcp] whitequark commented on pull request #146 65984e5: This test is incorrect. It should be:... https://github.com/m-labs/smoltcp/pull/146#discussion_r165833759
<GitHub152> [smoltcp] whitequark commented on pull request #146 65984e5: I don't see how this helps. I've commented below on a test to show how this method should work. https://github.com/m-labs/smoltcp/pull/146#discussion_r165833764
<GitHub4> [smoltcp] whitequark commented on issue #145: Yeah, this e.g breaks README:... https://github.com/m-labs/smoltcp/pull/145#issuecomment-362881169
<GitHub68> [smoltcp] whitequark commented on pull request #145 f816c74: I don't think `target_os = "linux"` is necessary. https://github.com/m-labs/smoltcp/pull/145#discussion_r165833790
rohitksingh-demo has quit [Read error: Connection reset by peer]
rohitksingh-demo has joined #m-labs
rohitksingh has joined #m-labs
rohitksingh-demo has quit [Quit: Leaving.]
rohitksingh has quit [Ping timeout: 256 seconds]
forrestv_ has joined #m-labs
forrestv has quit [*.net *.split]
forrestv_ is now known as forrestv
<GitHub46> [smoltcp] LuoZijun commented on pull request #146 25e8ca7: ok https://github.com/m-labs/smoltcp/pull/146#discussion_r165836035
<GitHub89> [smoltcp] LuoZijun commented on pull request #146 25e8ca7: now should be correct。 https://github.com/m-labs/smoltcp/pull/146#discussion_r165836351
<GitHub48> [smoltcp] LuoZijun commented on pull request #146 25e8ca7: now should be correct。... https://github.com/m-labs/smoltcp/pull/146#discussion_r165836356
<GitHub176> [smoltcp] LuoZijun commented on issue #145: ok, i did not know that problem.... https://github.com/m-labs/smoltcp/pull/145#issuecomment-362888762
<GitHub9> [smoltcp] whitequark closed pull request #145: remove linux only feature (master...patch-7) https://github.com/m-labs/smoltcp/pull/145
<GitHub162> [smoltcp] whitequark pushed 1 new commit to master: https://github.com/m-labs/smoltcp/commit/4aa8ec48ae4c57ae751ee4a6e147ed499c76abd9
<GitHub162> smoltcp/master 4aa8ec4 寧靜: Add missing #[cfg(feature = "phy-tap_interface")].
<travis-ci> m-labs/smoltcp#687 (master - 4aa8ec4 : 寧靜): The build passed.
<GitHub11> [smoltcp] LuoZijun commented on issue #146: does need a method `with_netmask()` ?... https://github.com/m-labs/smoltcp/pull/146#issuecomment-362894953
<GitHub55> [smoltcp] LuoZijun commented on issue #146: does need a method `with_netmask()` ?... https://github.com/m-labs/smoltcp/pull/146#issuecomment-362894953
<GitHub171> [smoltcp] LuoZijun commented on issue #146: does need a method `with_netmask()` ?... https://github.com/m-labs/smoltcp/pull/146#issuecomment-362894953
<GitHub74> [smoltcp] LuoZijun commented on issue #146: does need a method `with_netmask()` ?... https://github.com/m-labs/smoltcp/pull/146#issuecomment-362894953
<GitHub178> [smoltcp] whitequark commented on pull request #146 25e8ca7: Just `IPv4 CIDR`, we don't know if `self` is a block or a specific address. https://github.com/m-labs/smoltcp/pull/146#discussion_r165836995
<GitHub177> [smoltcp] whitequark commented on pull request #146 25e8ca7: This expression is equivalent to `0xffffffff >> network.prefix_len`. https://github.com/m-labs/smoltcp/pull/146#discussion_r165836935
<GitHub81> [smoltcp] whitequark commented on pull request #146 25e8ca7: This will panic if `self.prefix_len == 0`. Please test edge cases like this. https://github.com/m-labs/smoltcp/pull/146#discussion_r165836926
<GitHub56> [smoltcp] whitequark commented on pull request #146 25e8ca7: Same as for `netmask`. https://github.com/m-labs/smoltcp/pull/146#discussion_r165836997
<GitHub23> [smoltcp] whitequark commented on issue #146: To be honest, I don't know why you even bother with netmasks in the first place. Netmasks are an outdated concept and they shouldn't really be used today. https://github.com/m-labs/smoltcp/pull/146#issuecomment-362896039
<GitHub169> [smoltcp] LuoZijun commented on issue #146: in real world, when you doing `unix network programming` , the `netmask` always follow you.... https://github.com/m-labs/smoltcp/pull/146#issuecomment-362898288
<GitHub6> [smoltcp] LuoZijun commented on issue #146: so, if you have no objection, I will add ' with_netmask ' method.... https://github.com/m-labs/smoltcp/pull/146#issuecomment-362898542
<GitHub179> [smoltcp] LuoZijun commented on pull request #146 25e8ca7: ok, i will add more test. https://github.com/m-labs/smoltcp/pull/146#discussion_r165840759
<GitHub96> [smoltcp] LuoZijun commented on pull request #146 25e8ca7: 👍 https://github.com/m-labs/smoltcp/pull/146#discussion_r165840763
<GitHub151> [smoltcp] whitequark commented on pull request #146 207c9ef: This assertion follows trivially from the line above, so it's not necessary. https://github.com/m-labs/smoltcp/pull/146#discussion_r165841140
<GitHub24> [smoltcp] whitequark commented on pull request #146 207c9ef: I think this function must check that the ones in netmask are all consecutive and left-aligned, and return a `Result`. https://github.com/m-labs/smoltcp/pull/146#discussion_r165841129
<GitHub177> [smoltcp] whitequark commented on pull request #146 207c9ef: Actually, this is not right. A /31 subnet or /32 "subnet" [does not have a broadcast address](http://packetlife.net/blog/2008/jun/18/using-31-bit-subnets-on-point-point-links/). So, this function should return an `Option<Address>`. https://github.com/m-labs/smoltcp/pull/146#discussion_r165841187
<GitHub164> [smoltcp] whitequark commented on pull request #146 207c9ef: This function never panics (as written). https://github.com/m-labs/smoltcp/pull/146#discussion_r165841194
<sb0> whitequark, ping
<whitequark> sb0: pong
<whitequark> oh, development time, sec
<whitequark> done
<GitHub158> [smoltcp] LuoZijun commented on pull request #146 803bb55: wow, you are very professional. https://github.com/m-labs/smoltcp/pull/146#discussion_r165846101
<GitHub9> [smoltcp] LuoZijun commented on pull request #146 803bb55: 👍 https://github.com/m-labs/smoltcp/pull/146#discussion_r165846114
dlrobertson has quit [Quit: Quit]
mumptai_ is now known as mumptai
rohitksingh has joined #m-labs
rohitksingh has quit [Ping timeout: 240 seconds]
mumptai has quit [Quit: Verlassend]
<GitHub71> [sinara] filipswit pushed 1 new commit to master: https://git.io/vNpzH
<GitHub71> sinara/master e745783 Filip Świtakowski: SaymaAMC manual