sb0 changed the topic of #m-labs to: ARTIQ, Migen, MiSoC, Mixxeo & other M-Labs projects :: fka #milkymist :: Logs http://irclog.whitequark.org/m-labs
X-Scale has quit [Ping timeout: 256 seconds]
X-Scale has joined #m-labs
<GitHub52> [artiq] sbourdeauducq commented on issue #854: Why do you insist on waiting for the FPGA config to be done before setting up the PHY? This adds complexity in a system that is already extremely fragile and buggy. https://github.com/m-labs/artiq/issues/854#issuecomment-357108609
<GitHub87> [artiq] gkasprow commented on issue #854: I don't remember exactly, but had an impression that PHY didn't wanted to work in RGMII mode without valid TX clock. I wrote about it in some of issues... https://github.com/m-labs/artiq/issues/854#issuecomment-357110540
<GitHub121> [artiq] philipkent commented on issue #888: @whitequark This is the error I was getting when trying to install rust.... https://github.com/m-labs/artiq/issues/888#issuecomment-357113636
<GitHub174> [artiq] sbourdeauducq commented on issue #888: > I just noticed the mention of the artiq-dev package in the instructions for version 3 I didn't realize those were available, would that be enough to build the gateware with an updated FIFO depth?... https://github.com/m-labs/artiq/issues/888#issuecomment-357120968
<GitHub143> [artiq] sbourdeauducq commented on issue #888: > We need to build a modified version of the gateware with the output FIFO depth increased to 1024. We did this for ARTIQ version 2 and it reduced the number of underflow errors we we're getting. We tried running a few experiments using the gateware provided in the ARTIQ version 3 conda packages but that resulted in underflow errors that did not occur using the version
<GitHub34> [artiq] sbourdeauducq commented on issue #854: But this is not an issue with MII, where the PHY is always generating clocks, and this would eliminate another potential source of bugs. https://github.com/m-labs/artiq/issues/854#issuecomment-357125597
<GitHub58> [artiq] sbourdeauducq closed pull request #889: firmware: make read leveling robust for KUS SDRAM (master...robust-kus-read-leveling) https://github.com/m-labs/artiq/pull/889
<GitHub147> [artiq] sbourdeauducq pushed 1 new commit to master: https://github.com/m-labs/artiq/commit/7429ee4fb63316b05da07407d6802670ebdb80fd
<GitHub147> artiq/master 7429ee4 Chris Ballance: firmware: make read leveling robust for KUS SDRAM...
<GitHub42> [artiq] sbourdeauducq commented on issue #889: Thanks! https://github.com/m-labs/artiq/pull/889#issuecomment-357126308
<sb0> rjo, kasli is still down ...
<GitHub129> [misoc] sbourdeauducq pushed 1 new commit to master: https://github.com/m-labs/misoc/commit/4a1154ad36a328c9ad764d2e00628a53cfbc3cdf
<GitHub129> misoc/master 4a1154a Sebastien Bourdeauducq: bios: make read leveling robust for KUS SDRAM
<bb-m-labs> build #1055 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/1055
<bb-m-labs> build #343 of misoc is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/misoc/builds/343
futarisIRCcloud has joined #m-labs
<bb-m-labs> build #687 of artiq-win64-test is complete: Warnings [warnings python_coverage] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/687 blamelist: Chris Ballance <chris.ballance@physics.ox.ac.uk>
<bb-m-labs> build #1927 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/1927
cedric has quit [Read error: Connection reset by peer]
cedric has joined #m-labs
cedric has quit [Changing host]
cedric has joined #m-labs
rohitksingh_work has joined #m-labs
sb0 has quit [Quit: Leaving]
sb0 has joined #m-labs
<GitHub5> [artiq] sbourdeauducq commented on issue #854: This new firmware exhibits exactly the same bug as before: the link is up at power-up, then it goes down and does not go back up when the FPGA is configured. Please keep things simple and configure the PHY once at startup and regardless of the state of the FPGA.... https://github.com/m-labs/artiq/issues/854#issuecomment-357144317
<GitHub81> [artiq] sbourdeauducq commented on issue #854: This new firmware exhibits exactly the same bug as before: the link is up at power-up, then it goes down and does not go back up when the FPGA is configured. Please keep things simple and configure the PHY once at startup and regardless of the state of the FPGA. We do not need Ethernet access to the MMC for now, you can implement it and debug it later.... https://gith
<GitHub163> [smoltcp] hjr3 commented on pull request #116 aa52656: i thought about doing this, but it will cause a lot of change in the parser. before trying to parse a ipv4 address, i would have to `self.accept_char(b':')?;`. should the parser fail, the check down below looks ahead of `b':'` and errors if one is not present. i would also have to remove the `self.accept_char(b':')?;` in the `None` case for the double colon
<GitHub95> [smoltcp] hjr3 commented on pull request #116 aa52656: done https://github.com/m-labs/smoltcp/pull/116#discussion_r161143278
<GitHub184> [smoltcp] hjr3 commented on pull request #116 aa52656: yes, fixed. https://github.com/m-labs/smoltcp/pull/116#discussion_r161143290
reportingsjr has quit [Ping timeout: 264 seconds]
reportingsjr has joined #m-labs
larsc has quit [Remote host closed the connection]
wolfspra1l has quit [Read error: Connection reset by peer]
<GitHub25> [artiq] jordens commented on issue #888: And the documentation also clearly states that that approach to installing from source is irrelevant to you. Just use the conda packages pulled in by artiq-dev. https://github.com/m-labs/artiq/issues/888#issuecomment-357165688
rohitksingh_work has quit [Read error: Connection reset by peer]
lars_ has joined #m-labs
futarisIRCcloud has quit [Quit: Connection closed for inactivity]
lars_ has joined #m-labs
<rjo> sb0: the power supply was off. don't know whether the OCP/OVP tripped (set to 16V, 2A, while the supply is at 12V, 1.6A) or whether there was some power glitch. The other channel had also turned off i.e. I'd gravitate towards suspecting the latter.
<rjo> sb0: kasli is back up. please don't try to use the xilinx cable. i need that for urukul.
<rjo> sb0: if it helps you i can connect SFP0 to SFP2 either by copper (SFP-to-SFP hard link) or by 1000Base-BX
<rjo> sb0: and there is a networked DP832 at 'hoots' that powers kasli, on channel 1, if you need to power cycle it.
<sb0> keep it on the switch
<sb0> does your switch have diagnostic modes that let you see info about the bare received signal?
<rjo> i don't think so. it's a gs110tp.
<GitHub162> [artiq] jordens pushed 1 new commit to master: https://github.com/m-labs/artiq/commit/ac3c3871d07118a84b4ce9982f3c9f10b64b1721
<GitHub162> artiq/master ac3c387 Robert Jordens: kasli: s/extensions/variant/g
<GitHub83> [artiq] gkasprow commented on issue #854: OK, I fill make it simple. But does it improve when you make PHY dump?... https://github.com/m-labs/artiq/issues/854#issuecomment-357215677
<GitHub46> [artiq] gkasprow commented on issue #854: OK, I will make it simple. But does it improve when you make PHY dump?... https://github.com/m-labs/artiq/issues/854#issuecomment-357215677
<GitHub102> [artiq] gkasprow commented on issue #854: The only access of MMC to MII is when MMC configures the PHY. Then it is permanently attached to FPGA. https://github.com/m-labs/artiq/issues/854#issuecomment-357216404
<rjo> whitequark: are you using the performance counters in the kernel cpu or can i disable them? they lead to terrible timing paths with ~23 levels of logic which fail on kasli.
hartytp has joined #m-labs
<hartytp> sbo, _florent_: looking at HMC830. Output is garbage; very noisy and roughly at 750MHz. Buest guess is that the VCO auto cal hasn't worked.
<hartytp> Will confirm and get back
<_florent_> hartytp: ok thanks
<sb0> hartytp, good, thanks for looking into this!
<sb0> hartytp, should I send you a sayma amc so you can test drtio soon?
<GitHub58> [smoltcp] phil-opp opened pull request #117: Return `UdpSocket` from `UdpSocket::new` (instead of `Socket`) (master...patch-1) https://github.com/m-labs/smoltcp/pull/117
<bb-m-labs> build #1056 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/1056
<bb-m-labs> build #1928 of artiq is complete: Failure [failed python_coverage_1] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/1928 blamelist: Robert Jordens <rj@m-labs.hk>
<rjo> mor1kx really doesn't map well to 7 series or there is something weird going on. https://hastebin.com/ozeyafepuq.pl
<sb0> rjo, how many hp are kasli, urukul, and ttl-sma?
<sb0> rjo, tried with the new vivado on the HK computer?
<hartytp> good 100MHz input clock at HMC830: check
<rjo> 4 each
<rjo> everything is either 4 or 8. only stuff with bnc is 8.
<hartytp> VCO tuning sensitivity is about 10MHz/V. Frequency error is 250MHz, so tuning voltage that would be needed to lock would be about 25V. So, the VCO must be on the wrong range. So, this does look like a programming issue
<hartytp> (no, DAC clock should be 2.4GHz, not 1GHz, so the frequency error is worse than that. In any case, definitely not the correct VCO)
<hartytp> (sorry, nope, 1.2GHz output expected....)
sb0 has quit [Quit: Leaving]
<rjo> sb0: vivado 2017.4 gives the same timing failure.
sb0 has joined #m-labs
<sb0> the GTP RX still refuses to work
<sb0> sigh
<sb0> data is still stuck at 0 or 0x7805c
<sb0> whitequark, I found out that Andrew wrote a 1000BASE-X core for artix7 that he claims is working. can you integrate it with misoc as a backup plan, in case the xilinx transceiver trash continues to act up?
<sb0> in simulation rx_data is also stuck at zero, which would be straigforward to debug if the xilinx fuckers did not encrypt their idiotic IP
<sb0> I had the keys somewhere (they were leaked) but I cannot find them atm
<hartytp> _florent_, sb0 can you send me binaries for sayma_test to save me from building it myself?
<sb0> hartytp, what is sayma_test? florent's repo?
<sb0> I don't have anything installed (except vivado, which I believe you also have) to compile it...
<hartytp> yes florent's repo
<hartytp> also needs litex, but I can install that. Just wanted to save some time by avoiding a build
<sb0> ...and of course, problems like rx_data stuck at 0 would have been avoided altogether if the transceiver RX were a dumb deserializer with a CDR, as it should be
<sb0> now the only two debugging techniques I can think of is 1) decrypt the secureip bullshit or 2) simulate one of their cores, mix it with my code, then bisect which of their dozens of undocumented parameters is set wrong
<hartytp> _florent_ can you send me binaries to save time
<sb0> hartytp, btw do you have a copper SFP cable for testing DRTIO on Sayma?
<hartytp> IIRC yes, but will have to check
<hartytp> can buy one in any case
<hartytp> okay: HMC830 SPI transactions look fine. Dumped the default contents of the registers before and programming
<hartytp> all as expected
<sb0> hartytp, and SATA/SFP adapter for Ethernet?
<sb0> and media converter?
<sb0> I wonder if you'll get a link with Greg's MII firmware
<sb0> by the way, you can flash this MMC using a cheap Olimex cable
<sb0> with openocd and linux
<sb0> or no cable at all using the UART bootloader but I don't know how this works. right now this feature is just causing bugs on my boards...
<hartytp> okay, I think I might know what the problem is
<hartytp> here, I placed a HMC830 reg dump before and after configration
<hartytp> look at reg 0x10
<hartytp> that indicates that the autotune is stil searching
<hartytp> may just need a little more time...
<hartytp> what's the best way to add a delay in firmware?
<GitHub164> [smoltcp] hjr3 commented on pull request #116 3ca5ff2: ignore my last comment. wrapping it in `self.try()` works fine.... https://github.com/m-labs/smoltcp/pull/116#discussion_r161251813
<GitHub129> [smoltcp] dlrobertson commented on pull request #116 3ca5ff2: AFAIK `use_tail` should be always true in this branch. https://github.com/m-labs/smoltcp/pull/116#discussion_r161251309
<GitHub24> [smoltcp] dlrobertson commented on pull request #116 3ca5ff2: `slice_patterns` isn't available on stable, so if we're going to use slice patterns an additional note should probably be added to https://github.com/m-labs/smoltcp/blob/master/.travis.yml#L4-L9 https://github.com/m-labs/smoltcp/pull/116#discussion_r161252833
<GitHub143> [smoltcp] dlrobertson commented on pull request #116 3ca5ff2: Might be more readable to just use `Address([values])` since you have to shift some bits. Feel free to ignore this comment. Just a nit. https://github.com/m-labs/smoltcp/pull/116#discussion_r161253889
<GitHub119> [smoltcp] dlrobertson commented on pull request #116 3ca5ff2: Nice work. The update is much more readable https://github.com/m-labs/smoltcp/pull/116#discussion_r161254642
<GitHub81> [smoltcp] dlrobertson commented on pull request #116 3ca5ff2: Actually my example was bad. `0:0:0:0:1:FFFF:192.168.1.1` is still parsed as a correctly formatted IPv4 mapped IPv6 address, but it shouldn't be. I think we need to check to ensure that the value of the head part contains only zero. https://github.com/m-labs/smoltcp/pull/116#discussion_r161256453
<hartytp> Sayma seems quite slow to flash
<hartytp> a couple of observations about the HMC830:
<hartytp> 1. The soft reset seems to be *very* slow. The data sheet says that 0x00 must be set to 0x00 for normal operation. But, this bricks the chip unless there is a long delay between write(0x00, 0x20) and write(0x00, 0x00)
<hartytp> 10ms isn't enough
<hartytp> 100 seems to work
<hartytp> 2. This is a set of reg dumps https://hastebin.com/rijuxupoke.css
<hartytp> note that 0x10 indicates that the chip is still searching for the correct VCO range after the 2s lock delay
<rjo> "slow to flash" being how much?
<hartytp> okay, I think I see why
<hartytp> minutes I think
<hartytp> will time
<hartytp> bit over 3 min. Maybe that's normal and I'm just not used to such large designs?
<rjo> write speed (incl erase) is around 64 kB/s limited by the flash. if you don't compress the bitstream is 16 MB.
Ishan_Bansal has quit [*.net *.split]
Ultrasauce has quit [*.net *.split]
Ultrasauce has joined #m-labs
Ishan_Bansal has joined #m-labs
<GitHub106> [artiq] jbqubit commented on issue #856: What's the status of this? https://github.com/m-labs/artiq/issues/856#issuecomment-357293934
<hartytp> Also, readback of reg 5 suggests that we're stuck on the lowest VCO. That's consistent with the 750MHz output frequency I'm measuring
<GitHub159> [smoltcp] hjr3 commented on pull request #116 33a30de: yes, removed https://github.com/m-labs/smoltcp/pull/116#discussion_r161278536
<GitHub137> [smoltcp] hjr3 commented on pull request #116 33a30de: fixed https://github.com/m-labs/smoltcp/pull/116#discussion_r161278572
<GitHub169> [smoltcp] hjr3 commented on pull request #116 33a30de: added https://github.com/m-labs/smoltcp/pull/116#discussion_r161278616
<GitHub157> [smoltcp] hjr3 commented on pull request #116 33a30de: Ah, yes. i updated the code to make sure that positions 0-4 of the head are 0. I also added some more test cases that fail. https://github.com/m-labs/smoltcp/pull/116#discussion_r161278907
<GitHub57> [smoltcp] hjr3 commented on issue #116: One job in the build matrix is failing do to a dependency. I am not sure why. I will look into this later. https://github.com/m-labs/smoltcp/pull/116#issuecomment-357301683
<GitHub150> [artiq] sbourdeauducq commented on issue #856: Try it on your board. Could be another hw problem. Tom and Florent are not experiencing it. https://github.com/m-labs/artiq/issues/856#issuecomment-357306860
mumptai has joined #m-labs
<ohsix> whitequark: are there any restrictions on how you ultimately want to use what you find? like wanting to be able to do it via usb and not ddc
<ohsix> can't work on it more until the weekend, but what i've done is come from the displayport side looking for incidental documentation on the chips and displayport to get register locations and order of operations; most of the 'code' stuff i found looking around was initializing some string tables and takes a ton of time to get to the useful spots
<ohsix> some of the stuff is standardized but haven't found definitive indication that cabc is at a not-vendor-specific location, there's some code in the kernel for intel stuff to change it
<ohsix> gotta leave it there for now tho
<GitHub191> [smoltcp] dlrobertson commented on pull request #116 33a30de: nit: I like `head_idx == 6 && head[:head_idx] == [0, 0, 0, 0, 0, 0xffff]` https://github.com/m-labs/smoltcp/pull/116#discussion_r161286969
<GitHub1> [smoltcp] dlrobertson commented on pull request #116 33a30de: Also need to make sure that `head_idx` is 0, otherwise `1::ffff:<ip>` is valid. https://github.com/m-labs/smoltcp/pull/116#discussion_r161286976
<_florent_> hartytp: sorry, i was not here, I'll send you the binaries for sayma_test tomorrow if you still want it
<whitequark> ohsix: no i just want to know the bank switching code
<whitequark> it's literally one i2c address, register, offset and length
<whitequark> rjo: I do not use the performance counters
<whitequark> frankly, based on their naive implementation that result is expected
<rjo> whitequark: ack. i'll back them out. they can easily be added back in when someone wants to test something.
mumptai has quit [Quit: Verlassend]
<GitHub35> [artiq] jordens pushed 1 new commit to master: https://github.com/m-labs/artiq/commit/529033e016fffc69c20895348e037370faf78d20
<GitHub35> artiq/master 529033e Robert Jordens: kernel_cpu: disable PCU...
<GitHub131> [smoltcp] whitequark commented on issue #117: 1. You broke Travis.... https://github.com/m-labs/smoltcp/pull/117#issuecomment-357321198
<GitHub26> [smoltcp] whitequark commented on pull request #116 33a30de: Um, I am against depending on slice_patterns. slice_rotate is *almost* stable. slice_patterns is a complex feature that's basically abandoned. https://github.com/m-labs/smoltcp/pull/116#discussion_r161297714
<GitHub176> [smoltcp] whitequark commented on pull request #116 33a30de: You don't even really need slice patterns here, just a comparison... https://github.com/m-labs/smoltcp/pull/116#discussion_r161297867
<GitHub20> [smoltcp] whitequark commented on pull request #116 33a30de: `head[0..head_idx] == [0, 0, 0, 0, 0, 0xffff]` ? https://github.com/m-labs/smoltcp/pull/116#discussion_r161298455
<GitHub93> [smoltcp] whitequark commented on pull request #116 33a30de: You don't even really need slice patterns here, just a comparison... See above. https://github.com/m-labs/smoltcp/pull/116#discussion_r161297867
<GitHub196> [rust] whitequark force-pushed artiq-1.23.0 from 066c954 to 7359f10: https://github.com/m-labs/rust/commits/artiq-1.23.0
<GitHub196> rust/artiq-1.23.0 7359f10 whitequark: Workaround for rust-lang/rust#46995.
<GitHub169> [artiq] whitequark closed issue #888: Installing artiq 3.1 from source fails during rust install https://github.com/m-labs/artiq/issues/888
<GitHub99> [artiq] whitequark commented on issue #888: Okay, this is a known rustc bug https://github.com/rust-lang/rust/issues/46995, I've updated our workaround for it in our rustc fork so you should no longer hit it. https://github.com/m-labs/artiq/issues/888#issuecomment-357326350
<bb-m-labs> build #1057 of artiq-board is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq-board/builds/1057
<bb-m-labs> build #688 of artiq-win64-test is complete: Warnings [warnings python_coverage] Build details are at http://buildbot.m-labs.hk/builders/artiq-win64-test/builds/688 blamelist: Robert Jordens <jordens@gmail.com>
<bb-m-labs> build #1929 of artiq is complete: Success [build successful] Build details are at http://buildbot.m-labs.hk/builders/artiq/builds/1929
mumptai has joined #m-labs
mumptai has quit [Remote host closed the connection]
<ohsix> whitequark: k, it reads those from the ini file in the dell update, and the keys in the ini reader, it's easy to find the reference to the constructor for the table; the hard part is finding references to the table
<GitHub85> [smoltcp] dlrobertson commented on issue #110: Updated. I used `checked_<op>` with an expect string in the operations because that is what is done in libstd.... https://github.com/m-labs/smoltcp/pull/110#issuecomment-357351031
key2 has joined #m-labs
<key2> hi
<key2> anyone using openocd to flash a bin file into a NOR FLASH here ?
<key2> I am experiencing something weird, when having a blank flash, if I use openocd, it will write the bitstream but it won't work. If I use impact with the same bin file, it works. from then, if I use openocd it works too. sounds like impact is adding or doing something openocd doesn't, and as long as it's not done, it won't boot on flash
<key2> anyone else has experienced that ?
<GitHub172> [smoltcp] whitequark commented on issue #110: > I don't see any sort of constructor for SystemTime other than SystemTime::now.... https://github.com/m-labs/smoltcp/pull/110#issuecomment-357352410
<GitHub34> [smoltcp] whitequark commented on pull request #110 dfcdf43: Can we just use `1000`? These constants are a net decrease in readability. https://github.com/m-labs/smoltcp/pull/110#discussion_r161324137
<GitHub91> [smoltcp] whitequark commented on pull request #110 dfcdf43: Conversely, what libstd does and what you forgot to do here is to check for division by zero. https://github.com/m-labs/smoltcp/pull/110#discussion_r161325242
<GitHub198> [smoltcp] whitequark commented on pull request #110 dfcdf43: I maintain my position that checking for unsigned overflow is a waste of time. https://github.com/m-labs/smoltcp/pull/110#discussion_r161325163
<key2> rjo: ping?
<rjo> key2: pong
<key2> Have you ever had this issue ?
<key2> having a flash that only works if hardware manager of xilinx writes on it
<key2> ?
<key2> I am trying with 3 different boards and have the same behavour
<rjo> hardware manager?
<key2> it's a persistent bit in the flash that tells if if it's working in 1x or 4x
key2_ has joined #m-labs
<key2_> QE bit. The Quad Enable (QE) bit, non-volatile bit, while it is "0" (factory default), it performs non-Quad and WP#, RESET# are enable. While QE is "1", it performs Quad I/O mode and WP#, RESET# are disabled. In the other word, if the system goes into four I/O mode (QE=1), the feature of HPM and RESET will be disabled
<key2_> rjo: so I guess I need to find a way to read/write the status reg of the flash
key2 has quit [Ping timeout: 260 seconds]
<GitHub6> [artiq] jbqubit commented on issue #856: Built .bit this afternoon from master. ... https://github.com/m-labs/artiq/issues/856#issuecomment-357367460
key2_ is now known as key2
<GitHub66> [artiq] hartytp commented on issue #856: @jbqubit hmm...interesting.... https://github.com/m-labs/artiq/issues/856#issuecomment-357368698
<GitHub197> [artiq] hartytp commented on issue #856: @jbqubit hmm...interesting.... https://github.com/m-labs/artiq/issues/856#issuecomment-357368698
<GitHub99> [smoltcp] dlrobertson commented on pull request #110 dfcdf43: Np, I'll revert it. Just wondered if that was enough to used the `checked` variant. https://github.com/m-labs/smoltcp/pull/110#discussion_r161338425
<rjo> key2: yes. there is state in the flash. if that doesn't match your code's expectations, you have a problem.
<rjo> key2: i think i have seen vivado/ise do something similar.
<key2> rjo: so I need to patch openocd in order to deal with those registers ?
<GitHub162> [artiq] jbqubit opened issue #890: naming of sayma classes don't follow artiq_flash convention https://github.com/m-labs/artiq/issues/890
<rjo> if you can't reset the flash or keep your fingers from that xilinx tool, probably.
<GitHub87> [smoltcp] dlrobertson commented on issue #110: Based `SystemTime` conversions off of `UNIX_EPOCH`. I also added `Instant::now`, removed the use of `checked` functions, and removed the `MILLIS_PER_SEC` constants. https://github.com/m-labs/smoltcp/pull/110#issuecomment-357377342
<GitHub1> [artiq] jbqubit commented on issue #856: For the logs just reported I built .bit for RTM and amc stand alone. And flashed using ```~/github/m-labs/sinara$ artiq_flash --srcbuild ./misoc_standalone_sayma_amc -t sayma```.... https://github.com/m-labs/artiq/issues/856#issuecomment-357377828
<GitHub87> [smoltcp] whitequark commented on pull request #110 8865776: One last nit: let's just embed this one too. Meanwhile let me fix the build failure. https://github.com/m-labs/smoltcp/pull/110#discussion_r161345465
<GitHub40> [smoltcp] dlrobertson commented on issue #110: Ugh, I accidentally dismissed a review. If you see a comment of yours missing, feel free to add it again... https://github.com/m-labs/smoltcp/pull/110#issuecomment-357378615
<travis-ci> [rust-managed] whitequark pushed 2 new commits to master: https://github.com/m-labs/rust-managed/compare/50187015d36e...a76c8d7c9f15
<travis-ci> rust-managed/master ecebbbf whitequark: Update for rustc 1.25 nightly.
<travis-ci> rust-managed/master a76c8d7 whitequark: Bump version.
<GitHub117> [smoltcp] whitequark commented on pull request #110 8865776: I've released managed 0.5.1 which should fix the build failure. https://github.com/m-labs/smoltcp/pull/110#discussion_r161345858
<travis-ci> m-labs/rust-managed#29 (master - a76c8d7 : whitequark): The build passed.
<GitHub167> [smoltcp] dlrobertson commented on pull request #110 8865776: Is that what is happening in #116 as well? https://github.com/m-labs/smoltcp/pull/110#discussion_r161346122
<GitHub157> [smoltcp] whitequark commented on pull request #110 8865776: I think so https://github.com/m-labs/smoltcp/pull/110#discussion_r161346205