<GitHub15>
[jruby] kares closed issue #5035: JRuby's native `SortedSet` lies about adding an object https://git.io/vAJ24
<headius>
good morning!
<enebo>
morning
Remo has joined #jruby
akp has joined #jruby
Remo has quit [Client Quit]
xardion has quit [Remote host closed the connection]
xardion has joined #jruby
<GitHub95>
[jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vAmiS
<GitHub95>
jruby/jruby-9.1 7cc201a Charles Oliver Nutter: Support Java 7+.
18VADAEEN is now known as adam12
snowp has quit []
snowp has joined #jruby
<GitHub156>
[jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vAmFk
<GitHub156>
jruby/jruby-9.1 02dbb67 Charles Oliver Nutter: Finish forcing method name in DynamicMethod constructors....
<headius>
enebo, kares: Ok, that should be the last major commit for method names
<headius>
it uses the presence of DynamicMethod.Version annotation to know whether to use the new constructor that takes name
<headius>
if it is not present, it uses the old path but uses a thread local string to pass the name up another way
<enebo>
sweetness
<headius>
jossl generates both invokers AND populators right now, so it's still always passing null (which becomes method name "null" right now), but it doesn't error
<headius>
there's still a compat issue in that if we regenerate those invokers they won't have a "name" super constructor on older JRuby
<headius>
so that jossl would not work on 9.1.15 and earlier
<headius>
in any case at the moment this will call old or new constructor safely so existing generated older constructors won't break
<enebo>
yeah this is really nice for future work
<headius>
have a look...I just went with an int instead of an enum or something
<headius>
I doubt it will rev much after this
<GitHub196>
jruby/jruby-9.1 7bb9781 Charles Oliver Nutter: Filter out new-style Java version numbers from ASM binding.
<GitHub196>
[jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vAmAR
<enebo>
yeah we probably maybe will once at best but a number seems very reasonable
<enebo>
an enum would just be a number more or less anyways
<GitHub13>
[jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vAmxZ
<GitHub13>
jruby/jruby-9.1 9022774 Charles Oliver Nutter: Java 7 does not like this type mismatch for some reason.
<headius>
yeah
<headius>
kares: weird errors with those tests you added...it didn't like List<Object> = Arrays.asList(1, 2, 3) because the LHS wasn't List<Integer>
<headius>
after all these years generics still confuse me sometimes
<headius>
I guess it's a contravariant issue
<headius>
a List<Object> may not be compatible with a List<Integer>
<headius>
but List with no type param is ok
<nirvdrum>
lopex: Were you able to reproduce the joni performance regression I mentioned last week?
<headius>
🤷♂️
<headius>
ok, lunch break, bbiab
<headius>
hopefully 9.1 should be mostly green this round
<lopex>
nirvdrum: will look at it this week
<nirvdrum>
lopex: No problem. I'll be curious if you can reproduce.
<lopex>
nirvdrum: I hope so
<lopex>
I mean I believe you there is, why is the question :P
<nirvdrum>
Heh. I like to be thorough.
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<enebo>
lopex: can you add those missing ranges for EUC-JP?
<lopex>
enebo: tomorrow
<lopex>
enebo: not sure it would be better to extract them from binaries
<lopex>
same for sjis
<enebo>
lopex: yeah I guess I have no idea. We may need to extract data again in the future so that probably is a factor?
<lopex>
yes
<GitHub114>
[jruby] nomadium opened pull request #5039: Add FrozenError class (ruby-2.5...add-frozen-error-class) https://git.io/vAmjx
<headius>
enebo, lopex: looks like only thing failing is those chr specs
<headius>
if we can decide how to address those we can proceed with 9.1.16 this week
<GitHub164>
jruby/master 2bc3c87 Charles Oliver Nutter: Merge branch 'jruby-9.1'
<headius>
enebo: kinda piecemeal cherry-picking and copying there but chr logic should match master and pass everything now
<enebo>
headius: yeah hopefully we see green
<headius>
ugh, open3
<enebo>
chr is basic enough where I expect quite a bit of coverage
<headius>
I will see if I can come up with a short term fix
<headius>
I'm not going to get the windows process logic ported for 9.1.16 at this point
<GitHub39>
[jruby] headius closed issue #4890: jruby uses absolute pathnames in batch files generated by rubygems https://git.io/vbRwJ
<headius>
enebo: marked that RubyGems windows batch file thing as invalid
<headius>
once they fix it in RubyGems we can upgrade, but it's not our bug
<enebo>
yeah
<GitHub48>
[jruby] headius closed issue #4896: Jruby + Rspec scoping issues on Classes with Prepended Modules https://git.io/vbrMI
<headius>
enebo: 4 left
<headius>
one waiting on mkristian to decide about relocating some packages in jruby-readline, one that kares self-assigned four days ago, the open3 issue, and the end_of_day thing
<headius>
I confirmed end_of_day thing still broken on 9.1 head, have not checked master
<headius>
I have to run for a bit
<enebo>
ok
<enebo>
we may want to examine if we dropped something not targetted too
drbobbeaty has quit [Read error: Connection reset by peer]
drbobbeaty has joined #jruby
<headius>
yeah
<headius>
I need to catch up my triage status
<headius>
will try to do that this evening
akp has quit []
akp has joined #jruby
akp has quit [Remote host closed the connection]
akp has joined #jruby
akp has quit [Ping timeout: 240 seconds]
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]