<GitHub>
[solvespace] Evil-Spirit commented on issue #187: @whitequark, I can't reproduce it for QCad. Probably, not the same version or somthing else. I have BircsCAD, NanoCAD, DWG TrueView, LibreCAD, QCad, Inkspace installed and perform testing with them... https://github.com/solvespace/solvespace/issues/187#issuecomment-277617753
<wpwrak>
interesting. patch hates missing EOL at EOF :)
<wpwrak>
weird .. git diff master shows me a difference in res/win32/versioninfo.rc.in
<wpwrak>
and i seems that you were right, about it being irrelevant: lag is still there :(
<wpwrak>
things that do get updated in a timely manner: constraints; highlighting of axes, planes, and other items; the "rendered" performance meter; menu highlighting
<wpwrak>
cuold it be that the line being dragged is not considered to be part of the "Graphics" to Paint/Invalidate just yet ?
<whitequark>
wpwrak: try replacing the implementation of ScheduleGenerateAll with just a call to GenerateAll()
<wpwrak>
YES ! that's it ! :)
<whitequark>
ok, I now know what the bug is...
<wpwrak>
that's on top of gonusoreha and wuyohuzuye. shall i try without ?
<whitequark>
should make no difference
<wpwrak>
correct :)
<wpwrak>
hmm. the dependencies for all the patches are getting messy :( trying to wrap my head around what's going on between #172 and #176 ...
<wpwrak>
mmh. today isn't meant to be the day i figure this out. still too groggy after the storm :(
<wpwrak>
thanks ! how do you feel about the two performance enhancements a5ffd9d and 9cf1a09 (from evil-spirit's repo)
<wpwrak>
?
<whitequark>
one of them has horrible code style
<whitequark>
the other, I'm still not fully convinced it's sound
<wpwrak>
heh :)
<GitHub>
[solvespace] whitequark commented on issue #148: I've figured out the problem. It has nothing to do with invalidation. Rather, it is because of ScheduleGenerateAll that never actually performs the generation if the queue is full of mouse move events (at least on Linux). https://github.com/solvespace/solvespace/issues/148#issuecomment-277697206
<wpwrak>
whitequark: would you be willing to accept the DISPLAY_TEXTWND patch, even if we still don't know what causes TW to fail to appear ? while this is issue is not pretty to have, it's trivial enough to work around, doesn't seem to cause any other trouble, and only affects people using DISPLAY_TEXTWND.
<whitequark>
wpwrak: I really don't like the idea of having functionality in-tree that's broken
<whitequark>
on top of that we still don't have a working CLA process
<wpwrak>
how about this ? use as you please as long as one version stays open source, under any license OSI approves of.
<whitequark>
mind you, personally, I don't believe in copyright, so anything goes, including not actually granting me a right to use it.
<whitequark>
unfortunately, our clients do
<whitequark>
... so yeah, I'll have to figure out a CLA that will satisfy lawyers at some corp, and the last time I tried to work it out with Jonathan I couldn't
<wpwrak>
no right to use it would be messy ;-)
<whitequark>
only if you allow yourself to be bound by formalities :p
<wpwrak>
hmm yes, if you want only non-exclusive rights, then the "as long as it stays free" condition i mentioned isn't needed
<wpwrak>
(discourse) a lot o legalaese that makes it hard to read. but i see no red flags.
<wpwrak>
'SIGN ELECTRONICALLY' -> 'Please type "I AGREE" ' ;-))
<wpwrak>
(code that's broken) well, at the end of the day it does what it's supposed to do. just has some difficulties getting started, but once the window is up, there no further issues. and i added big warnings in commit and code :) http://downloads.qi-hardware.com/people/werner/slvs/display-textwnd.patch
<wpwrak>
so far, explorability is still not great for resolving dependency issues i get when trying to fix the structure of sketches that have things piled on them. i.e., when something i tought could be a circle has to become an arc. or when i want to change a corner of lines meeting at 90 deg to a dog-bone.
<wpwrak>
so my plan is to improve this step by step. if it's simple enough for me to figure out, myself. else, by reporting an issue.