<dwrensha>
in 871, zarvox adds some fancy focus-management logic
<dwrensha>
including the ability to use left/right arrow keys to select a tab in the Share menu
rustyrazorblade has joined #sandstorm
<maurer>
dwrensha: Is there an easy way to test PRs as a user, or do I need to install sandstorm from git?
<maurer>
(the keyboard navigation presented there is interesting, I just tend to use a different system that can be more uniform across sites, and I'm curious whether it works with this)
<maurer>
(since currently, I can tell you the sharing menu does not allow you to switch tabs via hinting)
<maurer>
dwrensha: Unless I'm mistaken, I need to create/own a grain in order to allow me to see the share menu?
<dwrensha>
maurer: you'll get the share button if you sign in
<maurer>
k
<dwrensha>
I'm not 100% convinced that supporting left/right arrow buttons is worth the complexity in code, compared to just giving the elements a non-negative tabindex.
<maurer>
dwrensha: So, eft and right arrow buttons aren't working for me on that
<maurer>
(nor is hinting, but that's separate)
<maurer>
You sure the pr is loaded?
<dwrensha>
can you get to the "Get shareable link" tab at all?
<dwrensha>
yes, it's loaded
<maurer>
With mouse, yes
<maurer>
Hinting doesn't get there, and arrow keys don't get there
<dwrensha>
zarvox will be interested to hear this! ^
<maurer>
To confirm, I am just supposed to click "Share"
<maurer>
then hit the right arrow key
<maurer>
there aren't any other steps, right?
<dwrensha>
that's correct
<maurer>
Yeah, that's not doing anything
<maurer>
lemme reload in chromium, see if it works there
<dwrensha>
when you click the share button, the "Send an invite" tab should be in focus
<maurer>
dwrensha: that matches observed behavior
<dwrensha>
and you should be able to switch focus to the other tab by pressing "right"
<maurer>
that does not
<dwrensha>
and then "enter" should switch to that tab
<dwrensha>
do you see the purple outline on the focused element?
<maurer>
Yes
<maurer>
Works in chromium
<maurer>
so maybe my firefox is just weird
<dwrensha>
maurer: can you try it now? I got rid of the keyboard handler and I put the "get shareable link" tab in tabbing order
<maurer>
dwrensha: Using "tab" allows me to switch focused elements, but left and right arrow keys does not
<dwrensha>
yep
<maurer>
dwrensha: enter does not swap tabs
<dwrensha>
er
<dwrensha>
darn
<dwrensha>
that's true for my browser as well
<dwrensha>
I had hoped that pressing "enter" would generate a click event for the focused element
rustyrazorblade has quit [Quit: rustyrazorblade]
bb010g has quit [Quit: Connection closed for inactivity]
kentonv has joined #sandstorm
jadewang has joined #sandstorm
mort___ has left #sandstorm [#sandstorm]
jadeqwang has joined #sandstorm
<jadeqwang>
hey y'all
<jadeqwang>
hey @mquandelle
M-hrjet has quit [Remote host closed the connection]
<mquandalle>
I come to tell you that you put the wrong link on this post
<jadeqwang>
wat
<mquandalle>
`vagrant-spk` instead of `meteor-spk`
<mquandalle>
I think
<jadeqwang>
if you scroll down on that page, there's the steps for meteor
<mquandalle>
hum, yes I was just confused by the URL
<jadeqwang>
I don't think I can safely assume the average user on forums.meteor.com is on a Linux machine
<jadeqwang>
hence vagrant-spk
<mquandalle>
But that document is still a bit light on meteor packaging, doesn't mention `kenton:accounts-sandstorm` and that we can keep using `insecure` on sandstorm
<jadeqwang>
hmm, i should include both links then
<mquandalle>
These infos were very valuable when I sandstorm-packaged my first Meteor app
<mquandalle>
(Metrello ;-))
<jadeqwang>
hey, maybe you should comment in reply :)
<mquandalle>
(Yay! Facebook launched React Native for android, I need to play with that!)
<jadeqwang>
:)
<mquandalle>
(as I don't have a mac, I couldn't play with React native for iOS, now I can. Let's try to build a native Wekan client!)
<jadeqwang>
!!
soulshake has joined #sandstorm
M-hrjet has joined #sandstorm
NOTevil has joined #sandstorm
losvedir has quit [Quit: losvedir]
losvedir has joined #sandstorm
losvedir has quit [Client Quit]
mnutt_ has quit [Quit: mnutt_]
mort___ has joined #sandstorm
mort___ has left #sandstorm [#sandstorm]
natea has joined #sandstorm
<zarvox>
dwrensha: reading the backlog - that's interesting. It seems to work as described on the tin for me in both firefox and chromium. What version of Firefox is the issue in?
<dwrensha>
which issue?
<zarvox>
the one where you can't tab through the account dropdown
<dwrensha>
40.0.3 on OSX
<zarvox>
also the one where you can't switch which tab is focused with arrows + Enter
<dwrensha>
you'll have to ask maurer about that one
<maurer>
zarvox: 39.0.3 linux
<maurer>
zarvox: I'm fully ready to belive that my firefox has something wrong with it though
<maurer>
*believe
<zarvox>
I'm running 40.0.3 on Linux, FWIW
<maurer>
(given that it's pentadactyl'd, which is a pretty invasive mod)
<zarvox>
yeah, the other items in the account dropdown are all valid <a> tags, so I'm surprised they don't show up as...interactive elements or whatever pentadactyl looks for
<maurer>
zarvox: the other items were hintable on the share link, just not the tab
<zarvox>
oh, so it's just that the tab header wasn't hintable?
<maurer>
Yeah
<dwrensha>
and the arrow keys didn't work, right?
<maurer>
Correct
<maurer>
If it was just tab header non-hintable I'd just say this is something pentadactyl needs to figure out
<zarvox>
hmmm, pentadactyl must be blocking those keypresses then :/
<maurer>
but the arrow key thing didn't work either
<maurer>
zarvox: oh, that's totally believable
<maurer>
dwrensha: repaste that sample grain?
<maurer>
I'll test with passthrough mode on, didn't think of that
<dwrensha>
I got rid of the keyboard handling and tabindex=-1 stuff on the current branch it's on
<maurer>
Oh, OK
<maurer>
zarvox: So, your branch does make the tabs a bit better. They don't get numbered (which I'm chalking up as 100% pentadactyl) but they do get hilighted
<maurer>
zarvox: which means on your branch I can activate the tabs without a mouse
<zarvox>
okay, great!
<maurer>
(well, your branch with dwrensha's changes, it'll probably work when he reverts to clean too)
<zarvox>
does that mean that you can successfully use all the UI elements now?
<maurer>
zarvox: Also, thanks for whatever you did when you changed the main ui of sandstorm - I can open grains with my keyboard from that
<maurer>
zarvox: On your branch, yeah
<zarvox>
:D
<dwrensha>
ok, I switched the server back to the zarbox/accessibility branch
<zarvox>
I <3 keyboard users
<maurer>
k, reloading
<maurer>
With passthrough on, I can left and right arrow
<maurer>
can't believe I forgot about passthrough, sorry
<maurer>
pentadactyl was just eating it
<zarvox>
no worries! I'm glad it's working for you now. :)
<dwrensha>
maurer: do you think the left/right arrow thing is discoverable?
<dwrensha>
like, what if I hadn't told you about it?
<maurer>
dwrensha: I wouldn't have discovered it, but I am also not a typical user
<maurer>
My reflex if anything would have been to try hitting tab
<zarvox>
Hmmm, our unsighted friend Nolan suggested using arrow keys and letting tab jump between larger landmarks
<maurer>
If you're trying to make things keyboard navigable without crazy browser mods, you could consider having a cheat sheet like in gmail
<maurer>
zarvox: He's probably a better fit for this than me. I'm just avoiding rsi
<maurer>
zarvox: But if you're going to have more than just left and right in the long term, consider a cheat-sheet overlay like gmail's, it's super helpful for learning
<maurer>
(press ? in gmail to see it)
<zarvox>
maurer: that's a good idea, I'll keep it in mind if we have more keyboard shortcuts
<maurer>
(but yeah, don't take my word over a blind guy on discoverability of navigation, I've got my own keyboard navmod over all websites, so I don't know what the expected accessibility norms are, nor do I have a severe disability to deal with)
<zarvox>
(one limitation on keyboard shortcuts is we don't want to/can't block certain events from reaching the grain frames, so that limits what keyboard shortcuts we can add)
<maurer>
zarvox: So, if you want to add more keyboard commands, there are two potentially useful ideas there
<maurer>
1.) Escape sequences
<maurer>
have one keystroke that is "reserved" by sandstorm, that causes the next key to go to sandstorm instead of the app
<maurer>
2.) Have apps declare what keys they want to eat, so that usually keys can go to sandstorm
<maurer>
#2 doesn't work as well with the purity of the grain-as-capability model, so maybe this whole thing is a no-go
<zarvox>
dwrensha: so, is it okay to merge that branch with the accessibility changes?
<zarvox>
or are there outstanding issues still?
<jparyani>
zarvox: on keyboard shortcuts, typically a user will have the iframe focused and it will swallow all keyboard events. There’s actually no good way to bubble them out of the iframe, even if we wanted to
<zarvox>
ahhh, good point
natea has quit [Quit: natea]
<dwrensha>
zarvox: hm. messing with the tabindex of the <a> elements in the accounts dropdown doesn't seem to help
<dwrensha>
in Firefox
<dwrensha>
zarvox: anyway, I have no further comments about the pull request. I think it's fine to merge.
gopar has joined #sandstorm
ocdtrekkie has quit [Remote host closed the connection]
aldeka has quit [Remote host closed the connection]
<zarvox>
dwrensha: merged, thanks :)
gopar has quit [Remote host closed the connection]
mnutt_ has joined #sandstorm
aldeka has joined #sandstorm
ocdtrekkie has joined #sandstorm
mnutt_ has quit [Client Quit]
gopar has joined #sandstorm
mnutt_ has joined #sandstorm
mnutt_ has quit [Client Quit]
NOTevil has quit [Quit: ...]
mnutt_ has joined #sandstorm
isd has joined #sandstorm
gopar has quit [Remote host closed the connection]
<paulproteus>
In which AdBlock Plus + EasyList block the Sandstorm sharing UI.
mnutt_ has quit [Quit: mnutt_]
isd has quit [Remote host closed the connection]
<zarvox>
Hmmm, should we set the Reply-To: header to the sharing user's email address when we do sharing-via-email?
<zarvox>
I would like it if those messages didn't come From: "Sandstorm server" but perhaps From: "$sharerDisplayName (via Sandstorm)"
<paulproteus>
+1 I think
<zarvox>
and then I'd *like* to set the Reply-To header to be the sharer's email address if we have one (so when users inevitably reply to the sharing link email it doesn't go into the void), but we're not guaranteed to have one for every user
<paulproteus>
I think doing that best-effort is way better than not bothering.
<zarvox>
I guess we have a purported email address for every user, but not a verified one.
<zarvox>
Hmmm, maybe it's a problem if the Reply-To might be forgeable? I could make a sharing link look like it came from asheesh@sandstorm.io when I don't own that address. :/
<zarvox>
Maybe we should track whether the email address in Meteor.user().profile has been confirmed, and only use it if it has.
<zarvox>
OTOH, display name will feature far more prominantly.
<zarvox>
Maybe we can require a validated email address to share via email.
<ocdtrekkie>
paulproteus: I sent you a PR.
<ocdtrekkie>
I should probably do some more comprehensive examinations of more of docs, but I noticed these things last night and they irked me.
simonv3 has joined #sandstorm
<paulproteus>
ocdtrekkie: I just noticed the PR. Reviewing now.
<paulproteus>
ocdtrekkie: The only thing I think I'd change is to add a more clear note at the top about how this won't work for you unless you are using Linux.
losvedir has joined #sandstorm
<paulproteus>
Maybe I should add that sentence to the first paragraph or something?
<paulproteus>
Or add a note about Linux-only in "Note: If you're new to Sandstorm packaging, please read the ..."
losvedir has quit [Client Quit]
<paulproteus>
I'll blend that in a follow-up commit.