<mpapis>
ok let me explain now what the problem is
fromonesrc has quit [Ping timeout: 256 seconds]
<mpapis>
when you run "bundle install" then the set of gems is restricted to only the gems in "Gemfile.lock", so if you want to hook into gem installation you need to add the gem to Gemfile and make sure it's installed in version from Gemfile.lock before starting "bundle install"
fromonesrc has joined #rubygems
<mpapis>
this is not good
<mpapis>
drbrain, the hooks need to be callable even if not in Gemfile, otherwise it makes no sense
<drbrain>
hold on, let me update my bundler repo
ckrailo has quit [Quit: Computer has gone to sleep.]
<drbrain>
mpapis: where does bundler load the rubygems plugins?
<drbrain>
I can't find it using GemRunner or calling Gem.load_plugins
<mpapis>
need to check
<drbrain>
so it looks like it should be unable to use any rubygems plugins
<mpapis>
looks like I'm back in point where LOAD_PATH has to be modified
<drbrain>
I think this is a bundler issue, not a rubygems issue
<drbrain>
bundler needs to choose which set of plugins it wants to use, the plugins from the "outside" gem environment or the plugins from the bundled gem environment
<drbrain>
… or both
<drbrain>
rubygems can provide the API to support all of these three cases
<mpapis>
damn this never gets easier
<samkottler>
drbrain: has there ever been consideration for adding a way to specify which ruby version(s) a gem supports?
<drbrain>
yeah :(
<drbrain>
samkottler: there's been required_ruby_version in the spec for some years now
<samkottler>
drbrain: WAT
<samkottler>
how did I never know about that
<drbrain>
samkottler: :D
<samkottler>
drbrain: thanks :)
<mpapis>
drbrain, sorry for wasting your time, I had the Dir[] line in my memory and it never occurred to me to closely reread the code
<drbrain>
samkottler: since it uses a requirement you can't say "1.8.7, 1.9.2, 1.9.3, 2.0.0 but not 1.9.1 or 1.9.0"
<drbrain>
samkottler: since it suffers from the "no overlap" rule :/
<drbrain>
mpapis: don't worry, no problem!
<samkottler>
drbrain: yeah I might try fixing that
<samkottler>
drbrain: it'd be nice for it to be range based
<drbrain>
mpapis: rubygems is so big it's good to have discussions like this since I forget parts of it (like load_env_plugins) :D
<samkottler>
i.e. ['1.8.7', '1.9.2 < 1.9.3']
<samkottler>
meh, that's kinda ugly
* samkottler
needs to thing about that more
<samkottler>
think, even
<drbrain>
samkottler: Gem::Requirement is a composite object
<drbrain>
right now all the items in the composite object must match
<mpapis>
drbrain, this means I need to rework the executables hook to use find_latest_files and add the gem to LOAD_PATH ... at least to make the plugins work in later stages in bundler - but that would not load the plugins for rubygems itself if I understood you correctly?
<samkottler>
drbrain: gotcha
* samkottler
grumbles
<drbrain>
samkottler: yeah, for example: Gem::Requirement.new "~> 1.8.7" is the same as Gem::Requirement.new ">= 1.8.7", "< 1.8.8"
<samkottler>
drbrain: right
<drbrain>
(oh, and required_ruby_version matches Gem.ruby_version which includes the patch level)
<samkottler>
which is actually fine for almost every case
<drbrain>
mpapis: by default find_latest_files will look in loaded gems *and* $LOAD_PATH
<drbrain>
mpapis: rubygems_plugin.rb files are special
<samkottler>
drbrain: I gotta run, but I'll ttyl
<samkottler>
thanks!
<drbrain>
samkottler: later
<drbrain>
at least, they're loaded special
<drbrain>
mpapis: for your executable_plugins pull request there may be a simpler way
<mpapis>
consider this in context of hookuing into bundler - I would add the gem that hooks into LOAD_PATH to make the rubygems installation plugin work
<drbrain>
mpapis: sounds right
<drbrain>
mpapis: but, I need to go to the store before my bus
<drbrain>
so we'll need to finish this discussion later :(
<mpapis>
no problem, I'm happy where it goes
<drbrain>
alright, later!
<mpapis>
later
jaimef has quit [Excess Flood]
jaimef has joined #rubygems
pipework has joined #rubygems
jaimef has quit [Quit: Emacs must have died]
jaimef has joined #rubygems
dvu has joined #rubygems
yerhot has joined #rubygems
yerhot has quit [Remote host closed the connection]
yerhot has joined #rubygems
pipework is now known as combatwombat
combatwombat is now known as Guest14949
Guest14949 is now known as pipework
dvu has quit [Remote host closed the connection]
cowboyd has joined #rubygems
yerhot has quit [Remote host closed the connection]
yerhot has joined #rubygems
dvu has joined #rubygems
dvu has quit [Ping timeout: 256 seconds]
fromonesrc has quit [Ping timeout: 268 seconds]
fromonesrc has joined #rubygems
fromonesrc has quit [Client Quit]
lsegal has joined #rubygems
jonahR_ has joined #rubygems
jonahR_ is now known as jonahR
jonahR has quit [Ping timeout: 264 seconds]
eugenejen has quit [Quit: eugenejen]
DanKnox is now known as DanKnox_away
huoxito has quit [Quit: Leaving]
pipework has quit [Remote host closed the connection]
dvu has joined #rubygems
dvu has quit [Ping timeout: 248 seconds]
yerhot has quit [Remote host closed the connection]
noyb has joined #rubygems
yerhot has joined #rubygems
yerhot has quit [Ping timeout: 264 seconds]
cowboyd has quit [Remote host closed the connection]
cowboyd has joined #rubygems
dvu has joined #rubygems
cowboyd has quit [Remote host closed the connection]
dvu has quit [Ping timeout: 260 seconds]
jstr has quit [Quit: Computer has gone to sleep.]
eugenejen has joined #rubygems
martinisoft has quit [Quit: martinisoft]
DanKnox_away is now known as DanKnox
Tjark has joined #rubygems
AlHafoudh has joined #rubygems
noyb has quit [Ping timeout: 276 seconds]
lsegal has quit [Quit: Quit: Quit: Quit: Stack Overflow.]
Tjark has quit [Quit: ZZZzzz…]
jstr has joined #rubygems
DanKnox is now known as DanKnox_away
Tjark has joined #rubygems
AlHafoudh has quit [Ping timeout: 248 seconds]
jonahR has joined #rubygems
jonahR has quit [Quit: jonahR]
Tjark has quit [Quit: ZZZzzz…]
paulca has joined #rubygems
tcopeland has quit [Ping timeout: 240 seconds]
Tjark has joined #rubygems
alex_io has joined #rubygems
alex_io has left #rubygems [#rubygems]
tbuehlmann has joined #rubygems
jstr has quit [Quit: Computer has gone to sleep.]
Tjark has quit [Quit: ZZZzzz…]
Tjark has joined #rubygems
yerhot has joined #rubygems
workmad3 has joined #rubygems
alex_io has joined #rubygems
yerhot has quit [Remote host closed the connection]
yerhot has joined #rubygems
tbuehlmann has quit [Remote host closed the connection]
yerhot has quit [Remote host closed the connection]
paulca has quit [Quit: paulca]
alex_io has quit [Quit: My iMac has gone to sleep. ZZZzzz…]
pipework has joined #rubygems
pipework has quit [Remote host closed the connection]
stevenharman has joined #rubygems
yerhot has joined #rubygems
fromonesrc_ has joined #rubygems
fromonesrc_ has quit [Ping timeout: 256 seconds]
yerhot has quit [Remote host closed the connection]
<havenwood>
zachrab: There is always documentation to review!
cowboyd has quit [Remote host closed the connection]
bondar has joined #rubygems
bondar has quit [Excess Flood]
bondar has joined #rubygems
bondar has quit [Excess Flood]
bondar has joined #rubygems
bondar has quit [Excess Flood]
bondar has joined #rubygems
bondar has quit [Excess Flood]
bondar has joined #rubygems
<zachrab>
havenwood: what do you theres always documentation to review?
bondar has joined #rubygems
bondar has quit [Excess Flood]
<havenwood>
zachrab: I said that poorly, what i meant was that in addition to open issue tickets another nice thing to do is review the documentation and make sure it matches the code. Keep it up to date and error free.
bondar has joined #rubygems
bondar has quit [Excess Flood]
paulca has quit [Quit: paulca]
bondar has joined #rubygems
bondar has quit [Excess Flood]
mikewintermute has joined #rubygems
dvu has quit [Ping timeout: 246 seconds]
bondar has joined #rubygems
bondar has quit [Excess Flood]
fromonesrc has quit [Ping timeout: 276 seconds]
marpaia has quit [Quit: WeeChat 0.4.1]
fromonesrc has joined #rubygems
Tjark has joined #rubygems
havenwood has quit [Remote host closed the connection]
jfoy has quit [Quit: jfoy]
marpaia has joined #rubygems
fromonesrc has quit [Quit: fromonesrc]
mikewintermute has quit [Quit: mikewintermute]
jonahR has quit [Quit: jonahR]
Tjark has quit [Quit: ZZZzzz…]
marpaia has quit [Quit: WeeChat 0.4.1]
Tjark has joined #rubygems
whit537 has quit [Quit: whit537]
mikewintermute has joined #rubygems
mikewintermute has quit [Quit: mikewintermute]
mikewintermute has joined #rubygems
<drbrain>
there's lots of stuff in RubyGems that isn't documented
<drbrain>
rdoc -C lib shows RubyGems at only 68% documented