tenderlove has quit [Remote host closed the connection]
whit537_ has joined #rubygems
whit537 has quit [Read error: Operation timed out]
whit537_ is now known as whit537
workmad3 has quit [Ping timeout: 264 seconds]
Tjark has quit [Quit: ZZZzzz…]
stevenharman has joined #rubygems
stevenharman has quit [Client Quit]
stevenharman has joined #rubygems
stevenharman has quit [Read error: Connection reset by peer]
stevenharman has joined #rubygems
<evan>
we've just done some DNS changes so if anyone sees/hears/intuits anything weird, please let me know!
whit537_ has joined #rubygems
whit537 has quit [Ping timeout: 240 seconds]
whit537_ is now known as whit537
samkottler has quit [Read error: Operation timed out]
danmcclain has quit [Ping timeout: 245 seconds]
shtirlic has quit [Ping timeout: 264 seconds]
erichmenge has quit [Ping timeout: 240 seconds]
sindork has quit [Ping timeout: 264 seconds]
Gnubie has quit [Ping timeout: 264 seconds]
danmcclain has joined #rubygems
erichmenge has joined #rubygems
sindork has joined #rubygems
Gnubie has joined #rubygems
samkottler has joined #rubygems
shtirlic has joined #rubygems
Tjark has joined #rubygems
hakunin has quit [Remote host closed the connection]
hakunin has joined #rubygems
bbrowning has quit [Read error: Connection reset by peer]
bbrowning has joined #rubygems
Tjark has quit [Quit: ZZZzzz…]
whit537 has quit [Ping timeout: 248 seconds]
DanKnox is now known as DanKnox_away
jonahR has joined #rubygems
whit537 has joined #rubygems
DanKnox_away is now known as DanKnox
jonahR has quit [Quit: jonahR]
jonahR has joined #rubygems
workmad3 has joined #rubygems
tcopeland has quit [Ping timeout: 268 seconds]
newUser1234 has joined #rubygems
jfoy has quit [Quit: jfoy]
Tjark has joined #rubygems
tenderlove has joined #rubygems
marpaia has quit [Quit: WeeChat 0.4.1]
stevenharman has quit [Quit: Leaving...]
stevenharman has joined #rubygems
jonahR has joined #rubygems
cowboyd has quit [Remote host closed the connection]
tbuehlmann has quit [Remote host closed the connection]
jfoy has joined #rubygems
yerhot has quit [Remote host closed the connection]
jfoy has quit [Quit: jfoy]
jonahR has quit [Quit: jonahR]
Tjark has quit [Quit: ZZZzzz…]
whit537 has quit [Read error: Connection reset by peer]
jfoy has joined #rubygems
fromonesrc has quit [Ping timeout: 240 seconds]
tcopeland has joined #rubygems
workmad3 has quit [Ping timeout: 260 seconds]
stevenharman has quit [Ping timeout: 248 seconds]
lsegal` has joined #rubygems
RickHull1 has joined #rubygems
fromonesrc has joined #rubygems
kallistec_rulez has joined #rubygems
jfoy has quit [Quit: jfoy]
x1337807x has quit [Ping timeout: 260 seconds]
lsegal has quit [Ping timeout: 240 seconds]
rickhull has quit [Ping timeout: 240 seconds]
kallistec has quit [Ping timeout: 240 seconds]
foohey has quit [Ping timeout: 240 seconds]
kallistec_rulez is now known as kallistec
jaimef has quit [Ping timeout: 240 seconds]
foohey has joined #rubygems
foohey has quit [Changing host]
foohey has joined #rubygems
jaimef has joined #rubygems
whit537 has joined #rubygems
fromonesrc has quit [Ping timeout: 240 seconds]
dfgg has quit [Ping timeout: 240 seconds]
newUser1234 has quit [Remote host closed the connection]
<lmarburger>
evan: can you double check this PR? it's a bugfix for bundler-api. i'd love to get it deployed soon so i'm willing to do any necessary legwork. if it'll take time, i can work around it on bundler-api for now. https://github.com/rubygems/rubygems.org/pull/580
dfgg has joined #rubygems
fromonesrc_ has joined #rubygems
yerhot has joined #rubygems
havenwood has joined #rubygems
aeden has quit [Quit: aeden]
<havenwood>
@drbrain I'm worried my tests are insufficient for `gem uninstall --all`. I'll study up on RubyGem tests.
<drbrain>
havenwood: it's ok!
<drbrain>
havenwood: I'm going to remove the remove_executables check
<drbrain>
I'm unsure how the executables would work if they can't call anything
<havenwood>
nice
<havenwood>
good point!
<drbrain>
… and I might need to add something to remove executables in /usr/local/bin
<havenwood>
had a pull request to fix it, but just closed it since you've already addressed
fromonesrc_ has quit [Ping timeout: 276 seconds]
<drbrain>
I followed up with four commits:
<drbrain>
use options[:install_dir] so you can uninstall from other directories (I forgot about this when I mentioned Gem.dir)
<drbrain>
I extracted --all and a list of gems from the #execute method to make things easier to read
<drbrain>
I disallowed combining --all with gem names (since that can lead to user confusion)
<drbrain>
and I removed asking about executables
<drbrain>
havenwood: that reminded me of two more things you might wish to tackle:
<drbrain>
a) `gem install` puts executables in Gem.bindir so those will need to be cleaned up too. It may be easier to use Gem::Uninstaller than FileUtils to fix that bug
<drbrain>
b) default gems should not be uninstalled (they exist as specs in specifications/default)
<drbrain>
using Gem::Uninstaller may fix that too
<drbrain>
and, the tests in the commands don't need to be very fancy
<drbrain>
the commands should just be glue for other parts of the API without much special stuff
<drbrain>
(adding features to RubyGems is super hard)
<drbrain>
(I usually forget half the details the first time)
<havenwood>
cool! i'll research Gem::Uninstaller route, that makes total sense
tenderlove has quit [Remote host closed the connection]
ckrailo has quit [Quit: Computer has gone to sleep.]