<rjo>
sb0: can i expose socket.settimeout in Client? AsyncClient and constantly having to run the loop seems a bit of overkill just to get timeouts (currently in the hardware_testbench).
<sb0>
rjo, you want RPC calls that time out, right?
<rjo>
specifically terminate() in the controller shutdown code path of the unittest
<rjo>
well it's not "constantly having to run it" but i would need to use AsyncClient and pull in asyncio just for that.
<sb0>
ok, adding timeout to Client sounds fine
<sb0>
just beware of bugs... does BestEffortClient use any of the Client code? i don't remember
<rjo>
constructor argument or method?
<rjo>
they are separate
<sb0>
constructor argument, unless it gets crowded there
<rjo>
ack
<rjo>
it would probably be nasty if some experiment code does socket.setdefaulttimeout(0).
<GitHub108>
[artiq] jordens force-pushed subprocess-termination from 34403b4 to f7df393: https://git.io/vgLqg
<GitHub108>
artiq/subprocess-termination 5500611 Robert Jordens: subprocesses: unify termination logic
<GitHub108>
artiq/subprocess-termination c105949 Robert Jordens: pc_rpc.Client: support socket timeouts...
<GitHub108>
artiq/subprocess-termination 7636952 Robert Jordens: ctlmgr: fix import
<GitHub129>
[artiq] jordens pushed 1 new commit to subprocess-termination: https://git.io/vgLY7
<GitHub129>
artiq/subprocess-termination c28b938 Robert Jordens: Client: add note about timeout sideeffects