ChanServ changed the topic of #linux-rockchip to: Rockchip development discussion | Wiki at http://linux-rockchip.info | Logs at http://irclog.whitequark.org/linux-rockchip | ML at http://groups.google.com/group/linux-rockchip
premoboss has quit [Ping timeout: 240 seconds]
premoboss has joined #linux-rockchip
Ueno_Otoko has joined #linux-rockchip
premoboss has quit [Remote host closed the connection]
Ueno_Otoko has quit [Ping timeout: 240 seconds]
Ueno_Otoko has joined #linux-rockchip
sunilmohan has quit [Ping timeout: 276 seconds]
cnxsoft has joined #linux-rockchip
naobsd has joined #linux-rockchip
naobsd has quit [Remote host closed the connection]
naobsd has joined #linux-rockchip
Ueno_Otoko has quit [Remote host closed the connection]
mq002 has joined #linux-rockchip
mac_l1 has joined #linux-rockchip
Ueno_Otoko has joined #linux-rockchip
nighty^ has joined #linux-rockchip
cnxsoft1 has joined #linux-rockchip
cnxsoft has quit [Ping timeout: 265 seconds]
cnxsoft1 is now known as cnxsoft
pietrushnic has quit [Ping timeout: 260 seconds]
pietrushnic has joined #linux-rockchip
mac_l1 has quit [Ping timeout: 252 seconds]
wadim_ has joined #linux-rockchip
matthias_bgg has joined #linux-rockchip
Astralix has joined #linux-rockchip
maz_ has quit [Remote host closed the connection]
premoboss has joined #linux-rockchip
pietrushnic has quit [Ping timeout: 272 seconds]
pietrushnic`away has joined #linux-rockchip
pietrushnic`away is now known as pietrushnic
maz_ has joined #linux-rockchip
Ueno_Otoko has quit [Ping timeout: 260 seconds]
Ueno_Otoko has joined #linux-rockchip
Ueno_Otoko has quit [Ping timeout: 245 seconds]
mq002 has quit [Ping timeout: 245 seconds]
pietrushnic has quit [Ping timeout: 250 seconds]
mq002 has joined #linux-rockchip
mq002 has quit [Client Quit]
mq002 has joined #linux-rockchip
pietrushnic has joined #linux-rockchip
premoboss has quit [Ping timeout: 245 seconds]
premoboss has joined #linux-rockchip
Ueno_Otoko has joined #linux-rockchip
Ueno_Otoko has quit [Ping timeout: 245 seconds]
cnxsoft has quit [Quit: cnxsoft]
Ueno_Otoko has joined #linux-rockchip
afaerber has quit [Quit: Ex-Chat]
Ueno_Otoko has quit [Ping timeout: 240 seconds]
mq002 has quit [Quit: Ex-Chat]
JohnDoe_71Rus has joined #linux-rockchip
matthias_bgg has quit [Remote host closed the connection]
mrjay has joined #linux-rockchip
<mrjay> mmind00: Hi! i found a BUG i sar adc driver for rk3066 variant ... i think
<mrjay> mmind00: i mean for tsadc variant in rk3066
<mrjay> mmind00: there is a diffrence in reg TSADC_CTRL bit 4. In rk3066 tsadc it is start_convert bit and in saradc it is reserved
<mrjay> mmind00: rk3066 has internal temp sensor which needs conversion to get proper temp i think
wadim_ has quit [Quit: Leaving.]
<mrjay> mmind00: also in adc_input_src_sel your driver selecting channel as (chan->channel & SARADC_CTRL_CHN_MASK)
<rperier> mmind00,sjoerd: my flight for ELC is booked ;D
matthias_bgg has joined #linux-rockchip
enkoder has joined #linux-rockchip
<mrjay> mmind00: this is wrong because channels should be selected as folows for SARADC and TSADC:
<mrjay> mmind00: channel 0 :(SARADC_AIN[0]) value should be 7 (BITS 111)
<mrjay> mmind00: channel 1 :(SARADC_AIN[1]) value should be 6 (BITS 110)
<mrjay> channel 2 :(SARADC_AIN[2]) value should be 5 (BITS 101)
<mrjay> channel 3 :(SARADC_AIN[3]) value should be 4 (BITS 100)
premoboss has quit [Remote host closed the connection]
dlezcano has quit [Ping timeout: 240 seconds]
dlezcano has joined #linux-rockchip
<mrjay> mmind00: for channel selection fix should be simple: ((7 - chan->channel ) & SARADC_CTRL_CHN_MASK)
<mrjay> mmind00: i'm not sure what start_conversion fix should look like ... maybe additional filed in rockchip_saradc_data structs for each variant with start conversion bit, used later in line 77 ?)
afaerber has joined #linux-rockchip
mrjay has quit [Quit: Page closed]
<mmind00> and now he is gone
mrjay has joined #linux-rockchip
<mrjay> mmind00: me?
<mmind00> mrjay: yep :-)
<mmind00> mrjay: I think when doing the core saradc driver, I based on the vendor-driver ... not sure how far the manual can be trusted
<mrjay> mmind00: hmm ... in current state saradc driver for tsadc in rk3066 does not get any readings just stall ... i'll recompile and test
<mmind00> mrjay: I guess that one additional bit might be interesting, although I did get sane values at the time
<mmind00> mrjay: at least concerning the channels, I'm pretty sure they should be somewhat correct (at least stuff like the saradc keys seemed to always come form the correct channel)
<mrjay> mmind00: weird ... now it is not working for tsadc variant ... saradc variant works ok.
<mrjay> i do some testing ... enable all 4 channels and see what hapens :)
<mrjay> mmind00: you think that datasheet might be wrong than?
<mmind00> mrjay: it might be ... as you can see amount of channels in the register description doesn't match channels in he description and I guess the whole chapter just gets copy-pasted to every new manual
<mmind00> mrjay: but who nows ... TRM might even be correct
<mrjay> mmind00: ok testing all variants than
Astralix has quit [Remote host closed the connection]
gb_master has joined #linux-rockchip
<mrjay> mmind00: i have a question for this line Should there be "COMPOSITE_NOMUX(SCLK_TSADC, "sclk_tsadc", "xin24m, ..." ?
premoboss has joined #linux-rockchip
afaerber has quit [Quit: Ex-Chat]
matthias_bgg has quit [Quit: Leaving]
premoboss has quit [Ping timeout: 240 seconds]
gb_master has left #linux-rockchip ["Leaving"]
gb_master has joined #linux-rockchip
premoboss has joined #linux-rockchip
xcasex has quit [Read error: Connection reset by peer]
xcasex has joined #linux-rockchip
GriefNorth has joined #linux-rockchip
ckeepax has quit [Ping timeout: 264 seconds]
c0d3z3r0 has joined #linux-rockchip
pietrush` has joined #linux-rockchip
pietrushnic has quit [Ping timeout: 264 seconds]
c0d3z3r0 has quit [Ping timeout: 276 seconds]
<mrjay> mmind00: your driver is ok :) lack of SCLK_TSADC in clk driver was the problem ... got it working now both saradc and tsadc on rk3066
<mrjay> mmind00: sorry for raising alarm
<mrjay> mmind00: thanks anyway
<mrjay> now i only need to figure out how to setup thermal protection with tsadc temp values
JohnDoe_71Rus has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/]
gb_master has left #linux-rockchip ["Leaving"]
c0d3z3r0 has joined #linux-rockchip
GriefNorth has quit [Ping timeout: 264 seconds]
sunilmohan has joined #linux-rockchip
mrjay has quit [Quit: Page closed]
<mmind00> mrjay: \o/
sunilmohan_ has joined #linux-rockchip
sunilmohan has quit [Read error: Connection reset by peer]
ckeepax has joined #linux-rockchip
enkoder has quit [Ping timeout: 240 seconds]
sunilmohan_ has quit [Ping timeout: 272 seconds]
enkoder has joined #linux-rockchip
mrjay has joined #linux-rockchip
<mrjay> does anyone can send patch to rockchip mailing list?
<sjoerd> yes
<mrjay> cool
<mrjay> thanks
c0d3z3r0 has quit [Ping timeout: 250 seconds]
enkoder has quit [Ping timeout: 255 seconds]
afaerber has joined #linux-rockchip
ckeepax has quit [Ping timeout: 250 seconds]
naobsd has quit [Remote host closed the connection]
<mrjay> is there a way to convert iio adc input value to temperature in device tree and then setup overheating protection for cpu for example by changing cpu clock rate?
<mmind00> mrjay: there was an iio-thermal driver for that
<mrjay> mmind00: was?
<mmind00> but the relevant developer seems to have lost interest
<mrjay> mmind00: too bad ... so no way then?
<mmind00> mrjay: yes-way ... simply resurrect the patch and try to find out what is needed to get it accepted ;-)
<mrjay> mmind00: anyone can do that? or is it restricted to author of the patch?
<mmind00> mrjay: of course anyone can do that ... you just keep the original author, adapt the patch as needed and add your own signed off by ;-)
<mmind00> mrjay: people pickung up discarded patches of others is pretty common
<mmind00> mrjay: patch in question should be: https://lkml.org/lkml/2014/2/5/810
<mmind00> mrjay: and here as patchwork link to get a working patch-mbox: https://patchwork.ozlabs.org/patch/317315/
<mrjay> mmind00: well ... i'll start with smaller patches :) for example adding tsadc for rk3066 :)
<mmind00> hehe
<mrjay> mmind00: i have one question should i divide it to two patches 1. adding SCLK_TSADC clock id 2. Introduce tsadc to rk3066.dtsi?
<mrjay> mrjay: or just one?
<mmind00> mrjay: separate patches
<mmind00> mrjay: you can see in the log a lot of those as example
<mrjay> mmind00: ok thanks
<mmind00> mrjay: i.e. (1) clock-id to dt-binding header (2) set clock id in clk-rk3188.c (3) add dts stuff
<mrjay> mmind00: so three patches then ... ok
<mrjay> reading about patchwork now
<mmind00> mrjay: you'll probably need scripts/checkpatch.pl and scripts/get_maintainer.pl more ;-)
<mrjay> mmind00: ok i found some newbie guide ... i'll read it first
mrjay has quit [Quit: Page closed]
nashpa has quit [Ping timeout: 272 seconds]
enkoder has joined #linux-rockchip