<mrjay>
mmind00: for channel selection fix should be simple: ((7 - chan->channel ) & SARADC_CTRL_CHN_MASK)
<mrjay>
mmind00: i'm not sure what start_conversion fix should look like ... maybe additional filed in rockchip_saradc_data structs for each variant with start conversion bit, used later in line 77 ?)
afaerber has joined #linux-rockchip
mrjay has quit [Quit: Page closed]
<mmind00>
and now he is gone
mrjay has joined #linux-rockchip
<mrjay>
mmind00: me?
<mmind00>
mrjay: yep :-)
<mmind00>
mrjay: I think when doing the core saradc driver, I based on the vendor-driver ... not sure how far the manual can be trusted
<mrjay>
mmind00: hmm ... in current state saradc driver for tsadc in rk3066 does not get any readings just stall ... i'll recompile and test
<mmind00>
mrjay: I guess that one additional bit might be interesting, although I did get sane values at the time
<mmind00>
mrjay: at least concerning the channels, I'm pretty sure they should be somewhat correct (at least stuff like the saradc keys seemed to always come form the correct channel)
<mrjay>
mmind00: weird ... now it is not working for tsadc variant ... saradc variant works ok.
<mrjay>
i do some testing ... enable all 4 channels and see what hapens :)
<mrjay>
mmind00: you think that datasheet might be wrong than?
<mmind00>
mrjay: it might be ... as you can see amount of channels in the register description doesn't match channels in he description and I guess the whole chapter just gets copy-pasted to every new manual
<mmind00>
mrjay: but who nows ... TRM might even be correct
<mrjay>
mmind00: ok testing all variants than
Astralix has quit [Remote host closed the connection]
sunilmohan has quit [Read error: Connection reset by peer]
ckeepax has joined #linux-rockchip
enkoder has quit [Ping timeout: 240 seconds]
sunilmohan_ has quit [Ping timeout: 272 seconds]
enkoder has joined #linux-rockchip
mrjay has joined #linux-rockchip
<mrjay>
does anyone can send patch to rockchip mailing list?
<sjoerd>
yes
<mrjay>
cool
<mrjay>
thanks
c0d3z3r0 has quit [Ping timeout: 250 seconds]
enkoder has quit [Ping timeout: 255 seconds]
afaerber has joined #linux-rockchip
ckeepax has quit [Ping timeout: 250 seconds]
naobsd has quit [Remote host closed the connection]
<mrjay>
is there a way to convert iio adc input value to temperature in device tree and then setup overheating protection for cpu for example by changing cpu clock rate?
<mmind00>
mrjay: there was an iio-thermal driver for that
<mrjay>
mmind00: was?
<mmind00>
but the relevant developer seems to have lost interest
<mrjay>
mmind00: too bad ... so no way then?
<mmind00>
mrjay: yes-way ... simply resurrect the patch and try to find out what is needed to get it accepted ;-)
<mrjay>
mmind00: anyone can do that? or is it restricted to author of the patch?
<mmind00>
mrjay: of course anyone can do that ... you just keep the original author, adapt the patch as needed and add your own signed off by ;-)
<mmind00>
mrjay: people pickung up discarded patches of others is pretty common