rrutkowski has joined #jruby
rrutkowski has quit [Client Quit]
rrutkowski has joined #jruby
<GitHub73> [jruby] yui-knk opened pull request #5010: Remove `f_to_r` call (jruby-9.1...rational_convert) https://git.io/vN60j
<headius> patch monster
cremes has quit [Quit: cremes]
baroquebobcat has quit [Quit: baroquebobcat]
akp has joined #jruby
akp has quit [Ping timeout: 260 seconds]
rrutkowski has quit [Quit: rrutkowski]
rrutkowski has joined #jruby
rrutkowski has left #jruby [#jruby]
bga57 has quit [Ping timeout: 260 seconds]
<GitHub16> [jruby] headius closed issue #4913: backtrace of the "stream closed" exception is wrong https://git.io/vbde8
akp has joined #jruby
akp has quit [Ping timeout: 248 seconds]
rrutkowski has joined #jruby
rrutkowski has quit [Remote host closed the connection]
rrutkowski has joined #jruby
bga57 has joined #jruby
rrutkowski has quit [Client Quit]
rrutkowski has joined #jruby
rrutkowski has quit [Remote host closed the connection]
Gauf has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client]
<GitHub162> [jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vN6ro
<GitHub162> jruby/jruby-9.1 8198bd5 Charles Oliver Nutter: Make RubyHash#put return existing value, as per Map contract....
<GitHub118> [jruby] headius force-pushed jruby-9.1 from 8198bd5 to db06305: https://git.io/v5g4w
<GitHub118> jruby/jruby-9.1 db06305 Charles Oliver Nutter: Make RubyHash#put return existing value, as per Map contract....
<GitHub46> [jruby] headius closed issue #4916: RubyHash doesn't implement the contract of java.util.Map correctly https://git.io/vbFpd
<GitHub84> [jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vN6ol
<GitHub84> jruby/jruby-9.1 26315d5 Charles Oliver Nutter: Disable forced native stdio when running under drip. Fixes #4942.
<GitHub165> [jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vN6o8
<GitHub165> jruby/jruby-9.1 600f8bd Charles Oliver Nutter: Update to jnr-posix 3.0.44.
<GitHub133> [jruby] headius closed issue #4942: No stdout with drip on jruby-9.1.15.0 https://git.io/vNUuc
cremes has joined #jruby
<travis-ci> jruby/jruby (jruby-9.1:600f8bd by Charles Oliver Nutter): The build passed. (https://travis-ci.org/jruby/jruby/builds/333089858)
cremes has quit [Quit: cremes]
bga57 has quit [Ping timeout: 268 seconds]
bga57 has joined #jruby
prasun has joined #jruby
akp has joined #jruby
cremes has joined #jruby
<GitHub193> [jruby] headius created more_method_inspect (+1 new commit): https://git.io/vN6Mp
<GitHub193> jruby/more_method_inspect 82fe95d Charles Oliver Nutter: More alignment of Method#inspect and aliased/wrapped methods.
<headius> zig-a-zig-ahhh
<GitHub49> [jruby] headius pushed 1 new commit to more_method_inspect: https://git.io/vN6Dt
<GitHub49> jruby/more_method_inspect c827260 Charles Oliver Nutter: Attempt to remove WrapperMethod again.
<headius> bleah
<GitHub10> [jruby] headius force-pushed more_method_inspect from c827260 to 82fe95d: https://git.io/vN6DY
akp has quit [Remote host closed the connection]
claudiuinberlin has joined #jruby
claudiuinberlin has quit [Client Quit]
akp has joined #jruby
akp has quit [Ping timeout: 240 seconds]
olle has joined #jruby
claudiuinberlin has joined #jruby
shellac has joined #jruby
prasun has quit [Ping timeout: 252 seconds]
shellac has quit [Quit: Computer has gone to sleep.]
shellac has joined #jruby
drbobbeaty has joined #jruby
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
etehtsea has joined #jruby
etehtsea has quit [Ping timeout: 240 seconds]
drbobbeaty has joined #jruby
rdubya has quit [Quit: Leaving.]
shellac has quit [Quit: Computer has gone to sleep.]
bbrowning_away is now known as bbrowning
shellac has joined #jruby
cremes has quit [Quit: cremes]
akp has joined #jruby
cremes has joined #jruby
akp has quit []
cremes has quit [Quit: cremes]
rrutkowski has joined #jruby
cremes has joined #jruby
xardion has quit [Remote host closed the connection]
xardion has joined #jruby
cremes has quit [Quit: cremes]
baroquebobcat has joined #jruby
rrutkowski has quit [Quit: rrutkowski]
baroquebobcat has quit [Read error: Connection reset by peer]
baroquebobcat has joined #jruby
baroquebobcat has quit [Quit: baroquebobcat]
<GitHub139> [jruby] headius pushed 1 new commit to more_method_inspect: https://git.io/vNiHc
<GitHub139> jruby/more_method_inspect 1ac2e59 Charles Oliver Nutter: Alias must pass its name, not given name.
cremes has joined #jruby
claudiuinberlin has quit [Quit: Textual IRC Client: www.textualapp.com]
olle has quit [Quit: olle]
<GitHub80> [jruby] enebo closed pull request #4993: Ruby 2.5: Add String#delete_prefix and String#delete_prefix! (ruby-2.5...feature/string-prefix) https://git.io/vNzhp
<GitHub24> [jruby] enebo pushed 3 new commits to ruby-2.5: https://git.io/vNi7d
<GitHub24> jruby/ruby-2.5 a9b3836 Thomas E Enebo: Merge pull request #4993 from ChrisBr/feature/string-prefix...
<GitHub24> jruby/ruby-2.5 f26efdb Christian Bruckmayer: Add String#delete_prefix and String#delete_prefix!...
<GitHub24> jruby/ruby-2.5 3817407 Christian Bruckmayer: Add tests for String#delete_prefix and String#delete_prefix!...
shellac has quit [Quit: Computer has gone to sleep.]
<GitHub85> [jruby] headius closed issue #1952: Variable update does not update it's javaType and then it causes TypeError in org.jruby.embed.jsr223.Utils#postEval https://git.io/vNi5E
claudiuinberlin has joined #jruby
shellac has joined #jruby
cremes has quit [Quit: cremes]
rrutkowski has joined #jruby
xardion has quit [Ping timeout: 240 seconds]
xardion has joined #jruby
baroquebobcat has joined #jruby
cremes has joined #jruby
rrutkowski has quit [Quit: rrutkowski]
<GitHub85> [jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vNPUZ
<GitHub85> jruby/jruby-9.1 788cd5b Charles Oliver Nutter: Handle unavailable protocol error from JDK as MRI does....
<GitHub2> [jruby] headius closed issue #4976: EADDRINUSE when binding TCP socket with globally disabled IPv6 https://git.io/vNCsZ
shellac has quit [Quit: Computer has gone to sleep.]
cremes has quit [Quit: cremes]
<travis-ci> jruby/jruby (jruby-9.1:788cd5b by Charles Oliver Nutter): The build passed. (https://travis-ci.org/jruby/jruby/builds/333410195)
rdubya has joined #jruby
baroquebobcat has quit [Quit: baroquebobcat]
baroquebobcat has joined #jruby
cremes has joined #jruby
baroquebobcat has quit [Quit: baroquebobcat]
baroquebobcat has joined #jruby
shellac has joined #jruby
<enebo> we talked about this for like 30 minutes last week didn't we?
<lopex> enebo, headius: shall I bump mid or major jcdoings/joni versions ?
<enebo> I thought we decided minor update
baroquebobcat has quit [Quit: baroquebobcat]
<lopex> enebo: mind releasing it then ? I'll file an issue on sonatype next time
<enebo> lopex: ok
GitHub79 has joined #jruby
GitHub79 has left #jruby [#jruby]
<GitHub79> jcodings/master d1ea0ee Thomas E. Enebo: [maven-release-plugin] prepare release jcodings-1.0.27
<GitHub79> [jcodings] enebo pushed 1 new commit to master: https://git.io/vNPZg
GitHub37 has joined #jruby
GitHub37 has left #jruby [#jruby]
<GitHub37> jcodings/master 2072c2c Thomas E. Enebo: [maven-release-plugin] prepare for next development iteration
<GitHub37> [jcodings] enebo pushed 1 new commit to master: https://git.io/vNPZV
GitHub113 has joined #jruby
GitHub113 has left #jruby [#jruby]
<GitHub113> [jcodings] enebo tagged jcodings-1.0.27 at 69cc19f: https://git.io/vNPZ2
shellac has quit [Ping timeout: 248 seconds]
shellac has joined #jruby
<lopex> enebo: thx
<enebo> lopex: done
<enebo> lopex: probably :) sonatype says it released but maybe you won't see it for a while...
<lopex> enebo: yeah, I have still mixed feeling about the scope of that
<lopex> wrt majority
<lopex> enebo: ultimately we settled that the data wont break
<lopex> but ultimately the changes will fix more than will break
<lopex> enebo: how to auto untag any tests ?
<enebo> for what? ruby/spec?
<lopex> test/mri mostly
<enebo> Oh I have no idea on test/mri mspec has an option but I just manually remove the exclude for mri
<lopex> bummer
<GitHub120> [jruby] nomadium opened pull request #5011: Remove TestArray#test_zip exclusion test case (master...fix-array-test-zip-exclude) https://git.io/vNPWE
shellac has quit [Ping timeout: 240 seconds]
<headius> lopex: yeah, manual
<lopex> headius: bummer
<headius> probably possible to write something to update them but I never have
<lopex> headius: test_quote, test_parse_look_behind, test_cclass_X at very least
<lopex> and test_dup_warn
<claudiuinberlin> hello, I just saw on youtube a video about jruby 9k and one of the slides was showing an amazing real time profiling or some GC. there is any documentation how to use it? I would like to show this tomorrow to my team. I try to convince them to use jruby/roda :)
<headius> claudiuinberlin: well the easiest way to see what we showed is just "jvisualvm" command in any OpenJDK/OracleJDK
<headius> the GC view I show in talks is the "Visual GC" plugin for VisualVM
<claudiuinberlin> thx!
<lopex> test_options_in_look_behind
<lopex> test_raw_hyphen_and_tk_char_type_after_range ?
<lopex> headius: quite a few
<headius> lopex: nice
<headius> wait, do you mean quite a few pass now?
<lopex> my results
<headius> I usually re-run the whole file without excludes and just update it
<headius> but you can -n to run single tests and do it that way
<headius> lopex: half as many as are tagged on my current branch (I think 9.1)
<lopex> on bin/jruby test/mri/runner.rb test/mri/ruby/test_regexp.rb
<lopex> headius: 5 failures, 1 errors
bbrowning is now known as bbrowning_away
<lopex> headius: enebo said we can land that on all three branches
<headius> sounds great to me
<lopex> test_char_class too
<lopex> I assumed the tagging was automatic modulo intermitent ones
<lopex> silly me
<headius> lopex: feel free to commit, it all sounds fine
<headius> merge to master might be sticky, I'll do a preemptive merge now
<lopex> headius: just the deps ?
<lopex> headius: just change the deps
<headius> oh, no work needed in JRuby proper?
<headius> well I can do that
<lopex> headius: there's some jruby regexp fixes that can be cherrypicked
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
<lopex> headius: if you grep my latest jruby commits
cremes has quit [Quit: cremes]
<headius> ok
<headius> I'll take a look
<headius> claudiuinberlin: is that ok?
<claudiuinberlin> <headius> using, jruby, sequel with pg_jruby and return 25 items from DB, using pagination, and select, plus default json parser, now handle: Requests/sec: 625.94
<claudiuinberlin> 2 years ago, using same stack, minus pumna: https://github.com/llaine/benchmarks
<claudiuinberlin> you have: Req/Sec 377.86
<headius> seems like progress :-)
<claudiuinberlin> yes!
<enebo> neat
<claudiuinberlin> 1.6 if my math is still correct
<claudiuinberlin> I guess is quite amazing!
<claudiuinberlin> I'm curious if I try to use some java json parsing library will improve
<claudiuinberlin> also, I never run it, for more than 10 minutes, so I guess no JIT
<enebo> claudiuinberlin: JRuby : JRuby 9.1.2.0 with roda and torquebox torquebox jar ; java -jar ruby.jar;
<claudiuinberlin> yes
<claudiuinberlin> that was 2 years
<claudiuinberlin> but I found it torquebox is somehow in diatus mode
<enebo> oh I just saw the 1.6 and wondered :)
<headius> yeah unfortunately
<claudiuinberlin> so now I just use puma
<lopex> yeah, go puma
<claudiuinberlin> guys is quite amazing!
<claudiuinberlin> really, really good job
<claudiuinberlin> memory is ~250MB
<claudiuinberlin> quite ok here
<claudiuinberlin> zero settings on puma config, or json
<enebo> claudiuinberlin: if we wanted to play with these we can just clone this repo?
<claudiuinberlin> moment
<claudiuinberlin> also headius
<claudiuinberlin> I will add you to the repo
<enebo> claudiuinberlin: ok but I am more interested in just being able to easily run this as any changes I make will likely be on JRuby itself
<claudiuinberlin> nice
<enebo> In some work I am doing I am concerned with new allocations so I will be looking at allocation profiling pretty soon
<headius> lopex: I only see one commit from you to 9.1 in the past year
<claudiuinberlin> after 10 minutes: Requests/sec: 756.58
<headius> \K fix
<lopex> headius: I did more on master
<headius> enebo: yeah this is great to have a benchmark app
<headius> lopex: ok
<lopex> headius: 4 or so
<lopex> headius: those target test_regexp unrelated to joni/jcodings
<enebo> headius: yeah. whatever that memory leak bench I tweeted about made me wonder about allocation since we did not leak but man that garbage was flying by
<claudiuinberlin> I invite you, the branch is jruby
<headius> lopex: ok
<headius> enebo: allocation is always the problem
<lopex> headius: do you see it ?
<enebo> well it is never the answer :)
<lopex> headius: most oneliners for probably backportable
<claudiuinberlin> there is any json library suitable for jruby?
<headius> lopex: I'm updating excludes on 9.1 for the joni/jcodings update first
pcarlisle has joined #jruby
<headius> lopex: yeah cool, I have it...all these are valid to cherry-pick?
<headius> that kcode one isn't on 9.1 either
<lopex> hmm
<lopex> ah
<headius> seems fine
<lopex> it switches to strict encodings
<headius> yeah which happened a long time ago in MRI
<lopex> headius: it's was an effort to remove non strict ones
<headius> might as well keep it in sync
<lopex> we're cool
<headius> huh really?
<headius> I know those guys
<lopex> but apparently facebook relies on them still
<lopex> yeah
<lopex> headius: yeah want to find that issue for you ?
<lopex> it still bothers them
<lopex> but their fix is a no go for us
<lopex> since mri/onigmo changed encoding length routines
claudiuinberlin has quit [Quit: Textual IRC Client: www.textualapp.com]
<lopex> headius: do they cherry pick ok ?
<lopex> I want to forget about those
<headius> I had to cp some earlier work on StringIO/IO chomp gets
<headius> but everything picked fine after that
<headius> this might mean our 9.1.16 supports a 2.4 chomp flag
<lopex> what does it do ?
<headius> autochomp of read lines
<lopex> I mean, does it rely on jcodings changes ?
<GitHub30> [jruby] headius pushed 14 new commits to jruby-9.1: https://git.io/vNP2O
<GitHub30> jruby/jruby-9.1 2685d48 Charles Oliver Nutter: Mark this critical since it hangs.
<GitHub30> jruby/jruby-9.1 9ddcfc0 Charles Oliver Nutter: Update Regexp, String, and Symbol excludes.
<GitHub30> jruby/jruby-9.1 409f42f Charles Oliver Nutter: Update jcodings and joni to pick up latest work.
<GitHub103> [jruby] headius pushed 1 new commit to master: https://git.io/vNP2W
<GitHub103> jruby/master 4cdf882 Charles Oliver Nutter: More alignment of Method#inspect and aliased/wrapped methods.
<headius> I'll let CI chew on that before I attempt to merge
<headius> huh, my commit signing gets applied to cherry-picks
<lopex> headius: btw this one change is noneffective because parser
<lopex> mri deals with that differently
<headius> ahh
<lopex> shouldnt make any difference though
<lopex> enebo: ^^
<headius> well so far so good on CI, I'll be back in a bit to check it
<lopex> enebo: mri doesnt immediately raise regexp error on parse
<lopex> they just error
<lopex> and then decide in the runtime what t odo
<lopex> enebo: if you care about those remaining tests
<lopex> headius: becomes greenier
<headius> seems like pretty edge case stuff
<headius> yeah greener is good
<lopex> jit take 16 minutes for me locally
<lopex> takes
<lopex> er nonjit
<enebo> lopex: greener is good
<lopex> enebo: unless it isnt
<headius> we should move spec:ruby and the MRI tests to the top so they start first
<headius> we need to make them shorter too
<headius> they're usually the only ones I'm interested in
hipertracker has joined #jruby
hipertracker has quit [Quit: hipertracker]
<lopex> headius: but surprisingly lots of tests pass but underneath some caching fails miserably
<lopex> that's what I learned last time
<lopex> almost green, but perf wise it would be a disaster
<lopex> so tests are leaky indeed
<headius> yeah there's definitely holes
<lopex> and perfholes
<headius> ahh a 7-bit option?
<lopex> yeah
<lopex> headius: in part some of if was always enabled in only singlebyte
<lopex> headius: but not we can do it for 7bit coderange
<lopex> s/not/now
<lopex> I can show you the diff in opcode impl
<lopex> headius:
<headius> maybe I removed too many excludes
<headius> hmm failures
<lopex> and it goes for number of opcodes
<headius> [exec] TestTranscode#test_windows_1255 [/home/travis/build/jruby/jruby/test/mri/ruby/test_transcode.rb:366]:
<headius> [exec] Encoding::UndefinedConversionError expected but nothing was raised.
<headius> that's gotta be from jcodings update
<lopex> hm
<lopex> yeah transcode
<headius> brb
rrutkowski has joined #jruby
rrutkowski has quit [Remote host closed the connection]
<lopex> headius: reducing
<lopex> though it might require bisecting
rrutkowski has joined #jruby
<lopex> headius: what suite I was not running btw ?
<headius> that was in MRI suite, which I rarely run locally because it's so long
<lopex> is that one failure ?
<lopex> too late for me now, but will definitely down that tomorrow
<lopex> no clue for now
<lopex> tried utf8 = "\u05BA" raw = "\xCA"
<lopex> hmm
<headius> it passes locally on macos
<headius> lopex: ok, I'll have a look also
<lopex> so linux only ?
<lopex> or intermittent ?
<headius> seems consistent and linux only
<headius> oh wait I'm on master
<headius> lopex: it's excluded on master
<lopex> why ?
<lopex> that one case ?
<lopex> I'm lost