06:11 <camonz> hi, is there a guide somewhere to get wallaroo running

06:12 <camonz> I want to submit a PR to refactor https://github.com/WallarooLabs/wallaroo/blob/master/monitoring_hub/apps/metrics_reporter/lib/metrics_reporter/latency_stats_calculator.ex but I'll need some sample data to write some tests for it

14:42 <SeanTAllen> hi camonz

14:42 <SeanTAllen> check out https://docs.wallaroolabs.com/book/getting-started/setting-up-your-environment.html

18:20 <camonz> SeanTAllen: thanks, I'll take a look later on today

19:36 <jonbrwn> camonz: I've opened a PR with a minimal test case for the public facing functions, I'll let you know once that's merged.

19:36 <camonz> awesome :)

22:48 <jonbrwn> camonz: the tests have been merged, should be enough for you to comfortably refactor without needing sample data

22:48 <camonz> jonbrwn: thanks, I appreciate it

22:49 <jonbrwn> camonz: thank you for wanting to contribute, if you have any questions feel free to ping me

22:50 <camonz> will do, I touched the codebase a bit yesterday but didn't feel comfortable touching what seemed like critical parts

22:51 <camonz> but, there was simple stuff like moving get_percentiles to a module attr

22:51 <camonz> or defp calculate_latency_bins_total(bins) do: Map.values(bins) |> Enum.sum()

22:52 <camonz> instead of getting the keys, then using a reduce to fetch the item at key and doing the sum

22:52 <jonbrwn> cool, look forward to seeing what you come back with. that was some of the first elixir code I wrote so I'm sure it could be cleaned up a bit

22:53 <camonz> I figured from the commits history, it's almost 2yrs old

22:53 <camonz> but it seemed like one of the biggest offenders

22:54 <camonz> I found the project through a blogpost and decided to take a look at the src

22:59 <jonbrwn> where'd you come across the blog post?

23:01 <camonz> think I saw it on /r/elixir

23:35 <jonbrwn> nice