<diego-ch>
it brings hw encoders/decoders support to samsung devices with ste soc
<diego-ch>
also sony devices with ste soc
DAGr8_1 has quit [Ping timeout: 246 seconds]
<paulk-collins>
codeworkx, ping (sorry I'm bothering you a lot these days)
DAGr8 has joined #teamhacksung
<codeworkx>
hai
<codeworkx>
paulk-collins: wassup?
<paulk-collins>
codeworkx, I'm still working on galaxy s3 camera
<paulk-collins>
and I included important fixes for galaxy s2 along the way
<paulk-collins>
they're waiting on gerrit
<codeworkx>
just add me "codeworkx"
<paulk-collins>
ok
<paulk-collins>
then for picture, the interleaved format is V4L2_PIX_FMT_YUYV at the beginning and then at some point it has a JPEG frame too
<paulk-collins>
when requested
<diego-ch>
thanks codeworkx, there is also the same patch for cm-10.1 branch, I'll get the links
<paulk-collins>
the point is that it doesn't require to interrupt preview and/or recording
<paulk-collins>
and it's only available for the back camera
<paulk-collins>
however it'll be a pain to handle(mainly because we can't choose something else than V4L2_PIX_FMT_YUYV in the hybrid stream)
<paulk-collins>
so we'll have to do on-the-go conversion using the FIMC output thing, and I've tried very hard to avoid it on galaxy s2, and I'd like to keep it that way on galaxy s3
<paulk-collins>
so my plan is that I don't support hybrid on exynos_camera
<paulk-collins>
and just go the regular way, by interrupting the preview feed, requesting a higher resolution in JPEG, etv
<paulk-collins>
etc*
<paulk-collins>
(or in YUV and do the one-time conversion, that doesn't matter)
<paulk-collins>
so is that a feature that is going to be missed in CM?
<paulk-collins>
that'll mean a short time of no preview running like on other samsung devices
<paulk-collins>
while currently with the non-free lib there is indeed preview running the whole time
<paulk-collins>
I guess the biggest interest was taking pictures during recording, but it seems that the CM camera app doesn't handle that anyway (or maybe the new one does?)
<codeworkx>
paulk-collins: it does afaik
<paulk-collins>
the new one?
<paulk-collins>
well I'm still working with CM 9.1 so I'd probably not aware of what's new
<codeworkx>
even the old one
<codeworkx>
works on my htc one
<paulk-collins>
okay
<paulk-collins>
so, I guess I'll leave the implementation of that up to someone else then
<paulk-collins>
because I need rgb565 preview in replicant and can't cope with YUYV in any way
<paulk-collins>
codeworkx, thanks for merging. I added them for cm-10.1 too.
<codeworkx>
merged both
<paulk-collins>
ah indeed
<paulk-collins>
thanks
<codeworkx>
did you grab the exif fixes?
<paulk-collins>
yep
<paulk-collins>
work nicely
<paulk-collins>
codeworkx, ah yeah, there is another matter
<paulk-collins>
codeworkx, I found out touch to focus is a fraud
<paulk-collins>
basically (as much in the samsung lib as in mine), the area selected by the user is just ignored
<codeworkx>
xplodwild: ^
datagutt has quit [Quit: Computer has gone to sleep.]
<paulk-collins>
and the v4l2 call to make it work for real is not used
<paulk-collins>
what happens is just a regular auto-focus
<codeworkx>
well done samsung
<paulk-collins>
but nobody noticed
<paulk-collins>
so I wrote a patch to make it work
<xplodwild>
paulk-collins: I noticed it recently on N7000 while testing Focal
<paulk-collins>
:)
<xplodwild>
it always focuses at the center
<paulk-collins>
yes
<paulk-collins>
that's it
<paulk-collins>
So I have a patch
<paulk-collins>
but the performances are not excellent
<paulk-collins>
that's up to the firmware though
<paulk-collins>
but it often fails
<xplodwild>
better than nothing
<paulk-collins>
so I'll push it at some point and let you guys evaluate it