ifreund changed the topic of #river to: river - a dynamic tiling wayland compositor - https://github.com/ifreund/river - channel logs: https://freenode.irclog.whitequark.org/river/
waleee-cl has quit [Quit: Connection closed for inactivity]
maringuu has quit [Ping timeout: 245 seconds]
maringuu has joined #river
leon-p has joined #river
dottedmag has left #river [#river]
dottedmag has joined #river
dottedmag has left #river [#river]
gspe has joined #river
yyp has joined #river
<novakane[m]> so is someone here know how I can solve this in scanner.zig https://zigbin.io/0b5fab
<yyp> novakane[m]: try using something like this: https://paste.sr.ht/~yerinalexey/5bce58a7a91d8ca156468362289add5632f5c727
<novakane[m]> yyp: oh thanks! it looks like it works
<yyp> nice
<yyp> Hmm, formatIdentifierImpl should be probably FormatIdentifierImpl, this is more in line with other function that generate types :)
<novakane[m]> yeah that's what zig lsp tell me but that's not how it is in the std library so I'm confused
<yyp> whut
<yyp> That's weird
leon-p has quit [Ping timeout: 245 seconds]
leon-p has joined #river
<yyp> You should probably ask about that in #zig, to me it seems like an inconsistent move to make
<ifreund> eh, the returned type doesn't have any fields, cameCase seems fine to me
<ifreund> structs without fields are consistently snake_case
<ifreund> novakane[m]: as for your error message, you can't use try if you don't return an error union
<novakane[m]> ifreund: I know but I'm kinda obligated to use try since the emit function need it
<ifreund> huh?
<ifreund> you shouldn't need that buffer or fixed buffer writer anymore I don't think
<ifreund> that was just a hack to avoid a lot of code duplication before the std.fmt.Formatter pattern existed
<novakane[m]> alright, more thing on my todo list
<ifreund> you might want to try breaking this refactoring up into smaller steps
malice has quit [Read error: Connection reset by peer]
<ifreund> e.g. in the first commit do nothing but put the new named format specifier syntax into use
malice has joined #river
<novakane[m]> Yeah you're right that's a better idea
<novakane[m]> I made it all works like I want in the test I did with debug.print but implement it in the scanner doesn't works exactly the same
<novakane[m]> btw is there a reason you didn't use std.mem.trimLeft for the trimPrefix? Or is it a zig 0.8.0 things?
<ifreund> I probably forgot it existed
<ifreund> I wrote the scanner code quite fast, it's a bit sloppy
<novakane[m]> ok cool I changed it but I thought maybe there was a good reason
<novakane[m]> also the other day you said we should change title_case to the original variable name, I'm not sure how you would do that
<ifreund> I meant that there's no reason to have a title_case variable when we can just do print("{}", .{ titleCase(foobar) });
<novakane[m]> oh yeah of course
maringuu has quit [Ping timeout: 245 seconds]
maringuu has joined #river
maringuu has quit [Ping timeout: 250 seconds]
maringuu has joined #river
maringuu has quit [Ping timeout: 245 seconds]
maringuu has joined #river
maringuu has quit [Ping timeout: 250 seconds]
maringuu has joined #river
maringuu has quit [Ping timeout: 250 seconds]
yyp has quit [Remote host closed the connection]
maringuu has joined #river
malice has left #river [#river]
waleee-cl has joined #river
maringuu has quit [Ping timeout: 250 seconds]
maringuu has joined #river
yyp has joined #river
maringuu has quit [Ping timeout: 250 seconds]
maringuu has joined #river
maringuu has quit [Ping timeout: 245 seconds]
maringuu has joined #river
maringuu has quit [Ping timeout: 240 seconds]
maringuu has joined #river
yyp has quit [Ping timeout: 252 seconds]
yyp has joined #river
gspe has quit [Quit: gspe]
gspe has joined #river
yyp has quit [Remote host closed the connection]
gspe has quit [Quit: gspe]
leon-p has quit [Quit: leaving]