lritter has quit [Ping timeout: 272 seconds]
kandinsk1 is now known as kandinski
jacob22 has joined #pypy
jacob22_ has quit [Read error: Connection reset by peer]
Mutter has joined #pypy
Mutter has quit [Client Quit]
Mutter has joined #pypy
Mutter has quit [Ping timeout: 240 seconds]
jcea has quit [Quit: jcea]
kostia has joined #pypy
kostia has quit [Ping timeout: 246 seconds]
forgottenone has joined #pypy
forgottenone has quit [Remote host closed the connection]
forgottenone has joined #pypy
dddddd has quit [Remote host closed the connection]
jacob22 has quit [Read error: Connection reset by peer]
jacob22 has joined #pypy
Ai9zO5AP has joined #pypy
inhahe has joined #pypy
kostia has joined #pypy
kostia has quit [Remote host closed the connection]
kostia has joined #pypy
kostia has quit [Remote host closed the connection]
kostia has joined #pypy
darkman66 has joined #pypy
darkman66 has quit [Remote host closed the connection]
darkman66 has joined #pypy
alawrence has joined #pypy
alawrence has quit [Quit: Page closed]
kostia has quit [Remote host closed the connection]
kostia has joined #pypy
forgottenone has quit [Quit: Konversation terminated!]
kostia has quit [Remote host closed the connection]
forgottenone has joined #pypy
kostia has joined #pypy
darkman66 has quit [Remote host closed the connection]
kostia has quit [Remote host closed the connection]
darkman66 has joined #pypy
darkman66 has quit [Remote host closed the connection]
darkman66 has joined #pypy
kostia has joined #pypy
forgottenone has quit [Quit: Konversation terminated!]
antocuni has joined #pypy
<
mattip>
antocuni: around?
<
antocuni>
mattip: yes
xcm has quit [Remote host closed the connection]
xcm has joined #pypy
<
mattip>
antocuni do you have an opion on cf058300ea04, see discussion here with me and ronan
<
mattip>
it solves the problem in the issue, but "if space.is_w(w_type, space.w_tuple): pto.c_tp_new = state.C.tuple_new" is not nice
<
antocuni>
which issue?
<
antocuni>
ah, it's in the branch name :)
<
mattip>
2968, the parent commit on that branch
* antocuni
still looking
<
mattip>
the idea was to move the tp_new to C, which avoids make_ref and the recursion.
<
antocuni>
yes, it looks like a good idea in general
<
antocuni>
I agree that "if space.is_w(w_type, space.w_tuple): ..." is a bit ugly
<
mattip>
ronan said "but maybe having that code will force us to be more systematic" so I could add an 'XXX do this more nicely' comment there
<
mattip>
and later we can think of a way to do this when filling in the slots
<
antocuni>
I am trying to see whether there is a better place to put it
<
antocuni>
but yes, it might be that we still don't have a better place and we need to invent something
<
antocuni>
sorry, phone call
<
antocuni>
so, I think that we probably want a general way to write slots for builtin types in C
<
antocuni>
but I think it's fine for now to just leave the hack and write an XXX
<
mattip>
ok, I will merge it as-is (fix the test for py2-py3)
<
mattip>
and add a comment
lesshaste has quit [Ping timeout: 252 seconds]
dante has quit [Ping timeout: 246 seconds]
dante has joined #pypy
lesshaste has joined #pypy
lesshaste is now known as Guest10006
Guest10006 has quit [Quit: Leaving]
darkman6_ has joined #pypy
darkman66 has quit [Ping timeout: 245 seconds]
dddddd has joined #pypy
antocuni has quit [Ping timeout: 246 seconds]
jcea has joined #pypy
themsay has quit [Read error: Connection reset by peer]
themsay has joined #pypy
kostia has quit [Remote host closed the connection]
kostia has joined #pypy
kostia has quit [Ping timeout: 272 seconds]
Rhy0lite has joined #pypy
adamholmberg has joined #pypy
lritter has joined #pypy
brtknr has joined #pypy
<
brtknr>
ronan: hello, im the guy you keep bumping into in all the bristol meetups!
antocuni has joined #pypy
darkman6_ has quit [Remote host closed the connection]
tsaka__ has quit [Ping timeout: 268 seconds]
<
kenaan>
mattip issue2968 4285c5076c8e /pypy/module/cpyext/: rework test for python2, python3
<
kenaan>
mattip default 23b9c2f3f1d0 /pypy/module/cpyext/: move PyTuple_Type.tp_new to C
<
kenaan>
mattip default da49044a5452 /pypy/module/cpyext/: rework test for python2, python3
<
kenaan>
mattip default d3aefbf6dae7 /pypy/module/cpyext/test/test_tupleobject.py: fix merge from grafting issue2968
<
kenaan>
mattip issue2968 074e102b8636 /: close branch to be merged
<
kenaan>
mattip py3.6 12d0c4f992fd /pypy/module/cpyext/: merge issue 2968 into py3.6
<
kenaan>
mattip py3.6 605f74b0221c /: merge default into branch
<
kenaan>
mattip release-pypy2.7-v7.x 990cef41fe11 /: merge default into release
<
kenaan>
mattip release-pypy3.6-v7.x bb0d05b190b9 /: merge py3.6 into release
kostia has joined #pypy
forgottenone has joined #pypy
kostia has quit [Ping timeout: 246 seconds]
kostia has joined #pypy
<
ronan>
brtknr: hi! That's quite a big difference!
kostia has quit [Ping timeout: 252 seconds]
leshaste has joined #pypy
kostia has joined #pypy
kostia has quit [Ping timeout: 250 seconds]
xorAxAx has quit [Read error: Connection reset by peer]
xorAxAx has joined #pypy
kostia has joined #pypy
kostia has quit [Ping timeout: 240 seconds]
runciter_ is now known as runciter
darkman66 has joined #pypy
darkman66 has quit [Ping timeout: 245 seconds]
kostia has joined #pypy
adamholmberg has quit [Remote host closed the connection]
adamholmberg has joined #pypy
leshaste has quit [Quit: Leaving]
michaelgreene has joined #pypy
antocuni has quit [Ping timeout: 268 seconds]
adamholmberg has quit [Remote host closed the connection]
tsaka__ has joined #pypy
adamholmberg has joined #pypy
Zaab1t has joined #pypy
kostia has quit [Remote host closed the connection]
kostia has joined #pypy
kostia has quit [Remote host closed the connection]
kostia has joined #pypy
darkman66 has joined #pypy
Rhy0lite has quit [Quit: Leaving]
kostia has quit [Remote host closed the connection]
kostia has joined #pypy
darkman66 has quit [Remote host closed the connection]
darkman66 has joined #pypy
Zaab1t has quit [Quit: bye bye friends]
tsaka__ has quit [Ping timeout: 252 seconds]
darkman66 has quit [Remote host closed the connection]
adamholmberg has quit [Remote host closed the connection]
adamholmberg has joined #pypy
darkman66 has joined #pypy
michaelgreene has joined #pypy
forgottenone has quit [Quit: Konversation terminated!]
kostia has quit [Remote host closed the connection]
kostia has joined #pypy
adamholmberg has quit [Remote host closed the connection]
darkman66 has quit [Remote host closed the connection]
darkman66 has joined #pypy
kostia has quit [Ping timeout: 250 seconds]
adamholmberg has joined #pypy
darkman66 has quit [Ping timeout: 246 seconds]
adamholmberg has quit [Ping timeout: 272 seconds]
darkman66 has joined #pypy
Ai9zO5AP has quit [Quit: WeeChat 2.4]
darkman66 has quit [Remote host closed the connection]
darkman66 has joined #pypy
darkman66 has quit [Ping timeout: 272 seconds]
darkman66 has joined #pypy
darkman66 has quit [Remote host closed the connection]
xcm has quit [Remote host closed the connection]
xcm has joined #pypy
xcm has quit [Remote host closed the connection]
xcm has joined #pypy
WGH has joined #pypy
speeder39_ has joined #pypy
tsaka__ has joined #pypy