09:21 <mtrbot-ml> [mattermost] <hartytp> @sb10q Am I missing something, or is gitea lacking a lot of the nice features of github?

09:22 <mtrbot-ml> [mattermost] <hartytp> e.g. can I leave a comment on a particular line of a commit that's already been merged?

09:22 <mtrbot-ml> [mattermost] <hartytp> @astro general point about thermostat: I'm coming around to the point of view that the firmware should do everything in mu rather than SI units. It feels much cleaner to put the SI unit conversion in the python driver

09:23 <mtrbot-ml> [mattermost] <hartytp> I don't think we need that units crate

09:26 <mtrbot-ml> [mattermost] <hartytp> also, I don't think the AD7172 calibration is really helpful. IIRC I worked through the maths (see one of my previous posts here) and the uncalibrated offset in the ADC is far lower than the accuracy of any temperature sensor you can but. Similarly, I suspect that the gain is more limited by the divider resistors on stabilizer than by the ADC. Even though calibrating does no hard, I'd prefer to remove it since (

09:32 <mtrbot-ml> [mattermost] <hartytp> can I even get a link to a line of a commit in gitea? If not, that's quite annoying as it makes discussing code harder

09:33 <mtrbot-ml> [mattermost] <hartytp> whatever the merits of gitea v github, gitea definitely feels strictly worse from a user experience perspective

11:50 <mtrbot-ml> [mattermost] <sb10q> @hartytp stop complaining and write a PR, gitea is open source

11:53 <mtrbot-ml> [mattermost] <sb10q> for a community project without VC/microsoft funds, gitea is very good

23:38 <_whitenotifier-c> [smoltcp] plorefice opened pull request #342: SNTP wire protocol and client - https://git.io/JfE32

23:46 <_whitenotifier-c> [smoltcp] Failure. The Travis CI build failed - https://travis-ci.org/github/smoltcp-rs/smoltcp/builds/688177698?utm_source=github_status&utm_medium=notification

23:47 <_whitenotifier-c> [smoltcp] whitequark commented on pull request #342: SNTP wire protocol and client - https://git.io/JfE3H