<GitHub1>
jruby/master dfa0e71 kares: [refactor] and dry-out default internal equality checks in RubyObject
<enebo>
kares: I think that commit maybe needs a comment if it is correct
<enebo>
new numeric removed EQL and just uses OP_EQUAL now for both cases
<enebo>
Is that ok?
<GitHub98>
[jruby] enebo pushed 1 new commit to bytelist_love: https://git.io/vpZ6U
<GitHub98>
jruby/bytelist_love 6f74142 Thomas E. Enebo: Fix pushsymbolproc to use id vs bytelist to be consistent with new id...
claudiuinberlin has joined #jruby
edmz_ has joined #jruby
edmz has quit [Read error: Connection reset by peer]
edmz_ is now known as edmz
edmz has quit [Ping timeout: 276 seconds]
edmz has joined #jruby
<kares>
enebo: seems correct, at least tests pass the sameand is now more dry
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<enebo>
kares: but those are potentially totally different methods
<enebo>
kares: I am somewhat surprised no test caught that. I may try to find a case.
<kares>
yet they shared some logic of the same :)
<enebo>
kares: unless you override them
<kares>
okay - well feel free to
<kares>
its only the base impl - that is correct
<enebo>
kares: it maybe is possible no numeric type can?
<GitHub183>
[jruby] enebo pushed 1 new commit to bytelist_love: https://git.io/vpZDU
<GitHub183>
jruby/bytelist_love 69dc167 Thomas E. Enebo: Go to type for argument descriptor from ByteList.
<kares>
hmm I wonder why am I suddenly hitting a **/opt/java/jdk/bin/java: error while loading shared libraries: dlopen: invalid caller**
<kares>
... after messing with android studio yesterday?!?
<kares>
enebo: yy I believe so
<enebo>
kares: My original comment was more if this is really true we should add a comment because it looks like a bug at a glance but I will try to see if I can make it fail as well
<headius>
kares: youch
<headius>
LD_LIBRARY_PATH mucked up somehow?
<headius>
kares: I can't see a logic difference but I do wonder if it's correct for both paths to call == for numerics