<deepender>
basically indirect said: it is not giving installing message
<deepender>
I think it is giving
jacobat has joined #bundler
<tmoore>
Ah right... well the code there is a bit hard to understand. I agree with indirect that we want to avoid using class variables, and it looks like "@@flag" has multiple responsibilities: keeping count of the number of installed gems and keeping track of whether to summarise or print each time
<tmoore>
I'll comment some more on the pull request
<deepender>
okey I will fix it
<deepender>
but functionality is right
<deepender>
tmoore:
<tmoore>
Yeah it looks like the functionality is OK
<deepender>
cool
<deepender>
The reason I make @@flag as class variable as
<deepender>
function is class method
robbyoconnor has quit [Ping timeout: 246 seconds]
<deepender>
so instance variable can't be used
<deepender>
as far as I think
<deepender>
and so you are saying I use two variable which has individual responsibilty
<tmoore>
I've gotta run now too, but I'll add some ideas to the pull request when I get back... I think it would be better to push it into the instance
<deepender>
tmoore: thanks and a Happy new year to you also
robbyoconnor has joined #bundler
robbyoconnor has quit [Ping timeout: 246 seconds]
robbyoconnor has joined #bundler
robbyoconnor has quit [Ping timeout: 260 seconds]
robbyoconnor has joined #bundler
robbyoconnor has quit [Excess Flood]
robbyoconnor has joined #bundler
JordanFaust_ has joined #bundler
robbyoconnor has quit [Ping timeout: 246 seconds]
robbyoconnor has joined #bundler
robbyoconnor has quit [Quit: Konversation terminated!]
robbyoconnor has joined #bundler
cha1tanya has joined #bundler
havenwood has joined #bundler
cha1tanya has quit [Read error: Connection reset by peer]
cha1tanya has joined #bundler
JordanFaust_ has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
cwebber has joined #bundler
havenwood has quit [Remote host closed the connection]
havenwood has joined #bundler
cwebber has quit []
<tmoore>
deepender: I added some more comments, but unfortunately this is a little more complex than it seems on the surface
<tmoore>
the parallel gem installation feature new in 1.5 makes it tricky
<tmoore>
I would recommend splitting up the decision about whether to print the install message from the code that counts installed gems
<deepender>
yes
<deepender>
tmoore: just saw them
<deepender>
you are right
<deepender>
this is bit tricky
<deepender>
I will work on them in around 10 minutes, suddenly some urgent work came
<tmoore>
sure... no rush :)
cha1tanya has quit [Ping timeout: 248 seconds]
deepender has quit [Read error: Operation timed out]
retro|cz has joined #bundler
r0bby_ has joined #bundler
robbyoconnor has quit [Ping timeout: 246 seconds]
JordanFaust_ has joined #bundler
deepender has joined #bundler
cha1tanya has joined #bundler
r0bby_ has quit [Ping timeout: 246 seconds]
r0bby_ has joined #bundler
deepender has quit [Read error: Operation timed out]
cha1tanya has quit [Ping timeout: 248 seconds]
cha1tanya has joined #bundler
JordanFaust_ has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
coda23 has joined #bundler
deepender has joined #bundler
coda23 has quit [Quit: Leaving]
r0bby_ has quit [Excess Flood]
r0bby_ has joined #bundler
samphippen has joined #bundler
havenwood has quit [Remote host closed the connection]
deepender has quit [Ping timeout: 245 seconds]
havenwood has joined #bundler
havenwood has quit [Ping timeout: 240 seconds]
havenwood has joined #bundler
havenwood has quit [Ping timeout: 245 seconds]
patcon has joined #bundler
deepender has joined #bundler
axl_ has joined #bundler
deepender has quit [*.net *.split]
tmoore has quit [*.net *.split]
deepender has joined #bundler
tmoore has joined #bundler
havenwood has joined #bundler
havenwood has quit [Ping timeout: 272 seconds]
deepender has quit [Ping timeout: 246 seconds]
deepender has joined #bundler
patcon has quit [Remote host closed the connection]
patcon has joined #bundler
cha1tanya has quit [Ping timeout: 272 seconds]
patcon has quit [Remote host closed the connection]
havenwood has joined #bundler
havenwood has quit [Ping timeout: 260 seconds]
deepender has quit [Ping timeout: 252 seconds]
samphippen has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
eurotech has joined #bundler
patcon has joined #bundler
r0bby_ has quit [Ping timeout: 240 seconds]
eurotech has quit [K-Lined]
r0bby_ has joined #bundler
patcon has quit [Ping timeout: 260 seconds]
robbyoconnor has joined #bundler
r0bby_ has quit [Ping timeout: 246 seconds]
ereslibre_laptop has joined #bundler
ereslibre_laptop has joined #bundler
ereslibre_laptop has quit [Changing host]
patcon has joined #bundler
sneak_ has joined #bundler
havenwood has joined #bundler
adam12 is now known as adam
adam has quit [Disconnected by services]
sneak has quit [Ping timeout: 240 seconds]
ereslibre has quit [Read error: Connection reset by peer]
adam- has joined #bundler
robbyoconnor has quit [Read error: Connection reset by peer]
robbyoconnor has joined #bundler
robbyoconnor has quit [Changing host]
robbyoconnor has joined #bundler
patcon has quit [Read error: Connection reset by peer]
patcon has joined #bundler
samphippen has joined #bundler
deepender has joined #bundler
patcon has quit [Remote host closed the connection]
samphippen has quit [Read error: Connection reset by peer]
adam- is now known as adam12
axl_ has quit [Quit: axl_]
axl_ has joined #bundler
hagebake is now known as hagabaka
patcon has joined #bundler
cha1tanya has joined #bundler
patcon has quit [Ping timeout: 240 seconds]
deepender has quit [Ping timeout: 248 seconds]
patcon has joined #bundler
patcon has quit [Remote host closed the connection]
patcon has joined #bundler
deepender has joined #bundler
samphippen has joined #bundler
samphippen has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
cha1tanya has quit [Read error: Connection reset by peer]
patcon_ has joined #bundler
rhunter has joined #bundler
patcon has quit [Ping timeout: 248 seconds]
rjhunter has quit [Ping timeout: 252 seconds]
chouhoulis has quit [Remote host closed the connection]
samphippen has joined #bundler
samphippen has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
deepender has quit [Ping timeout: 252 seconds]
patcon_ has quit [Ping timeout: 245 seconds]
patcon has joined #bundler
cha1tanya has joined #bundler
patcon has quit [Read error: Connection reset by peer]
patcon has joined #bundler
patcon has quit [Remote host closed the connection]
patcon has joined #bundler
cha1tanya has quit [Ping timeout: 265 seconds]
cha1tanya has joined #bundler
havenwood has quit [Remote host closed the connection]
havenwood has joined #bundler
cha1tanya has quit [Ping timeout: 272 seconds]
axl_ has quit [Quit: axl_]
patcon has quit [Remote host closed the connection]