waleee-cl has quit [Quit: Connection closed for inactivity]
abc37 has joined #river
abc37 has quit [Client Quit]
leon-p has joined #river
yyp has joined #river
<novakane[m]>
is there a way to make an if loop if it's a debug build or with some flag maybe?
<novakane[m]>
like if (debug) renderer.clear()
<ifreund>
if (std.builtin.mode == .Debug)
<novakane[m]>
thanks
<novakane[m]>
ifreund: if I make something like if (build_options.damage) I can build it with -Ddamage after?
<novakane[m]>
and adding it to build.zig of course
<ifreund>
indeed, though if this is for a damage debugging feature I'd prefer this to be done a different way
<ifreund>
namely, an undocumented command line option that is only available in debug builds
<novakane[m]>
I want to highlight with color what's rendering or not
<ifreund>
yeah that's exactly what I'm talking about
<novakane[m]>
yeah cause right now I comment/uncomment to try, not ideal
<novakane[m]>
I look into a command then
<novakane[m]>
'damage-highlight' sounds good to you?
<ifreund>
`river --highlight-damage`?
<ifreund>
a command line option is what I'm picturing, not something you run through riverctl
<ifreund>
though maybe we should just make this a build option...
<novakane[m]>
well is a command line option is hard to add?
<ifreund>
no, not at all
<novakane[m]>
is that in main.zig?
<ifreund>
it's just the question of whether we care about being able to run with damage highlighting without rebuilding or not
<ifreund>
yep river/main.zig
<ifreund>
if we don't care, then a build option would be better
<novakane[m]>
as you want? personnaly I don't care to rebuild
<novakane[m]>
sway use a build option I think
<ifreund>
nah they have hidden command line options
<emersion>
nah, runtime option
<emersion>
-Ddamage=highlight
<emersion>
we were also too lazy to implement a mode to highlight the damaged regions, and fade-out the highlight
<novakane[m]>
oh ok
<emersion>
the current debug code is a one-line glCLear()
<ifreund>
I think if there's just one on/off debug option the build option is preferable, but if we have multiple different debug options then that could get annoying/unwieldy
<leon-p>
if they default to off it would be fine even with multiple. I can't imagine ever wanting to run with multiple debug options
<ifreund>
let's just do build options for now, we can trivially change this later
<ifreund>
focus on what's actually important
<novakane[m]>
sure no problem
Dedguy21 has joined #river
Dedguy21 has quit [Quit: Connection closed]
yyp has quit [Quit: now it's safe to turn off your computer]
ifreund has quit [Ping timeout: 252 seconds]
jaafarrc has joined #river
<jaafarrc>
I found out why River freezes.
<jaafarrc>
I need to compile River with Xwayland support.
<jaafarrc>
Okay, I didn't find out *why,* but I found out how to mitigate it.
<jaafarrc>
We already know it's because of the damage tracking.
<jaafarrc>
So, yeah, I *think* that fixed it; the last time I compiled River with Xwayland was before I complained about the freezes.
ifreund has joined #river
jaafarrc has quit [*.net *.split]
maringuu has quit [*.net *.split]
maringuu has joined #river
jaafarrc has joined #river
jaafarrc has quit [Quit: leaving]
waleee-cl has joined #river
ifreund has quit [Quit: WeeChat 3.1]
ifreund has joined #river
snakedye has joined #river
yyp has joined #river
yyp_ has joined #river
yyp has quit [*.net *.split]
yyp_ is now known as yyp
snakedye has quit [Quit: Connection closed]
snakedye has joined #river
snakedye has quit [Ping timeout: 240 seconds]
yyp has quit [Ping timeout: 260 seconds]
yyp has joined #river
yyp has quit [Quit: now it's safe to turn off your computer]
leon-p has quit [Remote host closed the connection]