kassens has quit [Read error: Connection reset by peer]
kassens has joined #reasonml
kassens has quit [Ping timeout: 258 seconds]
seangrove has quit [Remote host closed the connection]
pierpa has quit [Ping timeout: 260 seconds]
seangrove has joined #reasonml
jonasen has joined #reasonml
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
Algebr` has joined #reasonml
jonasen has joined #reasonml
copy` has quit [Quit: Connection closed for inactivity]
seangrove has quit [Ping timeout: 240 seconds]
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jonasen has joined #reasonml
iwan_ has joined #reasonml
seangrove has joined #reasonml
seangrove has quit [Ping timeout: 260 seconds]
bsansouci has quit [Remote host closed the connection]
fUD has quit [Remote host closed the connection]
Algebr` has quit [Read error: Connection reset by peer]
Algebr` has joined #reasonml
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
apache2_ has joined #reasonml
chenglou_ has joined #reasonml
jonasen has joined #reasonml
chenglou has quit [Ping timeout: 264 seconds]
apache2 has quit [Ping timeout: 264 seconds]
chenglou_ is now known as chenglou
chenglou has left #reasonml [#reasonml]
chenglou has joined #reasonml
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
bsansouci has joined #reasonml
jonasen has joined #reasonml
fUD has joined #reasonml
jonasen has quit [Client Quit]
<sspi>
yunxing: are you available?
jonasen has joined #reasonml
Algebr` has quit [Ping timeout: 258 seconds]
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jonasen_ has joined #reasonml
jonasen_ has quit [Max SendQ exceeded]
jonasen has joined #reasonml
iwan_ has quit [Ping timeout: 250 seconds]
bsansouci has quit [Remote host closed the connection]
fUD has quit [Remote host closed the connection]
jonasen has quit [Client Quit]
Leonidas has quit [Ping timeout: 260 seconds]
Leonidas has joined #reasonml
jonasen has joined #reasonml
bsansouci has joined #reasonml
mfp_ has quit [*.net *.split]
fUD has joined #reasonml
Leonidas has quit [Ping timeout: 260 seconds]
Leonidas has joined #reasonml
mfp_ has joined #reasonml
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bsansouci>
sspi: Are you still having problems with the PR related to removing "of"?
<sspi>
bsansouci: yeah, I'm working on it now again :)
<sspi>
bsansouci: if you have some good suggestions, I'm all ears
jonasen has joined #reasonml
<bsansouci>
Give me a sec, I just want to check that both `let x = Variant1 bla` and `let x = Functor bla` are valid. If so you should be able to look at what the AST looks like for those two expressions and use the same technique (to resolve ambiguity)
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
jonasen has joined #reasonml
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bsansouci>
sspi: Oh! Actually it's going to be `let module x = Functor bla'` in Reason. That might be how the parser differentiates between the two
seangrove has joined #reasonml
jonasen has joined #reasonml
<sspi>
bsansouci: what I don't get so far is the second part of solving this issue - which is properly fixing the mod_ext_longident part
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bsansouci>
oh yeah
<bsansouci>
Makes sense
<sspi>
so if I change | mod_ext_longident LPAREN mod_ext_longident RPAREN { lapply (Lident($1)) $3 } to | UIDENT LPAREN mod_ext_longident RPAREN { lapply $1 $3 }
<sspi>
it solves several problems, but also seems to introduce new ones
jonasen has joined #reasonml
<bsansouci>
What new problems do you get?
<sspi>
this is now a syntax error: let l : Compose(List)(Maybe)(Char).t = [Some 'a'];
<sspi>
(which makes sense because I just removed that part...)
<bsansouci>
Yeah
<bsansouci>
Because mod_ext_longident can be `mod_ext_longident LPAREN mod_ext_longident RPAREN`
<sspi>
exactly
<bsansouci>
You changed both constr_ident and mod_ext_longident right to be UIDENT right? I think a better way is to unify them under one rule
<bsansouci>
and have that rule branch
<bsansouci>
Mmh that won't help actually lol
jonasen has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
<bsansouci>
You can change the type
<bsansouci>
type_longident to use another version of mod_ext_longident which does have the recursive definition `mod_ext_longident LPARAN mod_ext_longident RPAREN` and then keep the version you have with `UIDENT`. This is in the case where it's not possible to have `let module A = B(C)(D)(E);`
<sspi>
bsansouci: no, doesn't solve it - basically back to the old issue now