avsm changed the topic of #mirage to: mirage 2 released! party on!
dezzy_ has joined #mirage
dezzy has quit [Ping timeout: 252 seconds]
dezzy has joined #mirage
dezzy_ has quit [Ping timeout: 240 seconds]
_whitelogger has joined #mirage
yegods has quit [Remote host closed the connection]
_whitelogger has joined #mirage
<apache2> are these broken? https://github.com/dsheets/ocaml-sodium/
<apache2> whe ncompiling I get:
<apache2> # lib/sodium_stubs.c:6:4: error: ignoring return value of ‘sodium_init’, declared with attribute warn_unused_result [-Werror=unused-result]
<apache2> # sodium_init();
<apache2> # ^~~~~~~~~~~~~
<apache2> # lib/sodium_stubs.c: In function ‘caml__3_sodium_memcmp’:
<apache2> # lib/sodium_stubs.c:21:4: error: ignoring return value of ‘sodium_memcmp’, declared with attribute warn_unused_result [-Werror=unused-result]
<apache2> # sodium_memcmp(x13, x14, x15);
<apache2> value caml__1_sodium_init(value x1)
<apache2> sodium_init();
<apache2> return Val_unit;
<apache2> }
<apache2> {
<apache2> value caml__3_sodium_memcmp(value x12, value x11, value x10)
<apache2> {
<apache2> char* x13 = CTYPES_PTR_OF_OCAML_STRING(x12);
<apache2> char* x14 = CTYPES_PTR_OF_OCAML_STRING(x11);
<apache2> size_t x15 = ctypes_size_t_val(x10);
<apache2> sodium_memcmp(x13, x14, x15);
<apache2> return Val_unit;
<apache2> }
<apache2> but in my local )old_ checkout I get:
<apache2> value caml__1_sodium_init(value x1)
<apache2> return Val_int(x2);
<apache2> {
<apache2> int x2 = sodium_init();
<apache2> }
<apache2> whic seems more correct
andreas23 has joined #mirage
andreas231 has quit [Ping timeout: 244 seconds]
noddy has quit [Ping timeout: 248 seconds]
copy` has quit [Quit: Connection closed for inactivity]
jermar has quit [Read error: Connection reset by peer]
jermar has joined #mirage
fgimenez has joined #mirage
andreas23 has quit [Quit: Leaving.]
AltGr has joined #mirage
<reynir> What version are you compiling?
<reynir> apache2: ^
<reynir> Ah, it seems release 0.5.0 ignores the result
<apache2> sorry, yes, I'm compiling 0.50.0
<apache2> or trying to; it doesn't work :(
andreas23 has joined #mirage
mort___ has joined #mirage
fgimenez has quit [Ping timeout: 260 seconds]
fgimenez has joined #mirage
mort___ has quit [Quit: Leaving.]
<reynir> I'm not sure what you can do... Maybe it's possible to disable -werror=unused-result somehow
jermar has quit [Ping timeout: 250 seconds]
mort___ has joined #mirage
mort___ has quit [Quit: Leaving.]
jermar has joined #mirage
<apache2> maybe they can fix the code :p
<apache2> I'm going to pin to a local copy that has the correct return types
<apache2> when would you ever want to call a function that does a memcmp and throws away the result?
<reynir> heh
<reynir> only case I can htink of is if you want to trigger a page fault in a round about way, maybe :P
mort___ has joined #mirage
fgimenez has quit [Ping timeout: 260 seconds]
fgimenez has joined #mirage
fgimenez has joined #mirage
fgimenez has quit [Changing host]
miragebot has joined #mirage
<miragebot> mirage/master 0ed2dda Anil Madhavapeddy: Define Flow.or_eof as a type alias for the Data|Eof return case
<miragebot> mirage/master d47ba81 Anil Madhavapeddy: Refactor CHANNEL types to be exception-less and use `result`...
miragebot has left #mirage [#mirage]
<miragebot> [mirage] avsm pushed 8 new commits to master: https://git.io/v1UlQ
<miragebot> mirage/master 875824f Anil Madhavapeddy: docs: elaborate on the result type in the V1 ocamloc
jermar has quit [Ping timeout: 250 seconds]
mort___ has quit [Quit: Leaving.]
jermar has joined #mirage
fgimenez has quit [Ping timeout: 246 seconds]
fgimenez has joined #mirage
fgimenez has joined #mirage
fgimenez has quit [Changing host]
fgimenez has quit [Ping timeout: 260 seconds]
fgimenez has joined #mirage
agarwal1975 has joined #mirage
copy` has joined #mirage
agarwal1975 has quit [Quit: agarwal1975]
agarwal1975 has joined #mirage
agarwal1975 has quit [Quit: agarwal1975]
andreas23 has quit [Quit: Leaving.]
yegods has joined #mirage
rgrinberg has joined #mirage
mort___ has joined #mirage
fgimenez has quit []
noddy has joined #mirage
mort___ has quit [Quit: Leaving.]
fgimenez has joined #mirage
fgimenez has joined #mirage
AltGr has left #mirage [#mirage]
fgimenez has quit []
andreas23 has joined #mirage
noddy has quit [Ping timeout: 248 seconds]
twopoint718 has joined #mirage
rgrinberg has quit [Remote host closed the connection]
rgrinberg has joined #mirage
yegods has quit [Remote host closed the connection]
yegods has joined #mirage
yegods has quit []
jermar has quit [Ping timeout: 244 seconds]