bga57 has quit [Quit: Leaving.]
dave____ has joined #jruby
dave____ has quit [Ping timeout: 248 seconds]
bga57 has joined #jruby
dave__ has joined #jruby
dave__ has quit [Ping timeout: 264 seconds]
abe_ has quit [Read error: Connection reset by peer]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 240 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 260 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 248 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 248 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 246 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 240 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 240 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 240 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 248 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 248 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 240 seconds]
<kares> headius: jossl not looking good - there's new hangs on JRuby's test:mri as well as regressions (due user PRs)
<kares> not yet sure what to do - I might not have the time it needs to get it all polished ;( but than revering user contributions also feels weird
<kares> will do my best today and see where I end up
dave__ has joined #jruby
dave__ has quit [Ping timeout: 248 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 248 seconds]
dave__ has joined #jruby
dave__ has quit [Remote host closed the connection]
dave__ has joined #jruby
<GitHub179> [jruby-openssl] kares pushed 3 new commits to master: https://git.io/vFsgG
<GitHub179> jruby-openssl/master dcc9543 kares: let's set the DEFAULT_CONFIG_FILE to nil (just to have constant around)
<GitHub179> jruby-openssl/master b080b73 kares: copy over openssl/config.rb from Ruby 2.3 (to make sure we're in sync)
<GitHub179> jruby-openssl/master acbfa26 kares: setup OpenSSL::ExtConfig emulation - mostly (conservative) guesses
dave__ has quit [Ping timeout: 240 seconds]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 248 seconds]
<GitHub176> jruby-openssl/master 75242d4 kares: at last, do BN comparison `==` vs `eql?` properly - just like MRI version
<GitHub176> [jruby-openssl] kares pushed 3 new commits to master: https://git.io/vFsVR
<GitHub176> jruby-openssl/master 6e213fd kares: get `BN.new("...", 0)` working as OpenSSL does - using MPI format
<GitHub176> jruby-openssl/master 67820b9 kares: [build] we're fine with less jruby (1.7.x) profiles
zacts has quit [Ping timeout: 246 seconds]
dave__ has joined #jruby
dave__ has quit [Remote host closed the connection]
dave__ has joined #jruby
claudiuinberlin has joined #jruby
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
drbobbeaty has joined #jruby
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
vtunka has joined #jruby
claudiuinberlin has joined #jruby
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
vtunka has quit [Quit: Leaving]
dave__ has quit [Remote host closed the connection]
dave__ has joined #jruby
vtunka has joined #jruby
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
claudiuinberlin has joined #jruby
vtunka has quit [Quit: Leaving]
shellac has joined #jruby
vtunka has joined #jruby
shellac has quit [Ping timeout: 240 seconds]
shellac has joined #jruby
dave__ has quit [Remote host closed the connection]
dave__ has joined #jruby
<GitHub17> [jruby-openssl] kares pushed 2 new commits to master: https://git.io/vFsQm
<GitHub17> jruby-openssl/master c1901f2 kares: allow for SSLContext#dup to work (copy-ing Ruby level i-variables only)
<GitHub17> jruby-openssl/master ec7b8e7 kares: [test] include start_server from 2.3 + setup tests as in MRI's repo
drbobbeaty has joined #jruby
vtunka has quit [Quit: Leaving]
dave__ has quit [Remote host closed the connection]
dave__ has joined #jruby
dave__ has quit [Remote host closed the connection]
dave__ has joined #jruby
dave__ has quit [Remote host closed the connection]
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
dave__ has joined #jruby
shellac has quit [Quit: Computer has gone to sleep.]
shellac has joined #jruby
dave__ has quit [Remote host closed the connection]
dave__ has joined #jruby
Antiarc has quit [Remote host closed the connection]
Antiarc has joined #jruby
claudiuinberlin has joined #jruby
lance|afk is now known as lanceball
<headius> kares: ok, keep us posted
<kares> will do - fixed some issues but still not sure about the hang (and had to switch to non-oss work mode)
<kares> are you guys only waiting for jossl with 9.1.14 at this point?
<headius> well most things are ready to go
<headius> I've not found a solution to the cert issue
<kares> yeah that might be a deep diver
<kares> was looking into the verify CB which is setup in Ruby (and is different on JRuby vs MRI) so maybe that might be related?
<headius> CB?
<headius> I'm looking at the verify code, yeah
<headius> I'm trying to confirm how the chain verification decides to stop digging
<headius> the google cert is issued by geotrust, which should be a CA, so stop digging there?
<headius> but it doesn't, it looks for geotrust issuer which is the bad equifax cert
<headius> I'm also trying to understand why we have this logic in the first place
<headius> shouldn't this be built into X.509 logic already?
<kares> ah right sorry - yeah this should be all underneath the surface - the Ruby part should not be involved
<kares> but just to be sure I'll give it a try ...
<headius> I'm looking at StoreContext.verifyCertificate
<headius> it builds the chain and then verifies it...it's just weird that this code has to be hand-written
vtunka has joined #jruby
<kares> has to since user might hand set verification - so we need to bypass JSSE
<kares> (I mean bypass its defaults)
<kares> in the past I was thinking about providing a Java only default that would ignore all user settings
<kares> UPDATE: for my ubuntu with the same ca-certificates packages it seems to work
<kares> or I am doing smt wrong :(
shellac has quit [Read error: Connection reset by peer]
<headius> really?
<headius> kares: where is the logic that determines how/where we lookup certs?
<headius> I just don't understand where this cert is coming from
<headius> kares: this is baffling
<headius> I don't understand where this Equifax is coming from
<kares> headius: honestly I'm not sure I can point you to an exact place, net/http sets store etc which than gets looked-up
<kares> are you testing that net/http code only or were you able to minimize the reproducer?
<headius> still going through that net/http code
<headius> but I straced and only saw it access the java keystore
<headius> that's a good point though
vtunka has quit [Quit: Leaving]
<GitHub105> [jruby] saxenadeepakkumar opened issue #4836: Getting error while giving fully qualified path to parse file with yard-cucumber https://git.io/vFGl4
<GitHub59> [jruby-openssl] kares pushed 1 new commit to master: https://git.io/vFGBp
<GitHub59> jruby-openssl/master 2ced388 kares: fix signature-alg to default to NULL and report it as 0.0 (like MRI)
<headius> aaargh
<kares> ok so the hang from the CI suite seems to not want to reproduce locally and I already tried giving it slightly more memozy on CI
<kares> this is what I meant previously - having different verify_certificate_identity hack then MRI in .rb parts
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
claudiuinberlin has joined #jruby
<headius> kares: I'm not sure that code is coming into play here
<kares> yeah pbly not but I would make sure it isn't
<kares> on MRI it definitely isn't triggered - so it should not happen
<kares> (at least it seems so if I'm checking right locally)
lanceball is now known as lance|afk
<headius> I've been stepping through the java verification logic we have but it seems like we're already wrong by then
<headius> with that equifax bit getting in there
<headius> I'm trying to trace backward now to figure out where it's coming from
<kares> kk - I am confused because I'm not reproducing as on the issue :(
<kares> and I noticed this is behaving seemingly differently compared to MRI
<headius> what output do you get from -Djavax.net.debug=all
dave__ has quit [Remote host closed the connection]
<headius> so I can see that the keystore brought into memory *does* have the proper GeoTrust self-signed root cert
<headius> the chain it builds with the Equifax issuer seems to be coming from the connection?
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<kares> google.com or apple.com?
claudiuinberlin has joined #jruby
<headius> I've been trying google.com
<headius> Equifax appears to be in the data read from the connection during handshake
<travis-ci> kares/jruby-openssl (master:059fae0 by kares): The build was broken. (https://travis-ci.org/kares/jruby-openssl/builds/296336249)
<headius> kares: you seem to still have equifax in your trust store: https://gist.github.com/kares/5721047063f8b8218cad19033af516f2#file-script-out-L73
<headius> you are getting the bad cert from network too: https://gist.github.com/kares/5721047063f8b8218cad19033af516f2#file-script-out-L1180
<kares> hmm
<kares> but why isn't it failing with an OpenSSL error
<headius> because you have equifax in your store
<headius> I do not
<headius> I posted a pretty bogus patch that fixes it based on my findings
<headius> bottom line is that yes, the cert on the wire is incorrect, and we're supposed to trust the local version of it in that case
claudiuinberlin has quit [Quit: Textual IRC Client: www.textualapp.com]
<kares> ok so my ca-certificate updates didn't get through properly than
<kares> oh smash - so maybe its not jossl after-all https://travis-ci.org/jruby/jruby/builds/295808759
<kares> the previous jruby-9.1 build also failed
<kares> have checked that is green and than pull-ed and updated jossl
<kares> but seems that it wasn't the green build I thought ... brr
<kares> which would have been this one: https://travis-ci.org/jruby/jruby/builds/295513427
<headius> what's that hanging on? some HTTP test?
<headius> I think I noticed that start failing the other day, but I did not see any relevant commits that would explain it :-(
<kares> seems so (at least that is the last output) - that is what confused me
<headius> hmm ok
<headius> I could not get it to hang locally on macos but I have not tried locally on linux
<kares> so I'll take HEAD^ as a base and see if test:mri passes with new jossl
<headius> ok
<kares> if so than I guess release, right?
<kares> or should I wait?
<kares> I somehow got too many failures locally running the whole suite
shellac has joined #jruby
<headius> kares: hold off for the moment
<headius> I'd like to come up with a fix for this
lance|afk is now known as lanceball
dave__ has joined #jruby
<kares> key - I'll see how it goes - but I'll wait for your confirmation for the release
<kares> might not be here today (getting late) but I'll catch up tomorrow
dave__ has quit [Ping timeout: 258 seconds]
dave__ has joined #jruby
<GitHub111> [jruby-openssl] headius created prefer_trust_certs_4802 (+1 new commit): https://git.io/vFGxQ
<GitHub111> jruby-openssl/prefer_trust_certs_4802 affc285 Charles Oliver Nutter: Replace incoming certs with newer versions from trust store....
claudiuinberlin has joined #jruby
<GitHub119> [jruby-openssl] headius opened pull request #149: Replace incoming certs with newer versions from trust store. (master...prefer_trust_certs_4802) https://git.io/vFGxN
dave__ has quit [Ping timeout: 248 seconds]
<headius> @kares ^
<headius> the logic doesn't match OpenSSL exactly but this should be equivalent
<headius> build_chain in OpenSSL's X509_vfy.c
<headius> this isn't super efficient either
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
claudiuinberlin has joined #jruby
shellac has quit [Quit: Computer has gone to sleep.]
<travis-ci> kares/jruby-openssl (master:ddf9724 by kares): The build was fixed. (https://travis-ci.org/kares/jruby-openssl/builds/296367604)
<travis-ci> jruby/jruby-openssl (prefer_trust_certs_4802:affc285 by Charles Oliver Nutter): The build failed. (https://travis-ci.org/jruby/jruby-openssl/builds/296406337)
subbu is now known as subbu|lunch
subbu|lunch is now known as lunch|subbu
dave__ has joined #jruby
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
dave__ has quit [Ping timeout: 258 seconds]
claudiuinberlin has joined #jruby
lunch|subbu is now known as subbu
TheHurley3 has joined #jruby
<GitHub121> [jruby-openssl] headius pushed 1 new commit to prefer_trust_certs_4802: https://git.io/vFZIV
<GitHub121> jruby-openssl/prefer_trust_certs_4802 80f4b85 Charles Oliver Nutter: Try to compare certs before replacement.
Specialist has joined #jruby
<travis-ci> jruby/jruby-openssl (prefer_trust_certs_4802:80f4b85 by Charles Oliver Nutter): The build was fixed. (https://travis-ci.org/jruby/jruby-openssl/builds/296437894)
dave____ has joined #jruby
dave____ has quit [Ping timeout: 248 seconds]
Specialist has quit [Remote host closed the connection]
TheHurley3 has quit [Quit: Leaving]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 258 seconds]
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
klemanski has joined #jruby
klemanski has quit [Client Quit]
dave__ has joined #jruby
dave__ has quit [Ping timeout: 264 seconds]
bbrowning is now known as bbrowning_away
claudiuinberlin has quit [Quit: Textual IRC Client: www.textualapp.com]
shellac has joined #jruby
shellac has quit [Ping timeout: 248 seconds]
drbobbeaty has joined #jruby
shellac has joined #jruby
shellac has quit [Quit: Computer has gone to sleep.]
dave__ has joined #jruby
mbj has joined #jruby
dave__ has quit [Ping timeout: 248 seconds]
mbj has quit [Quit: leaving]
dave__ has joined #jruby