00:56
swills has quit [Remote host closed the connection]
01:49
bga57 has joined #jruby
02:58
_whitelogger has joined #jruby
06:07
<
GitHub146 >
jruby-openssl/master 89e9e18 kares: [travis-ci] setup some tests with JDK 9 + adjust allowe failures
06:07
<
GitHub146 >
jruby-openssl/master 66b4da3 kares: [refactor] work-around on BN#to_s impl which has been due JRuby 1.6
06:08
damnski has quit [Ping timeout: 246 seconds]
06:21
<
kares >
headius: jossl seems good to go however that PKCS#12 failure we're seeing on JRuby's CI seems at least interesting
06:21
<
kares >
would like to find some time to investigate - but I am not sure how this week will go ... yet
06:21
olle has joined #jruby
06:22
<
kares >
also some folks reached out due AR-JDBC 5.x ...
06:23
<
kares >
maybe this one will go through and I will be able to make plans to work a week or two exclusively on finishing up 5 support, we'll see
06:23
olle has quit [Client Quit]
06:45
nirvdrum has quit [Ping timeout: 264 seconds]
06:47
scgdzhaszh has joined #jruby
06:47
scgdzhaszh has quit [Remote host closed the connection]
07:46
olle has joined #jruby
08:12
<
GitHub116 >
jruby-openssl/master 1ace795 kares: [travis-ci] let's try some more (integration) Java 9 testing
09:04
vtunka has joined #jruby
09:13
claudiuinberlin has joined #jruby
09:22
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
10:15
vtunka has quit [Quit: Leaving]
10:39
vtunka has joined #jruby
11:11
damnski has joined #jruby
11:16
drbobbeaty has joined #jruby
12:28
drbobbeaty has quit [Ping timeout: 248 seconds]
12:45
lance|afk is now known as lanceball
12:56
vtunka has quit [Quit: Leaving]
13:40
<
headius >
kares: yeah I haven't started looking into the pkcs12 error yet
13:40
<
headius >
enebo knows status of AR-JDBC for 5, I think he was hoping to release something soon
13:43
<
headius >
no wonder that test just up and started failing
13:48
<
GitHub7 >
jruby/jruby-9.1 f6fd6e7 Charles Oliver Nutter: Disable this test on Travis, which has no IP6 now....
13:48
<
GitHub7 >
jruby/jruby-9.1 a1beea2 Charles Oliver Nutter: Sync this code up with master.
13:52
danielg__ has joined #jruby
14:00
vtunka has joined #jruby
14:17
swills has joined #jruby
14:17
swills has joined #jruby
14:30
bga57 has quit [Ping timeout: 255 seconds]
14:34
bga57 has joined #jruby
14:37
drbobbeaty has joined #jruby
14:38
vtunka has quit [Quit: Leaving]
14:39
<
GitHub113 >
jruby/master 0b72b03 Charles Oliver Nutter: Merge branch 'jruby-9.1'
14:58
<
GitHub30 >
jruby/master e2669a6 Thomas E. Enebo: Basic constant assign specs for &&=
14:58
vtunka has joined #jruby
15:01
<
GitHub188 >
[jruby] headius closed issue #4801: "gem install bundler" times out instead of installing normally
https://git.io/vdnBp
15:17
shellac has joined #jruby
15:20
danielg__ has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:21
danielgl_ has joined #jruby
15:21
danielgl_ has quit [Client Quit]
15:23
danielgl_ has joined #jruby
15:23
danielgl_ has quit [Client Quit]
15:25
<
olle >
Hello! I'm trying real hard to learn about the "Config.USE_UNICODE_PROPERTIES" used in Joni.
15:25
<
olle >
Can I... enable that, in some way?
15:27
danielgl_ has joined #jruby
15:27
danielgl_ has quit [Client Quit]
15:28
danielgl_ has joined #jruby
15:28
danielgl_ has quit [Client Quit]
15:28
<
olle >
yokolet and lopex seems to be the two people on the Web who've discussed this, at all.
15:30
<
olle >
(Sorry, jcodings, would be where USE_UNICODE_PROPERTIES would be defined. And set to true)
15:30
danielgl_ has joined #jruby
15:31
danielgl_ has quit [Client Quit]
15:33
danielgl_ has joined #jruby
15:33
danielgl_ has quit [Client Quit]
15:35
<
headius >
olle: hello there
15:35
<
headius >
olle: is it not working?
15:35
<
olle >
It ain't working for me, at least. MRI Ruby 2.4.0 works, while JRuby 9.1.13.0 does not work.
15:36
<
olle >
I should offer a description of what my issue is.
15:39
<
headius >
heh yeah that doesn't look right
15:39
<
olle >
Swedish letters have a hard time being picked up as "full graphemes"
15:39
<
headius >
yeah I wonder if this is related to unicode updates MRI did when they forked oniguruma to "onigmo"
15:39
<
headius >
lopex: maybe?
15:40
<
headius >
the unicode_normalize code is also pretty dense if I remember right
15:40
<
headius >
olle: smallest repro possible would help
15:40
<
headius >
mmm unicode_normalize output
*seems* ok
15:41
danielgl_ has joined #jruby
15:41
danielgl_ has quit [Client Quit]
15:41
<
headius >
olle: so I guess that's why you figured this is a regexp issue
15:41
<
olle >
headius: Trying to get to a composed character to share a unicode_normalize-less example. Thinking.
15:41
danielgl_ has joined #jruby
15:42
danielgl_ has quit [Client Quit]
15:42
<
headius >
without u_n it scans properly
15:43
<
headius >
so maybe it IS a problem with u_n
15:43
<
headius >
so u_n would normalize to a standard form, probably the expanded form that uses composition
15:43
<
headius >
scan then might be failing to pick up composed characters
15:44
<
headius >
irb(main):005:0> 'åäöÅÄÖ'.unicode_normalize(:nfd).bytes
15:44
<
headius >
=> [97, 204, 138, 97, 204, 136, 111, 204, 136, 65, 204, 138, 65, 204, 136, 79, 204, 136]
15:44
<
headius >
irb(main):006:0> 'åäöÅÄÖ'.bytes
15:44
<
headius >
=> [195, 165, 195, 164, 195, 182, 195, 133, 195, 132, 195, 150]
15:44
<
headius >
97 is 'a' so yeah, that appears to be what's happening
15:45
<
headius >
I'd wager u_n is fine here but scan is missing logic to pick up composed characters
15:45
<
olle >
Yes, u_n returns the same on MRI and JRuby.
15:46
<
olle >
But for some reason all the "modifiers" get dropped in the /\X/ regexp match.
15:47
<
olle >
(modifier, in this case: the circle above the "a")
15:51
<
GitHub117 >
jruby/master e701f62 Thomas E. Enebo: Fixes #4792. Unhandled Java exception in Ripper on inline comments....
15:51
<
GitHub192 >
[jruby] enebo closed issue #4792: Unhandled Java exception in Ripper on inline comments
https://git.io/v5heU
15:51
<
GitHub83 >
jruby/jruby-9.1 eb1151a Thomas E. Enebo: Fixes #4792. Unhandled Java exception in Ripper on inline comments....
15:53
<
headius >
olle: well you may be right that the unicode mode isn't working right
15:54
<
headius >
it does seem odd to me that \X could be this broken
15:57
<
headius >
olle: I'd start by comparing our scan logic with MRI's, but I'm leaning toward a joni issue too
15:59
<
headius >
[--dev] ~/projects/jruby $ /usr/bin/ruby -e "p 'åäöÅÄÖ'.unicode_normalize(:nfd).match /(\X)/"
15:59
<
headius >
#<MatchData "å" 1:"å">
15:59
<
headius >
[--dev] ~/projects/jruby $ jruby -e "p 'åäöÅÄÖ'.unicode_normalize(:nfd).match /(\X)/"
15:59
<
headius >
#<MatchData "a" 1:"a">
16:01
<
headius >
olle: if this doesn't have an issue already, open one
16:02
<
olle >
headius: a joni issue, right?
16:03
<
headius >
file it with JRuby for now
16:03
<
headius >
it's likely a joni issue but we'll file that when we know for sure, plus there will be testing work to do on JRuby side
16:09
<
GitHub86 >
[jruby] olleolleolle opened issue #4832: Modifiers are dropped in \X regular expression matches
https://git.io/vFt5A
16:12
<
GitHub43 >
jruby/jruby-9.1 6e2088a Dennis Marinus: switch ShellLauncher to use getAbsolutePath
16:12
<
olle >
I hope the title of that is legible, it may be only me in the whole world who calls those compound codepoints "modifiers".
16:12
<
GitHub196 >
jruby/master d2c3370 Charles Oliver Nutter: Merge branch 'jruby-9.1'
16:13
<
GitHub16 >
[jruby] headius closed pull request #4821: switch ShellLauncher to use getAbsolutePath (master...canonical-to-absolute)
https://git.io/vd9hW
16:13
<
headius >
olle: I can never remember the right terminology
16:14
<
headius >
"combining characters" I guess
16:15
<
headius >
reading about it now since I don't know how it's supposed to know to keep going after seeing 97
16:16
<
GitHub77 >
jruby/jruby-9.1 2d078e3 Thomas E. Enebo: Fixes #4787 Ripper fails to lexical analyse around escaped newline on JRuby....
16:16
<
GitHub155 >
jruby/master 3b6f308 Thomas E. Enebo: Fixes #4787 Ripper fails to lexical analyse around escaped newline on JRuby....
16:16
<
GitHub198 >
[jruby] enebo closed issue #4787: Ripper fails to lexical analyse around escaped newline on JRuby
https://git.io/v5i1d
16:17
<
headius >
I'll move my comments to the bug
16:20
vtunka has quit [Quit: Leaving]
16:21
enebo has joined #jruby
16:26
<
lopex >
olle: USE_UNICODE_PROPERTIES is on by default
16:27
<
olle >
lopex: Thanks for answering. It was there, in the jencodings library, set to a final field with "true".
16:29
<
lopex >
olle: yeah, that's recent changes wrt grapheme clusters in 2.4
16:32
<
headius >
lopex: ahh right, that's the grapheme stuff
16:33
<
headius >
lopex: but on my system MRI 2.3 works properly too
16:33
<
lopex >
I've got how it works though
16:33
<
lopex >
2.3 is since ?
16:33
<
headius >
perhaps it was backported? my system is using 2.3.3
16:34
<
lopex >
the newer one is completely rewritten
16:35
<
lopex >
that's theire first commit related to that
16:36
<
headius >
heh yeah, bit of work
16:36
<
headius >
maybe we can get chrisseaton's team to do it :-D
16:36
<
lopex >
it's not that bad
16:37
<
lopex >
headius: 90% of that code is that regexp expansion by hand
16:37
<
lopex >
case map is worse :P
16:45
olle has left #jruby [#jruby]
16:45
olle has joined #jruby
16:48
<
headius >
lopex: 2.2.7 also works properly so this must be older
16:58
<
lopex >
2.2.7 is march 17
16:59
<
headius >
so they are backporting this
17:02
<
lopex >
"backporting" by crosscommiting
17:03
<
lopex >
they essentially cross-merge
17:22
olle has quit [Quit: olle]
17:34
<
kares >
headius: nope but I think it should go away with a JDK 8 update
17:37
<
headius >
kares: that's what I'm suspecting too
17:38
<
headius >
the debug output seems to show a GeoTrust cert issued by Equifax, which is causing the verification failure on Ubuntu
17:39
<
kares >
well, we can't control the built SSL engine completely ... do you happen to have latest Java 8?
17:39
<
kares >
should be 152 report was for 131 or so
17:39
<
headius >
well I confirmed the bug with the same latest jdk8 on ubuntu
17:40
<
headius >
I'm trying newer jdk on same ubuntu now
17:40
<
kares >
ok I wonder if it goes away if not its worth looking into deeper ...
17:41
<
headius >
still fails on 151
17:43
<
kares >
;( ... that lookup path of jossl is not the cleanest piece of logic although it worked so far
17:44
<
kares >
might take a look at some point later but I was planning on looking on that Java 9 'boot' PKCS#12 failure
17:45
<
headius >
well I'm stumped but I posted my findings
17:45
<
headius >
it seems like we're doing the right thing, verification wise, but somehow getting a GeoTrust cert that's issued by Equifax
18:48
subbu is now known as subbu|lunch
19:01
<
GitHub48 >
[jruby] MrBerg opened pull request #4833: Added specs for IO#each(sep,limit) (master...io-each-separator-and-limit-specs)
https://git.io/vFqZe
19:04
eregon_ has joined #jruby
19:07
<
GitHub180 >
jruby/master 1d47d52 Jonas Berg: Make BigDecimal::limit work for subtraction and division. Fix issue #1615.
19:07
<
GitHub180 >
jruby/master eba3bf5 Jonas Berg: Use instanceof
19:07
<
GitHub180 >
jruby/master 850a14b Charles Oliver Nutter: Merge pull request #4830 from MrBerg/enforce-bigdecimal-limit...
19:07
<
GitHub63 >
[jruby] headius closed pull request #4830: Make BigDecimal::limit work for subtraction and division. Fix issue #1615 (master...enforce-bigdecimal-limit)
https://git.io/vFT0M
19:20
<
eregon_ >
headius: Hi
19:21
<
headius >
eregon_: hello there!
19:21
<
GitHub85 >
jruby/jruby-9.1 28eb942 Jonas Berg: Use instanceof
19:21
<
GitHub85 >
jruby/jruby-9.1 f386054 kares: cleanup BigDecimal from the dual 1.8/1.9 Ruby support heritage...
19:21
<
GitHub85 >
jruby/jruby-9.1 dc7b498 Jonas Berg: Make BigDecimal::limit work for subtraction and division. Fix issue #1615.
19:21
<
eregon_ >
headius: Could you make a PR with the changes for Date? Then I should be able to take a look at the other bug
19:22
<
headius >
yeah sure
19:22
<
headius >
are you sure MRI/unix time is using GJ and not ISO?
19:22
<
eregon_ >
Time is ISO
19:22
<
eregon_ >
but Date is GJ
19:22
<
headius >
that seems to match what we have
19:23
<
eregon_ >
However Time#to_date creates a Date with GJ I think
19:23
<
eregon_ >
So if you did (time.to_date+1000 days).to_time might be different than time+1000days since they use different chronologies
19:24
<
eregon_ >
DateTime#to_time magically using the local timezone is not helping this, 2.4 is much saner in this regard
19:24
<
eregon_ >
There is no guarantee it round-trips in the bug report due to changing timezones
19:25
shellac has quit [Ping timeout: 240 seconds]
19:26
<
eregon_ >
Well, at least their DateTime#ajd match in this case
19:27
<
headius >
I guess what confuses me is that if I change date.rb to use ISO instead of GJ it matches MRI then
19:29
subbu|lunch is now known as subbu
19:32
<
GitHub156 >
jruby/master 854d7eb Charles Oliver Nutter: Merge branch 'jruby-9.1'
19:32
<
GitHub140 >
jruby/jruby-9.1 31f25a9 Charles Oliver Nutter: Remove line removed on master.
19:33
<
headius >
kares: you could cherrypick some of those other BigDecimal tweaks from master to 9.1
19:41
<
GitHub18 >
jruby/master c3b71d5 Charles Oliver Nutter: Merge branch 'jruby-9.1'
19:44
<
GitHub187 >
jruby/master 9d7737c Thomas E. Enebo: Whoops...2.4 ripper seems to have changed since we made jruby-9.1? Trivial...
19:53
<
GitHub127 >
jruby/master 510e937 Charles Oliver Nutter: Replace Fixnum with Integer to eliminate warnings.
19:54
eregon_ has quit [Ping timeout: 240 seconds]
20:18
<
GitHub33 >
jruby/jruby-9.1 10d6654 Thomas E. Enebo: Fix errors from my &&= and ||= work. I should have defaulted all other const...
20:18
<
GitHub73 >
jruby/master 94484f7 Thomas E. Enebo: Fix errors from my &&= and ||= work. I should have defaulted all other const...
20:33
eregon_ has joined #jruby
21:40
Puffball has quit [Remote host closed the connection]
21:42
Puffball has joined #jruby
21:46
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
21:51
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:52
claudiuinberlin has joined #jruby
22:18
eregon_ has quit [Quit: Leaving]