<GitHub167>
[jruby] headius pushed 1 new commit to ruby-2.4: https://git.io/v78L5
<GitHub167>
jruby/ruby-2.4 2c3652a Charles Oliver Nutter: Fix Float rounding to use all double.
<GitHub174>
[jruby] headius opened issue #4727: Array#pack buffer should start from beginning of buffer? https://git.io/v78qa
_whitelogger has joined #jruby
<GitHub145>
[jruby] headius pushed 5 new commits to ruby-2.4: https://git.io/v78Yn
<GitHub145>
jruby/ruby-2.4 a9cbc06 Charles Oliver Nutter: Align buffer argument logic with MRI....
<GitHub145>
jruby/ruby-2.4 6d289a2 Charles Oliver Nutter: Tag remaining Pack buffer logic (#4727).
<GitHub145>
jruby/ruby-2.4 d306ba2 Charles Oliver Nutter: Add modification checks to two append methods.
<GitHub37>
[jruby] headius pushed 2 new commits to ruby-2.4: https://git.io/v78YE
<GitHub37>
jruby/ruby-2.4 4368789 Charles Oliver Nutter: Tag minor hash/array/string coercion error test.
<GitHub37>
jruby/ruby-2.4 55d2e34 Charles Oliver Nutter: Tag some minor parser failures.
GK1wmSU has joined #jruby
GK1wmSU has left #jruby [#jruby]
_GK1wmSU has joined #jruby
_GK1wmSU has left #jruby [#jruby]
<GitHub12>
[jruby] jsyeo opened issue #4728: Parser does not seem to terminate when parsing this string https://git.io/v78Oa
prasun has joined #jruby
Specialist has joined #jruby
shellac_ has joined #jruby
Puffball has quit [Remote host closed the connection]
Puffball has joined #jruby
shellac_ has quit [Quit: Computer has gone to sleep.]
vtunka has joined #jruby
<kares>
kitallis: yes you can
<kares>
as for analysis its always a bit app dependent - not much one can tell from a memory graph :)
<GitHub86>
[jruby] olleolleolle opened issue #4729: KeyError message renders String keys as Symbols https://git.io/v788s
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
olle has joined #jruby
vtunka has quit [Ping timeout: 255 seconds]
vtunka has joined #jruby
olle has quit [Ping timeout: 255 seconds]
vtunka_ has joined #jruby
vtunka_ has quit [Quit: Leaving]
olle has joined #jruby
olle_ has joined #jruby
olle has quit [Ping timeout: 255 seconds]
olle_ is now known as olle
drbobbeaty has joined #jruby
bbrowning_away is now known as bbrowning
jensnockert has joined #jruby
<jensnockert>
I have built a JRuby from source, but I get `LoadError: library `java' could not be loaded: java.lang.NoSuchFieldError: methods`, is this something anyone recognises?
<jensnockert>
This is on OS X.
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
drbobbeaty has joined #jruby
vtunka has quit [Ping timeout: 248 seconds]
Specialist has quit [Remote host closed the connection]
Specialist has joined #jruby
vtunka has joined #jruby
jensnockert has quit [Remote host closed the connection]
jensnockert has joined #jruby
Specialist has quit [Remote host closed the connection]
vtunka has quit [Quit: Leaving]
vtunka has joined #jruby
lance|afk is now known as lanceball
vtunka has quit [Ping timeout: 255 seconds]
vtunka has joined #jruby
subbu is now known as subbu|afk
olle has quit [Ping timeout: 240 seconds]
vtunka has quit [Quit: Leaving]
subbu|afk is now known as subbu
<enebo>
jensnockert: was that with a 'mvn clean' first? Perhaps some incremental build issue?
<enebo>
lopex: I use a joni regexp in LexingCommon.java to process comment lines
<headius>
jensnockert: definitely looks like a dirty build
<headius>
if it's not that we can dig deeper
olle has joined #jruby
<jensnockert>
headius: It was from a clean checkout, but I'll try.
<headius>
jensnockert: ok
<headius>
NoSuchFieldError should not happen at runtime if everything compiles properly
<headius>
the reflection error is different
<headius>
so seeing that would either mean a bad build or some bad bytecode got loaded (certainly possible in the JIT)
<headius>
or a third-party library references a field we deleted, and we'd want to address that
<jensnockert>
Oh, that worked, thanks.
<jensnockert>
No idea what happened.
<jensnockert>
I had the wrong Maven installed first, could have been something with that.
* jensnockert
hugs > Thank you both!
<headius>
jensnockert: ok good to hear!
<headius>
lopex: hey I am confused
<headius>
our UTF8 mbclen doesn't match MRI
<headius>
they don't have any cases that will return 5 or 6 for length
<GitHub104>
[jruby] rawrasaur opened pull request #4730: Fix error message in Hash#fetch (master...fix-hash-fetch-error-message) https://git.io/v74cy
jensnock_ has joined #jruby
<lopex>
headius: yeah, I believe 4 is max for utf-8 now
<headius>
ok, then this fix should be fine
<headius>
I'm also removing the exception throw from UTF8Encoding
<headius>
most encodings don't throw an exception, even for invalid codepoints
<headius>
and the return codes are different for different errors
<headius>
I'll have to audit places we call it to make sure they're checking return code but they should have been before
jensnockert has quit [Ping timeout: 246 seconds]
jensnock_ has quit [Ping timeout: 260 seconds]
<headius>
huh, looking like UTF8 was the *only* place that raised
GitHub51 has joined #jruby
GitHub51 has left #jruby [#jruby]
<GitHub51>
jcodings/master 63e8de6 Charles Oliver Nutter: Updated UTF8 length calculation, sans exception throwing now.
<GitHub51>
[jcodings] headius pushed 1 new commit to master: https://git.io/v74lv
GitHub145 has joined #jruby
GitHub145 has left #jruby [#jruby]
<GitHub145>
jcodings/master 8e9122e Charles Oliver Nutter: [maven-release-plugin] prepare release jcodings-1.0.21
<GitHub145>
[jcodings] headius pushed 1 new commit to master: https://git.io/v74lM
GitHub135 has joined #jruby
GitHub135 has left #jruby [#jruby]
<GitHub135>
jcodings/master 93ac88e Charles Oliver Nutter: [maven-release-plugin] prepare for next development iteration
<GitHub135>
[jcodings] headius pushed 1 new commit to master: https://git.io/v74ly
GitHub164 has joined #jruby
GitHub164 has left #jruby [#jruby]
<GitHub164>
[jcodings] headius tagged jcodings-1.0.21 at 25a5692: https://git.io/v74lD
olle has quit [Quit: olle]
<lopex>
enebo: they seem to no longer use regexp there
<enebo>
lopex: MRI? They never did
<enebo>
lopex: They had one in the comments but had some icky C
<lopex>
enebo: also that commented regexp seems differ from that in lexer
<enebo>
lopex: it may be? I think nirvdrum actually wrote an simple single-scan to eliminate calling this regexp unless it partially matched something
<enebo>
so most comments would look for something significant like a : and then call the regexp...in this case though it would still trigger the regexp
<lopex>
enebo: tried to reduce that case, but it took quite long to match
<enebo>
lopex: I guess the question is whether perhaps I should make a manual routine like MRI or just fix the pathological case of the regexp
<lopex>
enebo: would help parse time
<enebo>
lopex: maybe
<lopex>
enebo: a bit shorter version of that comment actually completes
<lopex>
but after a qhile
<lopex>
*while
<enebo>
lopex: I guess I believe in measure first but in this case if the benchmark is this comment line then it obviously is expensive :)
<lopex>
enebo: and who knows what comments are out there
<enebo>
lopex: yeah so we need to deal with the pathology of the regexp but that does not mean we cannot use a regexp
<enebo>
lopex: although not using a regexp may be the right thing
<enebo>
hmmm going to make a "bison" burger...we will see how that goes
<lopex>
yeah, that c seems overengineered
<headius>
lopex: another issue I see
<headius>
all our codepoint logic only takes int, but in MRI it takes unsigned int
<lopex>
yes
<headius>
I can fix this particular case on the Ruby side by checking range but this is a one off fix
<lopex>
which one ?
<lopex>
I think it would be insane to use longs everywhere
<lopex>
headius: just mask it with & 0xffffffffL
<headius>
I'll try that for this case
<headius>
damn Java signed primitives
GitHub137 has joined #jruby
GitHub137 has left #jruby [#jruby]
<GitHub137>
jcodings/master 612c6b5 Charles Oliver Nutter: Mask codepoint to long to emulate uint....
<GitHub137>
[jcodings] headius pushed 1 new commit to master: https://git.io/v74Bo
<headius>
lopex: that seems good enough for this case
GitHub125 has joined #jruby
<GitHub118>
[jcodings] headius tagged jcodings-1.0.22 at a462fb4: https://git.io/v74By
GitHub118 has left #jruby [#jruby]
GitHub118 has joined #jruby
GitHub125 has left #jruby [#jruby]
<GitHub125>
jcodings/master da3b793 Charles Oliver Nutter: [maven-release-plugin] prepare release jcodings-1.0.22
<GitHub125>
[jcodings] headius pushed 1 new commit to master: https://git.io/v74BD
GitHub190 has joined #jruby
GitHub190 has left #jruby [#jruby]
<GitHub190>
jcodings/master babe573 Charles Oliver Nutter: [maven-release-plugin] prepare for next development iteration
<GitHub190>
[jcodings] headius pushed 1 new commit to master: https://git.io/v74BS
<headius>
babe573, nice
<lopex>
573 is a hotel room number ?
<headius>
ha
<headius>
ok, nearly there
<GitHub76>
[jruby] headius pushed 9 new commits to ruby-2.4: https://git.io/v740m
<GitHub76>
jruby/ruby-2.4 bc2ba39 Charles Oliver Nutter: [2.4] sprintf now rounds half to even....
<GitHub76>
jruby/ruby-2.4 5e96dc7 Charles Oliver Nutter: Raise error for uninitialized MatchData in values_at.
<GitHub76>
jruby/ruby-2.4 2d650ff Charles Oliver Nutter: Provide actual file and line for parser "= in cond" warning.
jensnockert has joined #jruby
shellac_ has joined #jruby
jensnockert has quit [Ping timeout: 240 seconds]
<GitHub183>
[jruby] headius pushed 1 new commit to ruby-2.4: https://git.io/v74gA
<GitHub183>
jruby/ruby-2.4 ac5b4c8 Charles Oliver Nutter: Update to invokebinder with Java 9 tryFinally support.
shellac_ has quit [Quit: Computer has gone to sleep.]
subbu is now known as subbu|lunch
jensnockert has joined #jruby
jensnockert has quit []
subbu|lunch is now known as subbu
prasun has quit [Remote host closed the connection]
shellac_ has joined #jruby
rawra has joined #jruby
swills has quit [Remote host closed the connection]
shellac_ has quit [Quit: Computer has gone to sleep.]
swills has joined #jruby
subbu is now known as subbu|afk
subbu|afk is now known as subbu
<GitHub35>
[jruby] headius pushed 1 new commit to ruby-2.4: https://git.io/v74Ff
<GitHub35>
jruby/ruby-2.4 d020f6f Charles Oliver Nutter: Set final length of string, since we write straight into byte[].
<headius>
ugh.
<headius>
eregon: hey, is there something in mspec or in TR's spec setup for timing slow specs?
<headius>
I think I need to boot a few more items out of our "fast" run
<headius>
seems like a ton of subprocess specs got added to net/http specs or something
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
<nirvdrum>
I forgot to start-up my bouncer after losing power last week. Apologies if anyone was trying to ping me.
<rawra>
Travis of course can't show logs that long :/
<enebo>
rawra: you can click on 'Raw log' at top of log to get the full one
<enebo>
rawra: I restarted spec:ruby:fast since it seems to have gotten stuck on something which seems very unlikely to be your fix
<enebo>
-Ptest is definitely not your fault...not sure why that is failing on master
<rawra>
Okay, that would explain both failures.
<headius>
our travis is unfortunately a little flaky because there are a few tests that either use real clock timing or that have unfixed race conditions (in the test itself)
<headius>
we try to improve that over time
<rawra>
It's okay, just wasn't sure if it was on my end or not.
<nirvdrum>
headius: Aww, shucks.
<headius>
lopex: I'm killing all places that throw EncodingException where MRI does a return code
<headius>
it's half and half right now and almost all the logic we wrap around jcodings wants the return codes
<headius>
EncodingException doesn't even bring the code with
<headius>
so I'm fixing that too
<headius>
well, actually I just added an enum combining error message and code, but since the exception won't be used this is just the new way
<lopex>
headius: I think in might be some remnant after splitting joni and jcodings
<lopex>
I mean, before
shellac_ has joined #jruby
rawra has quit [Remote host closed the connection]
GitHub17 has joined #jruby
GitHub17 has left #jruby [#jruby]
<GitHub17>
jcodings/master edb7b8e Charles Oliver Nutter: Fix typo in new UTF-8 codepoint length logic.
<GitHub17>
[jcodings] headius pushed 1 new commit to master: https://git.io/v7BCE
GitHub137 has joined #jruby
GitHub137 has left #jruby [#jruby]
<GitHub137>
[jcodings] headius tagged jcodings-1.0.23 at 9f4010d: https://git.io/v7BW2
GitHub190 has joined #jruby
GitHub190 has left #jruby [#jruby]
<GitHub190>
jcodings/master a9a3faf Charles Oliver Nutter: [maven-release-plugin] prepare release jcodings-1.0.23
<GitHub190>
[jcodings] headius pushed 1 new commit to master: https://git.io/v7BWz
GitHub83 has joined #jruby
GitHub83 has left #jruby [#jruby]
<GitHub83>
jcodings/master 0bbb033 Charles Oliver Nutter: [maven-release-plugin] prepare for next development iteration
<GitHub83>
[jcodings] headius pushed 1 new commit to master: https://git.io/v7BWa