yfeldblum has quit [Remote host closed the connection]
yfeldblum has joined #jruby
<GitHub25>
[jruby] lucasallan opened pull request #3830: Adds method #bitLength to Bignum (master...bignum-bit_length) https://git.io/vwVWu
enebo has joined #jruby
enebo has quit [Client Quit]
<GitHub157>
[jruby] lucasallan opened pull request #3831: Fixes Fixnum#bitLength when the value is negative. (master...Fixnum-bit_length) https://git.io/vwVlN
yfeldblum has quit [Remote host closed the connection]
pawnbox has joined #jruby
pawnbox has quit [Ping timeout: 276 seconds]
pawnbox has joined #jruby
yfeldblum has joined #jruby
yfeldblum has quit [Read error: Connection reset by peer]
yfeldblum has joined #jruby
johnsonch is now known as johnsonch_afk
nirvdrum_ has joined #jruby
nirvdrum_ has quit [Ping timeout: 268 seconds]
nirvdrum has quit [Ping timeout: 246 seconds]
sandelius has joined #jruby
xardion has quit [Ping timeout: 260 seconds]
thedarkone2 has quit [Quit: thedarkone2]
xardion has joined #jruby
<GitHub13>
[jruby] kares closed issue #3827: Bignum#bit_length is missing https://git.io/vwgsT
<GitHub126>
[jruby] kares closed issue #3829: Fixnum#bit_length always returns 64 for negative number https://git.io/vwgjd
<GitHub95>
[jruby] kares closed pull request #3831: Fixes Fixnum#bitLength when the value is negative. (master...Fixnum-bit_length) https://git.io/vwVlN
<GitHub121>
jruby/master 9b63036 Karol Bucek: Merge pull request #3831 from lucasallan/Fixnum-bit_length...
<GitHub121>
jruby/master 8da72df Lucas Amorim: Fixes Fixnum#bitLength when the value is negative.
camlow325 has quit [Remote host closed the connection]
<headius>
kares: I'm looking at the big one now
<headius>
I have been trying to mostly do new JI stuff under org.jruby.java rather than add to javasupport
camlow325 has joined #jruby
benlovell has joined #jruby
<headius>
so maybe we could move the javasupport/ext package to java/ext
<kares>
headius: I see - there's still pieces to stay there
<headius>
it boots stuff like ArrayJavaProxy which already live under java.**
<kares>
one reason its that way its stack-trace filtering
<kares>
org.jruby.java is filtered org.jruby.javasupport is not
<kares>
although its not intentional
<headius>
ahh, hmm
<headius>
what's that filtering for?
<kares>
also javasupport.Java is there
<kares>
headius: .java pieces you do not see in backtraces
<headius>
right, ok
<kares>
which is really annoying - for those ext would prefer to have .java parts kept
<headius>
yeah I'm not sure why we still need that filtering
<kares>
under java there's invokers which is ok to get filtered
<headius>
is that in the backtrace logic or in the Java exception logic?
<kares>
well traces get really noisy
<kares>
nope its elsewhere completely
<kares>
under TraceType I think
subbu|lunch is now known as subbu
<kares>
have been adjusting it as previously it filtered almost everything from under org.jruby.xxx
benlovell has quit [Ping timeout: 252 seconds]
<kares>
which is not good for org.jruby.rack
<headius>
ohmm
<kares>
guess I'm fine with moving under java.ext its that there's likely some internals shared with javasupport.Java
<headius>
kares: well don't worry about it for now
<headius>
it's not public API so I'll have a look when it's merged
<kares>
OK
<headius>
ahh ok, this is the filtering to get Java stack elements to show up without showing all JRuby's guts
<enebo>
k
<headius>
I see your comment...just filtering proxy might make sense
<enebo>
that was me trying tyo change my KVM
<headius>
the goal was to filter out core class internal methods and jruby runtime
<kares>
thought so
<kares>
anyways that part already has some new Java/Ruby tests - so that it does not filter too much
<headius>
ok
<headius>
kares: I'm willing to go on faith for the rest of the 10k lines of this PR :-)
<headius>
I would echo Tom's comments about just dropping the .rb files, perhaps preserving any comments there that might be relevant
<kares>
headius: mostly new specs - covering previously not covered functionality
yfeldblum has joined #jruby
<kares>
headius: that is already handled
<enebo>
yeah that cannot be removed without internal registration
<headius>
ok
<kares>
and there's new doc in the .rb files that will be used to generate yardoc
<headius>
I'm guessing they're stubbed there for doco
<kares>
adds up quite a few + lines as well
<headius>
right, ok
<kares>
yes stubbed - theres if false around module/class defs
<headius>
enebo: those files could be required but it would be super weird
<kares>
headius: there's one thing Tom agreed on
<headius>
you'd have to require jruby/java/java_ext/java.io.rb or whatever
<kares>
wasn't originally in the PR - its handling conflicts
<kares>
e.g. java.util.List#sort
<kares>
will now have ruby_sort name for users to deal with the conflict if they want to
<kares>
same for Map#merge etc
<headius>
yeah I saw that, that seems fine
<headius>
we should always let Java methods win since that's a losing fight
<kares>
yes that's the case
nirvdrum has quit [Ping timeout: 250 seconds]
<headius>
kares: that's all four reviewed...go for it
<kares>
headius: yay, thanks
<headius>
sorry for the delay!
<kares>
have about lan5432's InterfaceClass.new removal? you guys want that kept?
<headius>
that stupid super/frame leak bug took forever
<headius>
enebo: I'm fine with that
<kares>
enebo: ^^ ?
<headius>
we have not talked about or documented that...maybe ever
<GitHub4>
[jruby] yuki24 opened pull request #3832: Fix a bug where NameError#receiver raises an ArgumentError after #to_s is called (master...fix-nameerror-receiver) https://git.io/vwrXO
digitalextremist has quit [Ping timeout: 250 seconds]
nirvdrum has quit [Read error: No route to host]
nirvdrum has joined #jruby
<headius>
enebo: I have not seen that, no
<GitHub17>
[jruby] headius closed pull request #3832: Fix a bug where NameError#receiver raises an ArgumentError after #to_s is called (master...fix-nameerror-receiver) https://git.io/vwrXO
<GitHub33>
jruby/master 31e6aa4 Brandon Fish: [Truffle] Implement more of Bignum#<<
digitalextremist has joined #jruby
lanceball is now known as lance|afk
<enebo>
kares: you still up
bbrowning is now known as bbrowning_away
<enebo>
kares: I was looking at RUNNING_TESTS.md and I saw this: rake appraisal:rails32 test_mysql TEST=test/db/mysql/rake_test.rb
<enebo>
kares: this is no longer a thing? how do you test stuff?
<enebo>
kares: oh maybe it is but I need to install it
benlovell has joined #jruby
digitalextremist has quit [Ping timeout: 240 seconds]
digitalextremist has joined #jruby
benlovell has quit [Ping timeout: 260 seconds]
pawnbox has quit [Read error: Connection reset by peer]
e_dub has joined #jruby
Aethenelle has quit [Quit: Aethenelle]
dling has joined #jruby
digitalextremist has quit [Ping timeout: 268 seconds]
digitalextremist has joined #jruby
shellac has quit [Quit: Computer has gone to sleep.]
camlow325 has quit [Remote host closed the connection]
Caerus has quit [Ping timeout: 250 seconds]
camlow325 has joined #jruby
<GitHub141>
[jruby] lucasallan opened pull request #3833: Fixnum#bit_length - uses bit inversion when the value is negative (master...fixnum-bitlength) https://git.io/vwoIB
e_dub has quit [Quit: ZZZzzz…]
camlow32_ has joined #jruby
camlow325 has quit [Ping timeout: 240 seconds]
benlovell has joined #jruby
benlovell has quit [Ping timeout: 250 seconds]
enebo has quit [Quit: enebo]
<GitHub122>
[jruby] chrisseaton pushed 11 new commits to master: https://git.io/vwoYI
<GitHub122>
jruby/master 747dba4 Chris Seaton: [Truffle] Put out trust in Truffle's splitter and inliner.
<GitHub122>
jruby/master 7b20b59 Chris Seaton: [Truffle] Tidy up AttachmentsManager.
<GitHub122>
jruby/master be7badd Chris Seaton: [Truffle] Move Truffle::Primitive to just Truffle
e_dub has joined #jruby
<GitHub80>
[jruby] chrisseaton pushed 2 new commits to master: https://git.io/vwoOx
<GitHub80>
jruby/master b1707bb Chris Seaton: [Truffle] Truffle::Attachments module.
<GitHub80>
jruby/master 617be2d Chris Seaton: [Truffle] Fix another couple of GC typos.
skade has quit [Quit: Computer has gone to sleep.]