<FromGitter>
<Blacksmoke16> not a fan of the `start_document` and `finish` methods but dont have any better ideas atm
<FromGitter>
<Blacksmoke16> since that should only run once, but cant couple the navigator with something more specific
<FromGitter>
<Blacksmoke16> maybe make it like `prepare` and `finish` and add them to the interface, visitors can use that for whatever initialization/cleanup they need?
sorcus has quit [Ping timeout: 260 seconds]
sorcus has joined #crystal-lang
<FromGitter>
<Blacksmoke16> wow, literally took 5min to add yaml support
<FromGitter>
<Blacksmoke16> now lets try xml...
<FromGitter>
<Blacksmoke16> eh save that for later, be a bit trickier since it doesnt use anonymous elements
_whitelogger has joined #crystal-lang
alexherbo28 has joined #crystal-lang
alexherbo2 has quit [Ping timeout: 240 seconds]
alexherbo28 is now known as alexherbo2
alex`` has quit [Ping timeout: 268 seconds]
alex`` has joined #crystal-lang
martinium has joined #crystal-lang
<FromGitter>
<grkek> @Blacksmoke16 Updated the framework and it looks a lot less ugly than it was before
<renich>
We have a docker container for crystal, right? Does it run on alpine?
<FromGitter>
<straight-shoota> The TCP spec failures are not important. It's just a different error message than expected. This needs to be fixed, but is not to worry
<FromGitter>
<straight-shoota> alpine based Docker image is technically only a preview available, but should ship with the next release
<renich>
straight-shoota: OK. Figured as much. Same for the xml one?
<renich>
straight-shoota: yeah, noticed the `apt-get` commands :S
* renich
is not an Unbuntu fan
<renich>
I've noticed we have a libxml2-static here. I'll try to build with that one to see if the test passes.
<FromGitter>
<straight-shoota> You can use `crystallang/crystal:ci-test-dev-alpine` right now for an alpine based image, or wait for next release
<FromGitter>
<straight-shoota> Yes, XML error seems to be a similar issue
<renich>
straight-shoota: thanks.
<renich>
straight-shoota: yeah, figured as much.
<Yxhuvud>
That cookie spec failure seems to happen on ubuntu too, btw.
<renich>
Yxhuvud: it's just a matter of updating the test's date to 2021, IMHO
<renich>
The purpose of that test is to see if a cookie is expired, right? I dunno why don't they set it to 2100 or something like that. Might have to do something with the unix time or the 2k bug ;D
<renich>
man... the crystal wrapper script is longer than I expected...
<FromGitter>
<straight-shoota> Cookie spec is fixed in master (#8640)
<renich>
Yeah, better to set it to something like current + 2, eh? ;D
<Yxhuvud>
You mean I have to do git pull too! Bah!
ht_ has quit [Remote host closed the connection]
straight-shoota has joined #crystal-lang
straight-shoota has quit [Quit: leaving]
Yxhuvud has quit [Read error: Connection reset by peer]
<FromGitter>
<straight-shoota> renich the XML spec fails starting at libxml2 2.9.10. Seems like there was some change in the library, but I can't pin it down.