RX14 changed the topic of #crystal-lang to: The Crystal programming language | http://crystal-lang.org | Crystal 0.20.1 | Fund Crystal's development: http://is.gd/X7PRtI | Paste > 3 lines of text to https://gist.github.com | GH: https://github.com/crystal-lang/crystal | Docs: http://crystal-lang.org/docs/ | API: http://crystal-lang.org/api/ | Logs: http://irclog.whitequark.org/crystal-lang
soveran has quit [Remote host closed the connection]
jsaak has quit [Ping timeout: 245 seconds]
jsaak has joined #crystal-lang
akwiatkowski has quit [Ping timeout: 264 seconds]
<crystal-gh> [crystal] taylorfinnell opened pull request #3697: Remove dot segments in uri path as per RFC 3986 6.2.2.3 (master...remove-dot-segments-in-uri-path) https://git.io/v1ymq
matp has joined #crystal-lang
soveran has joined #crystal-lang
elia has quit [Quit: (IRC Client: textualapp.com)]
elia has joined #crystal-lang
elia has quit [Client Quit]
soveran has quit [Ping timeout: 250 seconds]
Guest36268 has quit []
<FromGitter> <bcardiff> @raydf you can find the options for the pool documented at at https://github.com/crystal-lang/crystal-db/blob/master/src/db/database.cr , there will be better docs.
Philpax has joined #crystal-lang
mgarciaisaia has joined #crystal-lang
Philpax has quit [Ping timeout: 268 seconds]
<FromGitter> <jwoertink> Has anyone deployed a crystal app to heroku?
<FromGitter> <raydf> @bcardiff, @spalladino thanks for the help. Excellent work and it's looking very interesting.
<FromGitter> <jwoertink> yup, I saw that. Running in to some issues
<FromGitter> <jwoertink> I have icr as a development_dependency
<FromGitter> <jwoertink> but when I deploy, it still wants to install it
<FromGitter> <jwoertink> ```code paste, see link``` [https://gitter.im/crystal-lang/crystal?at=5851f355c895451b75d8ce7d]
<FromGitter> <jwoertink> I'm wondering how others handle this
<FromGitter> <jwoertink> is there a way to tell shards to not install development_dependencies when running shards install in some cases?
<FromGitter> <jwoertink> like how ruby's bundler does `bundle --without development`
<FromGitter> <bcardiff> `crystal deps --production` should install all but development dependencies
<FromGitter> <bcardiff> but that should be added to the heroku buildpack
<FromGitter> <bcardiff> I am not sure if `--production` will be forwarded to shards executable. I think it will.
<FromGitter> <bcardiff> @jwoertink do you mind forking, trying and PR-ing if success?
<FromGitter> <bcardiff> although the story of postinstall scripts need some further analysis for heroku, the binaries should end in another location that is not read-only. But in this case --production might be enough
<FromGitter> <jwoertink> yeah, I'll send that over :)
<FromGitter> <jwoertink> thanks!
<FromGitter> <bcardiff> welcome. i hope it will work.
Philpax has joined #crystal-lang
<FromGitter> <raydf> @bcardiff , would this be ok for the url params? ⏎ ⏎ ```pg_url = "postgres://test:test@localhost:5432/test_development?max_pool_size=200" ``` [https://gitter.im/crystal-lang/crystal?at=5851f9590730ce6937c7e67a]
<FromGitter> <bcardiff> it shold
<FromGitter> <bcardiff> any issue?
<FromGitter> <raydf> Just wanted to make sure that the url params are spec correct
<FromGitter> <jwoertink> @bcardiff that worked! Submitted PR
<FromGitter> <bcardiff> default max_pool_size is 0 which means unlimited. (since crystal-db 0.2.2)
Ven has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
soveran has joined #crystal-lang
<FromGitter> <raydf> yeah, i don't like that default parameter :).
<FromGitter> <bcardiff> that's fine :-)
<FromGitter> <raydf> How does the retry_attempts should work?
<FromGitter> <raydf> on connection error?
soveran has quit [Ping timeout: 245 seconds]
<FromGitter> <bcardiff> yeay...... we miss that in pg driver. https://github.com/crystal-lang/crystal-db/issues/29#issuecomment-267217159
<FromGitter> <raydf> OK, nice to know the current limitations for pg.
<FromGitter> <bcardiff> bye yeah, upon failure read/write from the socket a DB::ConnectionLost should be raised.
<FromGitter> <bcardiff> you can patch DB::Pool(T) for your project. Copy Pool#retry from https://github.com/crystal-lang/crystal-db/blob/master/src/db/pool.cr#L91 and change the exeception type to catch. Or... wait for some more fixes in pg
<FromGitter> <bcardiff> The retry does not do exponential backup. But it waits a bit `retry_delay` seconds between each try.
<FromGitter> <raydf> yeah i deduced that part. I believe exponential delay is like too much :), but maybe later there could be a new option.
<FromGitter> <bcardiff> Maybe in the patch you might just need to trap `IO::EOFError` I am not sure yet how a connection lost is raised in crystal-pg
<FromGitter> <raydf> I read the code some months ago and i believe crystal-pg only have a generic DB::Error. We were looking in a solution like kostya redisoid.
<FromGitter> <bcardiff> is there any particualr feature of redisoid reconnect logic that you think is might not be covered by retrying with constant backoff?
<FromGitter> <raydf> not for my needs, implementation looks amazing. I'll keep testing extensively so i'll try to give any feedback about my findings.
<FromGitter> <bcardiff> That would be great. Thanks! Apologies for the turbulence with PG, it was great that will joind the crystal-db land with a native driver but there is more work to be done still probably.
Raimondi has quit [Quit: WeeChat 1.6-dev]
mgarciaisaia has quit [Ping timeout: 248 seconds]
mgarciaisaia has joined #crystal-lang
vikaton has joined #crystal-lang
jamie_ca has quit [Ping timeout: 250 seconds]
jamie_ca has joined #crystal-lang
soveran has joined #crystal-lang
soveran has quit [Ping timeout: 256 seconds]
jamie_ca has quit [Ping timeout: 252 seconds]
jamie_ca has joined #crystal-lang
Raimondi has joined #crystal-lang
mgarciaisaia has quit [Ping timeout: 260 seconds]
mgarciaisaia has joined #crystal-lang
bjz has joined #crystal-lang
bjz has quit [Read error: Connection reset by peer]
bjz has joined #crystal-lang
bjz has quit [Read error: Connection reset by peer]
bjz has joined #crystal-lang
vikaton has quit [Quit: Connection closed for inactivity]
mgarciaisaia has quit [Ping timeout: 258 seconds]
soveran has joined #crystal-lang
soveran has quit [Ping timeout: 240 seconds]
mgarciaisaia has joined #crystal-lang
<FromGitter> <jots_twitter> This looks pretty neat: http://godbolt.org/ has versions for C++/Rust/D/Go I wonder if crystal could be added.
Philpax has quit [Ping timeout: 268 seconds]
pabs has quit [Ping timeout: 244 seconds]
mgarciaisaia has quit [Quit: Leaving.]
pabs has joined #crystal-lang
pawnbox has joined #crystal-lang
hako_ has quit [Read error: Connection reset by peer]
soveran has joined #crystal-lang
<crystal-gh> [crystal] MakeNowJust opened pull request #3699: Avoid TODO, not to include Enumeranle directly (master...fix/indexable/enumerable-todo) https://git.io/v1yrI
vivus-ignis has joined #crystal-lang
bjz_ has joined #crystal-lang
bjz has quit [Ping timeout: 260 seconds]
vivus-ignis has quit [Ping timeout: 252 seconds]
akwiatkowski has joined #crystal-lang
mark_66 has joined #crystal-lang
<crystal-gh> [crystal] MakeNowJust opened pull request #3700: Detect whether inside git worktree then output warning (master...fix/doc/check-git-worktree) https://git.io/v1yi7
elia has joined #crystal-lang
elia_ has joined #crystal-lang
elia has quit [Ping timeout: 248 seconds]
gloscombe has joined #crystal-lang
pawnbox has quit [Ping timeout: 258 seconds]
pawnbox has joined #crystal-lang
<crystal-gh> [crystal] Sija opened pull request #3701: Implement String#lchomp (master...string-lchomp) https://git.io/v1yFv
pawnbox_ has joined #crystal-lang
pawnbox__ has joined #crystal-lang
pawnbox has quit [Ping timeout: 250 seconds]
Ven has joined #crystal-lang
pawnbox_ has quit [Read error: Connection reset by peer]
Philpax has joined #crystal-lang
soveran has quit [Remote host closed the connection]
akwiatkowski has quit [Ping timeout: 264 seconds]
soveran has joined #crystal-lang
soveran has quit [Remote host closed the connection]
pawnbox__ has quit [Read error: Connection reset by peer]
pawnbox has joined #crystal-lang
soveran has joined #crystal-lang
emmanueloga_ has joined #crystal-lang
emmanueloga has quit [Ping timeout: 258 seconds]
emmanueloga_ is now known as emmanueloga
bjz has joined #crystal-lang
bjz_ has quit [Ping timeout: 256 seconds]
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
elia_ has quit [Quit: Computer has gone to sleep.]
<crystal-gh> [crystal] asterite pushed 8 new commits to master: https://git.io/v1STF
<crystal-gh> crystal/master 4e78f9f Ary Borenszweig: Fixed #3691: crash related to moving a union to a bigger one in a method arg
<crystal-gh> crystal/master 06f386d Ary Borenszweig: Removed a few TODOs
<crystal-gh> crystal/master 6b63706 Ary Borenszweig: Add missing spec
<crystal-gh> [crystal] kostya closed pull request #3631: split spec files, to module and runner (master...spec_split) https://git.io/v1WKk
soveran has quit [Remote host closed the connection]
<travis-ci> crystal-lang/crystal#366aec3 (master - Compiler: give proper error on undefined method on abstract metaclass. Fixes #2241): The build passed. https://travis-ci.org/crystal-lang/crystal/builds/184227731
<DeBot> https://github.com/crystal-lang/crystal/issues/2241 (can't execute `__temp_51[0]` at /tmp/example.cr:12:22: `__temp_51` has no type)
elia has joined #crystal-lang
soveran has joined #crystal-lang
soveran has quit [Remote host closed the connection]
soveran has joined #crystal-lang
elia has quit [Quit: Computer has gone to sleep.]
<crystal-gh> [crystal] MakeNowJust closed pull request #3699: Avoid TODO, not to include Enumeranle directly (master...fix/indexable/enumerable-todo) https://git.io/v1yrI
elia has joined #crystal-lang
<FromGitter> <bcardiff> @jots_twitter they run clang, so llvm is there. it should not be that hard. the maintener of the project seems to welcome more support. If you want to push that forward it should be possible for sure and something that will benefit the low-level fans. You can get the intermediate llvm code from the crystal compiler. And crystal emits I think the sourcemaps. I am not sure if that is used to match wich assembly lines correlates to
<FromGitter> ... which source files.
<FromGitter> <david50407> :+1:
mgarciaisaia has joined #crystal-lang
<crystal-gh> [crystal] MakeNowJust reopened pull request #3699: Avoid TODO, not to include Enumeranle directly (master...fix/indexable/enumerable-todo) https://git.io/v1yrI
Ven has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Philpax has quit [Ping timeout: 264 seconds]
akwiatkowski has joined #crystal-lang
mgarciaisaia has quit [Quit: Leaving.]
<crystal-gh> [crystal] splattael opened pull request #3702: Implement String#split with block (master...gh-string-split-block) https://git.io/v1SW1
mgarciaisaia has joined #crystal-lang
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
pawnbox has quit [Ping timeout: 260 seconds]
<crystal-gh> [crystal] splattael closed pull request #3702: Implement String#split with block (master...gh-string-split-block) https://git.io/v1SW1
<crystal-gh> [crystal] kostya closed pull request #2581: add cfiles (master...cfiles) https://git.io/vrLwy
<crystal-gh> [crystal] MakeNowJust opened pull request #3703: Revive Iterator#flatten from type inference hell (master...feature/iterator/flatten) https://git.io/v1SB7
<crystal-gh> [crystal] ysbaddaden reopened pull request #3702: Implement String#split with block (master...gh-string-split-block) https://git.io/v1SW1
<crystal-gh> [crystal] asterite opened pull request #3704: Add chomp option to gets, lines, each_line (master...feature/chomp) https://git.io/v1SR7
gloscombe has quit [Ping timeout: 245 seconds]
elia has quit [Quit: Computer has gone to sleep.]
gloscombe has joined #crystal-lang
<crystal-gh> [crystal] kostya closed pull request #3254: add Box#box (master...box) https://git.io/viOAg
mark_66 has quit [Quit: Leaving.]
pawnbox has joined #crystal-lang
soveran has quit [Remote host closed the connection]
<FromGitter> <rohanthewiz> So here's an idea, and I apologize if it has already been suggested: where are the T-shirts, mugs, etc? With such a cool logo, this is a great way to promote Crystal, and generate funds at the same time.
soveran has joined #crystal-lang
soveran has quit [Ping timeout: 256 seconds]
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
<FromGitter> <raydf> @bcardiff, is there any method for crystal-db like crystal-pg#to_hash ?
<FromGitter> <sdogruyol> Check query_all @raydf
<FromGitter> <raydf> can't find it in the source code
<FromGitter> <raydf> i'm looking statement.cr
<FromGitter> <raydf> found it, sorry :)
<FromGitter> <sdogruyol> Search all
<FromGitter> <raydf> Nice, thanks @sdogruyol.
<FromGitter> <splattael> @rohanthewiz I also want a Crystal shirt for sure!! :clap:
mjblack has quit [Ping timeout: 252 seconds]
mjblack has joined #crystal-lang
vivus-ignis has joined #crystal-lang
mgarciaisaia1 has joined #crystal-lang
mgarciaisaia has quit [Ping timeout: 252 seconds]
<FromGitter> <david50407> @splattael cool!
elia has joined #crystal-lang
pawnbox has quit [Remote host closed the connection]
<crystal-gh> [crystal] splattael opened pull request #3705: Allow testing on GitLab CI (master...gitlab) https://git.io/v1SF8
pawnbox has joined #crystal-lang
soveran has joined #crystal-lang
soveran has quit [Changing host]
soveran has joined #crystal-lang
elia has quit [Quit: Computer has gone to sleep.]
<BlaXpirit> not once in my life have i wanted to desecrate a surface with a sticker
<BlaXpirit> but yeah, shirts would be cool
<RX14> BlaXpirit, I would put a sticker on a laptop
<RX14> i mean there's not much going on on the back anyway
<BlaXpirit> there is cleanness going on
sp4rrow has joined #crystal-lang
<BlaXpirit> and they did make shirts, i think that was to give away on some convention
<crystal-gh> [crystal] asterite pushed 1 new commit to master: https://git.io/v19vs
<crystal-gh> crystal/master 02d4db3 Ary Borenszweig: Fixed #3706: rescue in initialize can lead to uninitialized instance variables
<FromGitter> <bcardiff> @raydf https://github.com/will/crystal-pg/pull/71 db pool should be working fine after that. it will reconnect/retry/✨/etc.
<FromGitter> <bcardiff> and #3706 was found in the middle of the process. It was the puzzle of the day.
<DeBot> https://github.com/crystal-lang/crystal/issues/3706 (Rescue in initialize can lead to uninitialized instance variables)
<crystal-gh> [crystal] asterite pushed 1 new commit to master: https://git.io/v19ku
<crystal-gh> crystal/master 0c6cd7a Ary Borenszweig: Compiler: don't match splat restriction by default. Fixes #3698
<FromGitter> <raydf> @bcardiff, nice :) again amazing turnaround. I'm using the shards and learning the api with your help, and @spalladino and @sdogruyol help also.
<FromGitter> <bcardiff> :thumbsup:
<FromGitter> <raydf> does transactions features are already working?
<FromGitter> <bcardiff> at will/crystal-pg@master yes.
<FromGitter> <raydf> nice
<FromGitter> <bcardiff> at bcardiff/crystal-pg/tree/feature/db-0.3.1 even connection pool
<FromGitter> <raydf> i'll update my local repo for testing.
<FromGitter> <bcardiff> will has been merging pretty quickly. it shouldn't be long to reach master
<FromGitter> <bcardiff> thanks
<crystal-gh> [crystal] asterite pushed 1 new commit to master: https://git.io/v19s9
<crystal-gh> crystal/master fae6cc4 Ary Borenszweig: Simplify exception spec
<travis-ci> crystal-lang/crystal#02d4db3 (master - Fixed #3706: rescue in initialize can lead to uninitialized instance variables): The build passed. https://travis-ci.org/crystal-lang/crystal/builds/184319807
<DeBot> https://github.com/crystal-lang/crystal/issues/3706 (Rescue in initialize can lead to uninitialized instance variables)
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
soveran has quit [Remote host closed the connection]
Ven has joined #crystal-lang
<travis-ci> crystal-lang/crystal#0c6cd7a (master - Compiler: don't match splat restriction by default. Fixes #3698): The build has errored. https://travis-ci.org/crystal-lang/crystal/builds/184328954
<DeBot> https://github.com/crystal-lang/crystal/issues/3698 (Bug: unsupported restriction: Array(T) vs. *T)
sp4rrow has joined #crystal-lang
Ven has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
sp4rrow has quit [Quit: The Internet needs a break and I need a cookie]
sp4rrow has joined #crystal-lang
<travis-ci> crystal-lang/crystal#fae6cc4 (master - Simplify exception spec): The build passed. https://travis-ci.org/crystal-lang/crystal/builds/184340282
<maxpowa> Question: Is there a better way to do this? if value[:type] == Int8 || value[:type] == Int16 || value[:type] == Int32
<Papierkorb> try `[Int8, Int16, Int32].includes?(values[:type])`
<maxpowa> ah
<maxpowa> good call
gloscombe has quit [Remote host closed the connection]
Ven has joined #crystal-lang
<crystal-gh> [crystal] andrewhamon opened pull request #3708: Make a Handleable module to replace HTTP::Handler (master...handleable-module) https://git.io/v19aH
Philpax has joined #crystal-lang
<crystal-gh> [crystal] asterite pushed 1 new commit to master: https://git.io/v19V2
<crystal-gh> crystal/master 0172980 TSUYUSATO Kitsune: Not include Enumerable directly...
<crystal-gh> [crystal] asterite closed pull request #3694: Fix File.expand_path when HOME ends with / (master...bugfix/home-fixes) https://git.io/v1De5
pawnbox has quit [Remote host closed the connection]
Philpax has quit [Ping timeout: 264 seconds]
<crystal-gh> [crystal] asterite closed pull request #3693: Wrap GenericInstanceType in link if type vars don't have link (master...fix/wrap-generic-instance-type-in-link) https://git.io/v1Mbu
<crystal-gh> [crystal] asterite pushed 1 new commit to master: https://git.io/v19rn
<crystal-gh> crystal/master 5f8eb46 Peter Suschlik: Replace unused `each_with_index` with simple `each`
<crystal-gh> [crystal] asterite closed pull request #3701: Implement String#lchomp (master...string-lchomp) https://git.io/v1yFv
soveran has joined #crystal-lang
soveran has quit [Remote host closed the connection]
<crystal-gh> [crystal] samueleaton opened pull request #3709: Adds strict option for string equality comparison (master...bug-spec-expect-raises-msg) https://git.io/v19KK
vivus-ignis has quit [Ping timeout: 252 seconds]
soveran has joined #crystal-lang
soveran has quit [Remote host closed the connection]
soveran has joined #crystal-lang
soveran has quit [Remote host closed the connection]
soveran has joined #crystal-lang
bjz has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
<travis-ci> crystal-lang/crystal#0c6cd7a (master - Compiler: don't match splat restriction by default. Fixes #3698): The build passed. https://travis-ci.org/crystal-lang/crystal/builds/184328954
<DeBot> https://github.com/crystal-lang/crystal/issues/3698 (Bug: unsupported restriction: Array(T) vs. *T)
bjz has joined #crystal-lang
<crystal-gh> [crystal] nesaulov opened pull request #3710: Started "auto" keyword, with basic autocompleter and generator (master...auto) https://git.io/v19yJ
<crystal-gh> [crystal] nesaulov closed pull request #3710: Started "auto" keyword, with basic autocompleter and generator (master...auto) https://git.io/v19yJ
soveran has quit [Remote host closed the connection]
bjz has quit [Max SendQ exceeded]
bjz has joined #crystal-lang
<FromGitter> <samueleaton> I see some people wrap their specs (`nil.should be_nil`) inside of an assert (`assert { nil.should be_nil }`). Whats the purpose/benefit?
bjz has quit [Ping timeout: 264 seconds]
snsei has joined #crystal-lang
snsei has quit []
lacour has joined #crystal-lang
<travis-ci> crystal-lang/crystal#0172980 (master - Not include Enumerable directly): The build passed. https://travis-ci.org/crystal-lang/crystal/builds/184369634
Ven has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<BlaXpirit> samueleaton, they write assert { } instead of it "asdf" do ... end
<BlaXpirit> these test cases don't deserve their own "it do" with a custom message, but you still want each of them to fail as a separate test case so you can clearly see which one and how many of them failed, instead of one fail cancelling the rest
<crystal-gh> [crystal] andrewhamon opened pull request #3711: Check formatting early in CI (master...travis-fail-fast) https://git.io/v19dA
soveran has joined #crystal-lang
soveran has quit [Ping timeout: 256 seconds]
<travis-ci> crystal-lang/crystal#1442555 (master - Fix File.expand_path when HOME ends with /): The build passed. https://travis-ci.org/crystal-lang/crystal/builds/184371393
vivus-ignis has joined #crystal-lang
vivus-ignis has quit [Ping timeout: 240 seconds]
elia has joined #crystal-lang