ismael_ has quit [Remote host closed the connection]
ismaelga has quit [Ping timeout: 246 seconds]
ssvb has joined #crystal-lang
Sadin has joined #crystal-lang
Sadin has quit [Ping timeout: 264 seconds]
<crystal-gh>
[crystal] will closed pull request #1840: Build all files in ./src when there are no arguments (master...buildall) http://git.io/vltCV
lokulin has quit [Ping timeout: 250 seconds]
blue_deref has quit [Quit: bbn]
Renich has quit [Quit: leaving]
lokulin has joined #crystal-lang
pawnbox has joined #crystal-lang
pawnbox_ has joined #crystal-lang
pawnbox has quit [Ping timeout: 272 seconds]
fowlduck has quit [Remote host closed the connection]
pawnbox_ has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
slash_nick is now known as slash_quit
slash_quit is now known as slash_nick
ponga has joined #crystal-lang
trapped has joined #crystal-lang
trapped has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
matp has quit [Excess Flood]
havenwood has quit [Excess Flood]
havenn has joined #crystal-lang
havenn has joined #crystal-lang
havenn is now known as havenwood
matp has joined #crystal-lang
kulelu88 has joined #crystal-lang
kulelu88 has joined #crystal-lang
trapped has joined #crystal-lang
ssvb has quit [Quit: Leaving]
trapped has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
pawnbox has quit [Remote host closed the connection]
pawnbox has joined #crystal-lang
matp has quit [Ping timeout: 240 seconds]
matp has joined #crystal-lang
trapped has joined #crystal-lang
pawnbox_ has joined #crystal-lang
pawnbox has quit [Ping timeout: 272 seconds]
bjmllr has quit [Ping timeout: 247 seconds]
bjmllr has joined #crystal-lang
<[spoiler]>
Should #first and #last use Enumerable's methods, or should they behave more like Ruby's? Namely Range's first returns @begin regardless whether the range is `x...x`, same for last. While the Enumerable spec requires a raise. If Raising is required, I could just remove first() and add first(n) to Enumerable (same for last, but last is missing altogether)
<[spoiler]>
however in (a...b).last will return b even if the range is exclusive
<[spoiler]>
so it's essentially a synonym for end
<[spoiler]>
(which I disagree with, personally)
<[spoiler]>
so I would vote we change this from Ruby's behaviour. Should I modify the PR and start a discussion there?
<jhass>
Yes, let's have this as a less epheremal discussion
<[spoiler]>
k
<jhass>
[spoiler]: also maybe split your PR up into smaller parts so we can get the uncontroversial stuff out of the way
xd1le has quit [Quit: ERC (IRC client for Emacs 24.5.1)]
<[spoiler]>
jhass: meant to, yeah
<[spoiler]>
oh you meant into multiple PRs or multiple commits?
<jhass>
multiple PRs actually
<[spoiler]>
Ah right
Sadin has joined #crystal-lang
Davy_CC_ has quit [Ping timeout: 250 seconds]
Davy_CC has joined #crystal-lang
kulelu88 has left #crystal-lang ["Leaving"]
<[spoiler]>
jhass: done (for range). lemme just add the specs for #last and #last? in Enumerable specs
<[spoiler]>
well lemme run the full spec actually last time i just ran the spec for range lol
* [spoiler]
groans.
<[spoiler]>
This will take an hour
<[spoiler]>
ok they all passed on my pc, but the i368 check fails on travis for some reason