adjtm has quit [Remote host closed the connection]
mhlavink has joined #linux-sunxi
victhor has joined #linux-sunxi
Gerwin_J has joined #linux-sunxi
stellirin has quit [Remote host closed the connection]
stellirin has joined #linux-sunxi
timdorohin has joined #linux-sunxi
CuriousBeaver0 has joined #linux-sunxi
csims10 has joined #linux-sunxi
The_Loko has quit [Read error: Connection reset by peer]
csims10 has quit [Remote host closed the connection]
CuriousBeaver0 has quit [Remote host closed the connection]
yann|work has quit [Ping timeout: 252 seconds]
f0xx has quit [Ping timeout: 240 seconds]
fkluknav has joined #linux-sunxi
AneoX_ has joined #linux-sunxi
AneoX has quit [Ping timeout: 252 seconds]
venb has joined #linux-sunxi
nuuuciano has joined #linux-sunxi
f0xx has joined #linux-sunxi
AneoX has joined #linux-sunxi
victhor has quit [Ping timeout: 252 seconds]
dddddd has joined #linux-sunxi
AneoX_ has quit [Ping timeout: 252 seconds]
AneoX_ has joined #linux-sunxi
AneoX has quit [Ping timeout: 245 seconds]
The_Loko has joined #linux-sunxi
jaganteki has quit [Ping timeout: 252 seconds]
brokenARM has joined #linux-sunxi
elros1 has joined #linux-sunxi
msimpson has quit [Quit: Leaving]
LargePrime has quit [Quit: Leaving]
yann|work has joined #linux-sunxi
jaganteki has joined #linux-sunxi
brokenARM has quit [Quit: Page closed]
clemens3 has joined #linux-sunxi
lurchi__ is now known as lurchi_
porco_ has joined #linux-sunxi
porco_ has quit [Remote host closed the connection]
lurchi_ is now known as lurchi__
fl_0 has quit [Ping timeout: 246 seconds]
spiraliz has joined #linux-sunxi
sunshavi has joined #linux-sunxi
fl_0 has joined #linux-sunxi
spiraliz has quit [Remote host closed the connection]
JohnDoe_71Rus has joined #linux-sunxi
<diego71>
tjader: do you want to contribute a patch on the linux-sunxi mailing list? Maybe it's useful for someone else...
jaganteki has quit [Ping timeout: 252 seconds]
<tjader>
diego71: I'm looking into that, some of what I did had already been done on the sunxi tree
<tjader>
It seems the proper thing to do is to rebase my work on sunxi/dt64-for-4.20 branch
rexxster has joined #linux-sunxi
jbrown has joined #linux-sunxi
kaspter1 has joined #linux-sunxi
will__ has joined #linux-sunxi
kaspter has quit [Ping timeout: 252 seconds]
kaspter1 has quit [Ping timeout: 246 seconds]
f0xx has quit [Ping timeout: 245 seconds]
<diego71>
good idea
<tjader>
The kernel maintainers file does not mention the linux-sunxi list, though. Is it better to send to that list of to the proper maintainers?
The_Loko has quit [Read error: Connection reset by peer]
<wens>
always send to what the maintainers file lists
<tjader>
Okay then
<tjader>
That would be you, Maxime and linux-arm-kernel, right?
<montjoie>
tjader: use get_maintainer.pl
<montjoie>
since it's DT file you will have additionnal people
<tjader>
get_maintainer.pl added a couple of people, the devicetree mailing list and the main lkml
<montjoie>
always use get_maintainer.pl and after you can add more people if needed
The_Loko has joined #linux-sunxi
<montjoie>
tjader: also use checkpatch
<montjoie>
it will prevent some comment
jbrown has quit [Ping timeout: 244 seconds]
selfbg has quit [Ping timeout: 240 seconds]
<wens>
checkpatch with --strict
<tjader>
Just mailed two paths, hopefully I did everything right
pinkfluffysocks has joined #linux-sunxi
<tjader>
wens: I hadn't used --strict, but just checked now and it found no problems
<tjader>
two patches*
pinkfluffysocks has quit [Remote host closed the connection]
<montjoie>
tjader: your commit message is tiny
elros1 has quit [Remote host closed the connection]
<tjader>
What more should I add?
<montjoie>
this patch enable emmc on the xxx. The change was copier from the dt of xxxx
<tjader>
Okay, I'll edit it on my local repo for a future v2
<tjader>
Is the other message alright or should I expand it as well?
<wens>
you might want to mention where the numbers came from
f0xx has joined #linux-sunxi
<wens>
and DT should match the schmatics, not just "copied snippet" :)
reinforce has quit [Quit: Leaving.]
jbrown has joined #linux-sunxi
<tjader>
On my edited commit message I mention that the Teres-I uses the same board as the OLinuXino
<tjader>
To justify using the same values
<tjader>
It's lunch time for me now, but keep the comments coming and I'll reply when I get back
<tjader>
Thanks for all the help
kaspter has joined #linux-sunxi
rexxster has quit [Remote host closed the connection]
Andy-D__ has joined #linux-sunxi
Andy-D_ has quit [Ping timeout: 252 seconds]
jaganteki has joined #linux-sunxi
reinforce has joined #linux-sunxi
tnovotny has joined #linux-sunxi
jbrown has quit [Ping timeout: 245 seconds]
<tjader>
One thing just ocurred to me: there are three different variants of the A64-OLinuXino, shouldn't we have three device trees?
parco has joined #linux-sunxi
<tjader>
There's no eMMC+no wifi / eMMC + wifi / eMMC + no wifi
<tjader>
Won't having emmc and wifi enabled cause problems for the devices that don't have those?
mossroy has quit [Quit: Leaving]
yann|work has quit [Ping timeout: 240 seconds]
rexxster has joined #linux-sunxi
msimpson has joined #linux-sunxi
<parco>
I'm using a bananapi m2m with mainline stuff. The patch mentions the Wifi chip AP6212, but I don't see any mention of it in the dts, is it supported?
AneoX has joined #linux-sunxi
AneoX_ has quit [Ping timeout: 252 seconds]
afaerber has joined #linux-sunxi
afaerber has quit [Remote host closed the connection]
<tnovotny>
parco: we are using AP6210 (I don't know the difference comparing to AP6212) and it works on our mainlined tablet well
<parco>
tnovotny: oh nice, what allwinner chip are you using?
<tnovotny>
parco: A83t
<parco>
is that something that needs specified in DTS?
<parco>
interesting, so maybe it's setup as standard UART or something, then userspace just loads the driver for it...
<tnovotny>
it is SDIO
<tnovotny>
it is on &mmc1 in the dts mentioned above
<parco>
Oh yea, in your dts I see the bcm4329 mentioned in mmc1
<tnovotny>
yeap
<parco>
thanks that helps a bunch
<tjader>
Maybe doing something like it was done for pine64 and pine64+ is a good approach. Having sun50i-a64-olinuxino-1G0G.dts for the model that has neither, then sun50i-a64-olinuxino-2G16G-IND.dts includes that file and adds eMMC and then sun50i-a64-olinuxino-1G4GW.dts includes that and adds WiFi
clemens3 has quit [Ping timeout: 245 seconds]
<parco>
tjader: or for the very minor details, just have comment blocks in the device tree file
<tjader>
What do you mean?
<tjader>
Leave it enabled for all and mention that some boards don't have the device?
<parco>
tjader: exactly, or leave the nodes commented out by default, and make the user uncomment them to enable
<parco>
or find the greatest common denominator, stick that in a dtsi, and make dtb's for each of the 3 types of production boards
<tjader>
I think leaving them disabled is not very user friendly, it would force every user to recompile it
<parco>
s/dtb/dts
<tjader>
Can leaving a non-existent device enabled cause problems?
<tjader>
The simplest way would be having only one DT and having everything enabled on it
<wens>
you don't have to recompile
<tjader>
I don't know what kind of problems that could cause, and I don't have the boards to test
<wens>
you can either have the bootloader edit the DT on the fly, or load overlays
<tjader>
I only have the one that has both eMMC and Wifi
<tjader>
wens: is that preferrable to having three dtbs?
<tjader>
Like pine64 and pine64+
<wens>
tjader: a) it leaves the peripherals on and potentially consuming power (depends on driver)
<wens>
b) if someone were to accidentally short the pins (on the pine64), that would be bad
<wens>
because power on those pins might be on
<tjader>
Yeah, that's the kind of stuff I would be afraid of
<parco>
Does anybody have a patch for `sun8i-r16-bananapi-m2m.dts` to enable the on-board Wifi module (AP6212)?
<tjader>
That's why I suggested the approach with three separate device trees
<KotCzarny>
tjader: read about dt overlays
<wens>
for that approach, you could either have a base version .dts, and have the enhanced version include that, and enable additional peripherals
<KotCzarny>
although for emmc it leaves particular problem
<wens>
but for the pine it doesn't work so well because the module can be removed or replaced with some other module
<KotCzarny>
so maybe enable emmc on all and wifi as overlay
<tjader>
wens: base dts + two more dts for the other two variants is what I had in mind
netlynx has quit [Quit: Ex-Chat]
<tjader>
The current mainline already has a problem with that, it enables the wifi on mmc1, but only one of the three variants has that device
vagrantc has joined #linux-sunxi
tnovotny has quit [Quit: Leaving]
<tjader>
wens: I think it's best to drop the emmc pach I submitted today and have a patch for split dtbs and then add the emmc to that
jbrown has joined #linux-sunxi
Andy-D__ has quit [Remote host closed the connection]
m4ssi has quit [Remote host closed the connection]
fayelund10 has joined #linux-sunxi
fayelund10 has quit [Remote host closed the connection]